* [PATCH] MIPS: Malta: Enable BLK_DEV_INITRD
@ 2022-02-08 19:17 Nathan Chancellor
2022-02-09 2:53 ` Kees Cook
2022-02-09 13:34 ` Thomas Bogendoerfer
0 siblings, 2 replies; 3+ messages in thread
From: Nathan Chancellor @ 2022-02-08 19:17 UTC (permalink / raw)
To: Thomas Bogendoerfer
Cc: linux-mips, linux-kernel, Nick Desaulniers, Kees Cook, Nathan Chancellor
This configuration is useful for boot testing malta_defconfig in QEMU
with just a simple cpio initrd, instead of a full ext4 rootfs.
This results in an increase of ~164KB of vmlinux (with GCC 11.2.0):
$ diskus vmlinux.before
11.19 MB (11,194,368 bytes)
$ diskus vmlinux.after
11.36 MB (11,358,208 bytes)
This size increase comes from the fact that usr/Kconfig is sourced when
CONFIG_BLK_DEV_INITRD is enabled, which defaults to supporting several
decompression algorithms for compressed initrds. This seems like a
reasonable tradeoff but these configurations could be disabled in the
future if there are complaints about the size increase.
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
arch/mips/configs/malta_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mips/configs/malta_defconfig b/arch/mips/configs/malta_defconfig
index 3321bb576944..3456ac8ded6c 100644
--- a/arch/mips/configs/malta_defconfig
+++ b/arch/mips/configs/malta_defconfig
@@ -4,6 +4,7 @@ CONFIG_HIGH_RES_TIMERS=y
CONFIG_LOG_BUF_SHIFT=15
CONFIG_NAMESPACES=y
CONFIG_RELAY=y
+CONFIG_BLK_DEV_INITRD=y
CONFIG_EXPERT=y
# CONFIG_COMPAT_BRK is not set
CONFIG_SLAB=y
base-commit: dfd42facf1e4ada021b939b4e19c935dcdd55566
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: Malta: Enable BLK_DEV_INITRD
2022-02-08 19:17 [PATCH] MIPS: Malta: Enable BLK_DEV_INITRD Nathan Chancellor
@ 2022-02-09 2:53 ` Kees Cook
2022-02-09 13:34 ` Thomas Bogendoerfer
1 sibling, 0 replies; 3+ messages in thread
From: Kees Cook @ 2022-02-09 2:53 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Thomas Bogendoerfer, linux-mips, linux-kernel, Nick Desaulniers
On Tue, Feb 08, 2022 at 12:17:26PM -0700, Nathan Chancellor wrote:
> This configuration is useful for boot testing malta_defconfig in QEMU
> with just a simple cpio initrd, instead of a full ext4 rootfs.
>
> This results in an increase of ~164KB of vmlinux (with GCC 11.2.0):
>
> $ diskus vmlinux.before
> 11.19 MB (11,194,368 bytes)
>
> $ diskus vmlinux.after
> 11.36 MB (11,358,208 bytes)
>
> This size increase comes from the fact that usr/Kconfig is sourced when
> CONFIG_BLK_DEV_INITRD is enabled, which defaults to supporting several
> decompression algorithms for compressed initrds. This seems like a
> reasonable tradeoff but these configurations could be disabled in the
> future if there are complaints about the size increase.
>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
I'm all for having a regular way to test all defconfigs. So, FWIW:
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> arch/mips/configs/malta_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/configs/malta_defconfig b/arch/mips/configs/malta_defconfig
> index 3321bb576944..3456ac8ded6c 100644
> --- a/arch/mips/configs/malta_defconfig
> +++ b/arch/mips/configs/malta_defconfig
> @@ -4,6 +4,7 @@ CONFIG_HIGH_RES_TIMERS=y
> CONFIG_LOG_BUF_SHIFT=15
> CONFIG_NAMESPACES=y
> CONFIG_RELAY=y
> +CONFIG_BLK_DEV_INITRD=y
> CONFIG_EXPERT=y
> # CONFIG_COMPAT_BRK is not set
> CONFIG_SLAB=y
>
> base-commit: dfd42facf1e4ada021b939b4e19c935dcdd55566
> --
> 2.35.1
>
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: Malta: Enable BLK_DEV_INITRD
2022-02-08 19:17 [PATCH] MIPS: Malta: Enable BLK_DEV_INITRD Nathan Chancellor
2022-02-09 2:53 ` Kees Cook
@ 2022-02-09 13:34 ` Thomas Bogendoerfer
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Bogendoerfer @ 2022-02-09 13:34 UTC (permalink / raw)
To: Nathan Chancellor; +Cc: linux-mips, linux-kernel, Nick Desaulniers, Kees Cook
On Tue, Feb 08, 2022 at 12:17:26PM -0700, Nathan Chancellor wrote:
> This configuration is useful for boot testing malta_defconfig in QEMU
> with just a simple cpio initrd, instead of a full ext4 rootfs.
>
> This results in an increase of ~164KB of vmlinux (with GCC 11.2.0):
>
> $ diskus vmlinux.before
> 11.19 MB (11,194,368 bytes)
>
> $ diskus vmlinux.after
> 11.36 MB (11,358,208 bytes)
>
> This size increase comes from the fact that usr/Kconfig is sourced when
> CONFIG_BLK_DEV_INITRD is enabled, which defaults to supporting several
> decompression algorithms for compressed initrds. This seems like a
> reasonable tradeoff but these configurations could be disabled in the
> future if there are complaints about the size increase.
>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
> arch/mips/configs/malta_defconfig | 1 +
> 1 file changed, 1 insertion(+)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-09 13:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-08 19:17 [PATCH] MIPS: Malta: Enable BLK_DEV_INITRD Nathan Chancellor
2022-02-09 2:53 ` Kees Cook
2022-02-09 13:34 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).