linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] dt-bindings: serial: fsl-lpuart: Drop i.MX8QXP backwards compatibility
@ 2022-01-18 13:59 Abel Vesa
  2022-01-18 13:59 ` [PATCH 2/2] arm64: dts: imx8qxp-ss-adma: Drop fsl,imx7ulp-lpuart comaptible Abel Vesa
                   ` (4 more replies)
  0 siblings, 5 replies; 9+ messages in thread
From: Abel Vesa @ 2022-01-18 13:59 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Shawn Guo, Sascha Hauer,
	Fabio Estevam, Dong Aisheng, Peng Fan
  Cc: Pengutronix Kernel Team, linux-arm-kernel, Alexander Stein,
	linux-serial, devicetree, Linux Kernel Mailing List,
	NXP Linux Team

Drop the i.MX8QXP backwards compatibility with i.MX7ULP since they
differ from clocks handling point of view.

Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
---
 Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
index aa83cbf56d59..ff364bd0fbac 100644
--- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
+++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
@@ -20,11 +20,10 @@ properties:
           - fsl,ls1021a-lpuart
           - fsl,ls1028a-lpuart
           - fsl,imx7ulp-lpuart
+          - fsl,imx8qxp-lpuart
           - fsl,imxrt1050-lpuart
       - items:
-          - enum:
-              - fsl,imx8qxp-lpuart
-              - fsl,imx8ulp-lpuart
+          - const: fsl,imx8ulp-lpuart
           - const: fsl,imx7ulp-lpuart
       - items:
           - enum:
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 2/2] arm64: dts: imx8qxp-ss-adma: Drop fsl,imx7ulp-lpuart comaptible
  2022-01-18 13:59 [PATCH 1/2] dt-bindings: serial: fsl-lpuart: Drop i.MX8QXP backwards compatibility Abel Vesa
@ 2022-01-18 13:59 ` Abel Vesa
  2022-01-19  1:50   ` Peng Fan
  2022-01-29  6:15   ` Shawn Guo
  2022-01-19  1:50 ` [PATCH 1/2] dt-bindings: serial: fsl-lpuart: Drop i.MX8QXP backwards compatibility Peng Fan
                   ` (3 subsequent siblings)
  4 siblings, 2 replies; 9+ messages in thread
From: Abel Vesa @ 2022-01-18 13:59 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Shawn Guo, Sascha Hauer,
	Fabio Estevam, Dong Aisheng, Peng Fan
  Cc: Pengutronix Kernel Team, linux-arm-kernel, Alexander Stein,
	linux-serial, devicetree, Linux Kernel Mailing List,
	NXP Linux Team

The driver differs from clocks point of view, so the i.MX8QXP
is not backwards compatible with i.MX7ULP.

Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8qxp-ss-adma.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-ss-adma.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp-ss-adma.dtsi
index dc1daa8dc72f..7bae516004bf 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp-ss-adma.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qxp-ss-adma.dtsi
@@ -5,19 +5,19 @@
  */
 
 &lpuart0 {
-	compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
+	compatible = "fsl,imx8qxp-lpuart";
 };
 
 &lpuart1 {
-	compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
+	compatible = "fsl,imx8qxp-lpuart";
 };
 
 &lpuart2 {
-	compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
+	compatible = "fsl,imx8qxp-lpuart";
 };
 
 &lpuart3 {
-	compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
+	compatible = "fsl,imx8qxp-lpuart";
 };
 
 &i2c0 {
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* RE: [PATCH 1/2] dt-bindings: serial: fsl-lpuart: Drop i.MX8QXP backwards compatibility
  2022-01-18 13:59 [PATCH 1/2] dt-bindings: serial: fsl-lpuart: Drop i.MX8QXP backwards compatibility Abel Vesa
  2022-01-18 13:59 ` [PATCH 2/2] arm64: dts: imx8qxp-ss-adma: Drop fsl,imx7ulp-lpuart comaptible Abel Vesa
@ 2022-01-19  1:50 ` Peng Fan
  2022-02-09  2:53 ` Rob Herring
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 9+ messages in thread
From: Peng Fan @ 2022-01-19  1:50 UTC (permalink / raw)
  To: Abel Vesa, Greg Kroah-Hartman, Rob Herring, Shawn Guo,
	Sascha Hauer, Fabio Estevam, Aisheng Dong
  Cc: Pengutronix Kernel Team, linux-arm-kernel, Alexander Stein,
	linux-serial, devicetree, Linux Kernel Mailing List,
	dl-linux-imx

> Subject: [PATCH 1/2] dt-bindings: serial: fsl-lpuart: Drop i.MX8QXP backwards
> compatibility
> 
> Drop the i.MX8QXP backwards compatibility with i.MX7ULP since they differ
> from clocks handling point of view.
> 
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> ---
>  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> index aa83cbf56d59..ff364bd0fbac 100644
> --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> @@ -20,11 +20,10 @@ properties:
>            - fsl,ls1021a-lpuart
>            - fsl,ls1028a-lpuart
>            - fsl,imx7ulp-lpuart
> +          - fsl,imx8qxp-lpuart
>            - fsl,imxrt1050-lpuart
>        - items:
> -          - enum:
> -              - fsl,imx8qxp-lpuart
> -              - fsl,imx8ulp-lpuart
> +          - const: fsl,imx8ulp-lpuart
>            - const: fsl,imx7ulp-lpuart
>        - items:
>            - enum:
> --
> 2.31.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [PATCH 2/2] arm64: dts: imx8qxp-ss-adma: Drop fsl,imx7ulp-lpuart comaptible
  2022-01-18 13:59 ` [PATCH 2/2] arm64: dts: imx8qxp-ss-adma: Drop fsl,imx7ulp-lpuart comaptible Abel Vesa
@ 2022-01-19  1:50   ` Peng Fan
  2022-01-29  6:15   ` Shawn Guo
  1 sibling, 0 replies; 9+ messages in thread
From: Peng Fan @ 2022-01-19  1:50 UTC (permalink / raw)
  To: Abel Vesa, Greg Kroah-Hartman, Rob Herring, Shawn Guo,
	Sascha Hauer, Fabio Estevam, Aisheng Dong
  Cc: Pengutronix Kernel Team, linux-arm-kernel, Alexander Stein,
	linux-serial, devicetree, Linux Kernel Mailing List,
	dl-linux-imx

> Subject: [PATCH 2/2] arm64: dts: imx8qxp-ss-adma: Drop fsl,imx7ulp-lpuart
> comaptible
> 
> The driver differs from clocks point of view, so the i.MX8QXP is not backwards
> compatible with i.MX7ULP.
> 
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> ---
>  arch/arm64/boot/dts/freescale/imx8qxp-ss-adma.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-ss-adma.dtsi
> b/arch/arm64/boot/dts/freescale/imx8qxp-ss-adma.dtsi
> index dc1daa8dc72f..7bae516004bf 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp-ss-adma.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp-ss-adma.dtsi
> @@ -5,19 +5,19 @@
>   */
> 
>  &lpuart0 {
> -	compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
> +	compatible = "fsl,imx8qxp-lpuart";
>  };
> 
>  &lpuart1 {
> -	compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
> +	compatible = "fsl,imx8qxp-lpuart";
>  };
> 
>  &lpuart2 {
> -	compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
> +	compatible = "fsl,imx8qxp-lpuart";
>  };
> 
>  &lpuart3 {
> -	compatible = "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
> +	compatible = "fsl,imx8qxp-lpuart";
>  };
> 
>  &i2c0 {
> --
> 2.31.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] arm64: dts: imx8qxp-ss-adma: Drop fsl,imx7ulp-lpuart comaptible
  2022-01-18 13:59 ` [PATCH 2/2] arm64: dts: imx8qxp-ss-adma: Drop fsl,imx7ulp-lpuart comaptible Abel Vesa
  2022-01-19  1:50   ` Peng Fan
@ 2022-01-29  6:15   ` Shawn Guo
  1 sibling, 0 replies; 9+ messages in thread
From: Shawn Guo @ 2022-01-29  6:15 UTC (permalink / raw)
  To: Abel Vesa
  Cc: Greg Kroah-Hartman, Rob Herring, Sascha Hauer, Fabio Estevam,
	Dong Aisheng, Peng Fan, Pengutronix Kernel Team,
	linux-arm-kernel, Alexander Stein, linux-serial, devicetree,
	Linux Kernel Mailing List, NXP Linux Team

On Tue, Jan 18, 2022 at 03:59:18PM +0200, Abel Vesa wrote:
> The driver differs from clocks point of view, so the i.MX8QXP
> is not backwards compatible with i.MX7ULP.
> 
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>

Applied, thanks!

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] dt-bindings: serial: fsl-lpuart: Drop i.MX8QXP backwards compatibility
  2022-01-18 13:59 [PATCH 1/2] dt-bindings: serial: fsl-lpuart: Drop i.MX8QXP backwards compatibility Abel Vesa
  2022-01-18 13:59 ` [PATCH 2/2] arm64: dts: imx8qxp-ss-adma: Drop fsl,imx7ulp-lpuart comaptible Abel Vesa
  2022-01-19  1:50 ` [PATCH 1/2] dt-bindings: serial: fsl-lpuart: Drop i.MX8QXP backwards compatibility Peng Fan
@ 2022-02-09  2:53 ` Rob Herring
  2022-02-09  6:50 ` Shawn Guo
  2022-02-10 20:18 ` Abel Vesa
  4 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2022-02-09  2:53 UTC (permalink / raw)
  To: Abel Vesa
  Cc: Fabio Estevam, Pengutronix Kernel Team,
	Linux Kernel Mailing List, Dong Aisheng, devicetree,
	linux-arm-kernel, linux-serial, Alexander Stein, Peng Fan,
	Greg Kroah-Hartman, Shawn Guo, NXP Linux Team, Sascha Hauer

On Tue, 18 Jan 2022 15:59:17 +0200, Abel Vesa wrote:
> Drop the i.MX8QXP backwards compatibility with i.MX7ULP since they
> differ from clocks handling point of view.
> 
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> ---
>  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] dt-bindings: serial: fsl-lpuart: Drop i.MX8QXP backwards compatibility
  2022-01-18 13:59 [PATCH 1/2] dt-bindings: serial: fsl-lpuart: Drop i.MX8QXP backwards compatibility Abel Vesa
                   ` (2 preceding siblings ...)
  2022-02-09  2:53 ` Rob Herring
@ 2022-02-09  6:50 ` Shawn Guo
  2022-02-09 15:04   ` Rob Herring
  2022-02-10 20:18 ` Abel Vesa
  4 siblings, 1 reply; 9+ messages in thread
From: Shawn Guo @ 2022-02-09  6:50 UTC (permalink / raw)
  To: Abel Vesa
  Cc: Greg Kroah-Hartman, Rob Herring, Sascha Hauer, Fabio Estevam,
	Dong Aisheng, Peng Fan, Pengutronix Kernel Team,
	linux-arm-kernel, Alexander Stein, linux-serial, devicetree,
	Linux Kernel Mailing List, NXP Linux Team

On Tue, Jan 18, 2022 at 03:59:17PM +0200, Abel Vesa wrote:
> Drop the i.MX8QXP backwards compatibility with i.MX7ULP since they
> differ from clocks handling point of view.
> 
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>

I tried to pick up the patch, but it failed to apply to my imx/bindings
branch.  Could you rebase?

Shawn

> ---
>  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> index aa83cbf56d59..ff364bd0fbac 100644
> --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> @@ -20,11 +20,10 @@ properties:
>            - fsl,ls1021a-lpuart
>            - fsl,ls1028a-lpuart
>            - fsl,imx7ulp-lpuart
> +          - fsl,imx8qxp-lpuart
>            - fsl,imxrt1050-lpuart
>        - items:
> -          - enum:
> -              - fsl,imx8qxp-lpuart
> -              - fsl,imx8ulp-lpuart
> +          - const: fsl,imx8ulp-lpuart
>            - const: fsl,imx7ulp-lpuart
>        - items:
>            - enum:
> -- 
> 2.31.1
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] dt-bindings: serial: fsl-lpuart: Drop i.MX8QXP backwards compatibility
  2022-02-09  6:50 ` Shawn Guo
@ 2022-02-09 15:04   ` Rob Herring
  0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2022-02-09 15:04 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Abel Vesa, Greg Kroah-Hartman, Sascha Hauer, Fabio Estevam,
	Dong Aisheng, Peng Fan, Pengutronix Kernel Team,
	linux-arm-kernel, Alexander Stein, open list:SERIAL DRIVERS,
	devicetree, Linux Kernel Mailing List, NXP Linux Team

On Wed, Feb 9, 2022 at 12:50 AM Shawn Guo <shawnguo@kernel.org> wrote:
>
> On Tue, Jan 18, 2022 at 03:59:17PM +0200, Abel Vesa wrote:
> > Drop the i.MX8QXP backwards compatibility with i.MX7ULP since they
> > differ from clocks handling point of view.
> >
> > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
>
> I tried to pick up the patch, but it failed to apply to my imx/bindings
> branch.  Could you rebase?

Shouldn't Greg be picking this up?

Rob

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] dt-bindings: serial: fsl-lpuart: Drop i.MX8QXP backwards compatibility
  2022-01-18 13:59 [PATCH 1/2] dt-bindings: serial: fsl-lpuart: Drop i.MX8QXP backwards compatibility Abel Vesa
                   ` (3 preceding siblings ...)
  2022-02-09  6:50 ` Shawn Guo
@ 2022-02-10 20:18 ` Abel Vesa
  4 siblings, 0 replies; 9+ messages in thread
From: Abel Vesa @ 2022-02-10 20:18 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Shawn Guo, Sascha Hauer,
	Fabio Estevam, Dong Aisheng, Peng Fan
  Cc: Pengutronix Kernel Team, linux-arm-kernel, Alexander Stein,
	linux-serial, devicetree, Linux Kernel Mailing List,
	NXP Linux Team

On 22-01-18 15:59:17, Abel Vesa wrote:
> Drop the i.MX8QXP backwards compatibility with i.MX7ULP since they
> differ from clocks handling point of view.
> 
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>

Please ignore this one and have a look at the V2 here:

https://lore.kernel.org/lkml/20220210201407.567860-1-abel.vesa@nxp.com/raw

> ---
>  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> index aa83cbf56d59..ff364bd0fbac 100644
> --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> @@ -20,11 +20,10 @@ properties:
>            - fsl,ls1021a-lpuart
>            - fsl,ls1028a-lpuart
>            - fsl,imx7ulp-lpuart
> +          - fsl,imx8qxp-lpuart
>            - fsl,imxrt1050-lpuart
>        - items:
> -          - enum:
> -              - fsl,imx8qxp-lpuart
> -              - fsl,imx8ulp-lpuart
> +          - const: fsl,imx8ulp-lpuart
>            - const: fsl,imx7ulp-lpuart
>        - items:
>            - enum:
> -- 
> 2.31.1
>

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2022-02-10 20:18 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-18 13:59 [PATCH 1/2] dt-bindings: serial: fsl-lpuart: Drop i.MX8QXP backwards compatibility Abel Vesa
2022-01-18 13:59 ` [PATCH 2/2] arm64: dts: imx8qxp-ss-adma: Drop fsl,imx7ulp-lpuart comaptible Abel Vesa
2022-01-19  1:50   ` Peng Fan
2022-01-29  6:15   ` Shawn Guo
2022-01-19  1:50 ` [PATCH 1/2] dt-bindings: serial: fsl-lpuart: Drop i.MX8QXP backwards compatibility Peng Fan
2022-02-09  2:53 ` Rob Herring
2022-02-09  6:50 ` Shawn Guo
2022-02-09 15:04   ` Rob Herring
2022-02-10 20:18 ` Abel Vesa

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).