* [PATCH] media: cedrus: h264: Fix neighbour info buffer size
@ 2022-02-14 19:08 Jernej Skrabec
2022-02-18 14:53 ` Nicolas Dufresne
0 siblings, 1 reply; 2+ messages in thread
From: Jernej Skrabec @ 2022-02-14 19:08 UTC (permalink / raw)
To: mripard, paul.kocialkowski
Cc: mchehab, wens, gregkh, hverkuil-cisco, linux-media,
linux-staging, linux-arm-kernel, linux-sunxi, linux-kernel,
Jernej Skrabec
According to BSP library source, H264 neighbour info buffer size needs
to be 32 kiB for H6. This is similar to H265 decoding, which also needs
double buffer size in comparison to older Cedrus core generations.
Increase buffer size to cover H6 needs. Since increase is not that big
in absolute numbers, it doesn't make sense to complicate logic for older
generations.
Issue was discovered using iommu and cross checked with BSP library
source.
Fixes: 6eb9b758e307 ("media: cedrus: Add H264 decoding support")
Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
---
drivers/staging/media/sunxi/cedrus/cedrus_h264.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_h264.c b/drivers/staging/media/sunxi/cedrus/cedrus_h264.c
index b4173a8926d6..d8fb93035470 100644
--- a/drivers/staging/media/sunxi/cedrus/cedrus_h264.c
+++ b/drivers/staging/media/sunxi/cedrus/cedrus_h264.c
@@ -38,7 +38,7 @@ struct cedrus_h264_sram_ref_pic {
#define CEDRUS_H264_FRAME_NUM 18
-#define CEDRUS_NEIGHBOR_INFO_BUF_SIZE (16 * SZ_1K)
+#define CEDRUS_NEIGHBOR_INFO_BUF_SIZE (32 * SZ_1K)
#define CEDRUS_MIN_PIC_INFO_BUF_SIZE (130 * SZ_1K)
static void cedrus_h264_write_sram(struct cedrus_dev *dev,
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: cedrus: h264: Fix neighbour info buffer size
2022-02-14 19:08 [PATCH] media: cedrus: h264: Fix neighbour info buffer size Jernej Skrabec
@ 2022-02-18 14:53 ` Nicolas Dufresne
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Dufresne @ 2022-02-18 14:53 UTC (permalink / raw)
To: Jernej Skrabec, mripard, paul.kocialkowski
Cc: mchehab, wens, gregkh, hverkuil-cisco, linux-media,
linux-staging, linux-arm-kernel, linux-sunxi, linux-kernel
Le lundi 14 février 2022 à 20:08 +0100, Jernej Skrabec a écrit :
> According to BSP library source, H264 neighbour info buffer size needs
> to be 32 kiB for H6. This is similar to H265 decoding, which also needs
> double buffer size in comparison to older Cedrus core generations.
>
> Increase buffer size to cover H6 needs. Since increase is not that big
> in absolute numbers, it doesn't make sense to complicate logic for older
> generations.
>
> Issue was discovered using iommu and cross checked with BSP library
> source.
>
> Fixes: 6eb9b758e307 ("media: cedrus: Add H264 decoding support")
> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Acked-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> ---
> drivers/staging/media/sunxi/cedrus/cedrus_h264.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_h264.c b/drivers/staging/media/sunxi/cedrus/cedrus_h264.c
> index b4173a8926d6..d8fb93035470 100644
> --- a/drivers/staging/media/sunxi/cedrus/cedrus_h264.c
> +++ b/drivers/staging/media/sunxi/cedrus/cedrus_h264.c
> @@ -38,7 +38,7 @@ struct cedrus_h264_sram_ref_pic {
>
> #define CEDRUS_H264_FRAME_NUM 18
>
> -#define CEDRUS_NEIGHBOR_INFO_BUF_SIZE (16 * SZ_1K)
> +#define CEDRUS_NEIGHBOR_INFO_BUF_SIZE (32 * SZ_1K)
> #define CEDRUS_MIN_PIC_INFO_BUF_SIZE (130 * SZ_1K)
>
> static void cedrus_h264_write_sram(struct cedrus_dev *dev,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-18 14:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-14 19:08 [PATCH] media: cedrus: h264: Fix neighbour info buffer size Jernej Skrabec
2022-02-18 14:53 ` Nicolas Dufresne
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).