From: Guenter Roeck <linux@roeck-us.net>
To: Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: mripard@kernel.org, wens@csie.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
Michael Klein <michael@fossekall.de>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>
Subject: Re: [PATCH v2] ARM: dts: sun8i: Adjust power key nodes
Date: Mon, 14 Feb 2022 16:27:32 -0800 [thread overview]
Message-ID: <20220215002732.GA3215504@roeck-us.net> (raw)
In-Reply-To: <20211129165510.370717-1-jernej.skrabec@gmail.com>
Hi,
On Mon, Nov 29, 2021 at 05:55:10PM +0100, Jernej Skrabec wrote:
> Several H3 and one H2+ board have power key nodes, which are slightly
> off. Some are missing wakeup-source property and some have BTN_0 code
> assigned instead of KEY_POWER.
>
> Adjust them, so they can function as intended by designer.
>
> Co-developed-by: Michael Klein <michael@fossekall.de>
> Signed-off-by: Michael Klein <michael@fossekall.de>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
This patch results in the following traceback when rebooting an
orangepi-pc qemu emulation.
[ 30.899594]
[ 30.899685] ============================================
[ 30.899757] WARNING: possible recursive locking detected
[ 30.899938] 5.17.0-rc3-00394-gc849047c2473 #1 Not tainted
[ 30.900055] --------------------------------------------
[ 30.900124] init/307 is trying to acquire lock:
[ 30.900246] c2dfe27c (&irq_desc_lock_class){-.-.}-{2:2}, at: __irq_get_desc_lock+0x58/0xa0
[ 30.900900]
[ 30.900900] but task is already holding lock:
[ 30.900974] c3c0ac7c (&irq_desc_lock_class){-.-.}-{2:2}, at: __irq_get_desc_lock+0x58/0xa0
[ 30.901101]
[ 30.901101] other info that might help us debug this:
[ 30.901188] Possible unsafe locking scenario:
[ 30.901188]
[ 30.901262] CPU0
[ 30.901301] ----
[ 30.901339] lock(&irq_desc_lock_class);
[ 30.901411] lock(&irq_desc_lock_class);
[ 30.901480]
[ 30.901480] *** DEADLOCK ***
[ 30.901480]
[ 30.901554] May be due to missing lock nesting notation
[ 30.901554]
[ 30.901657] 4 locks held by init/307:
[ 30.901724] #0: c1f29f18 (system_transition_mutex){+.+.}-{3:3}, at: __do_sys_reboot+0x90/0x23c
[ 30.901889] #1: c20f7760 (&dev->mutex){....}-{3:3}, at: device_shutdown+0xf4/0x224
[ 30.902016] #2: c2e804d8 (&dev->mutex){....}-{3:3}, at: device_shutdown+0x104/0x224
[ 30.902138] #3: c3c0ac7c (&irq_desc_lock_class){-.-.}-{2:2}, at: __irq_get_desc_lock+0x58/0xa0
[ 30.902281]
[ 30.902281] stack backtrace:
[ 30.902462] CPU: 0 PID: 307 Comm: init Not tainted 5.17.0-rc3-00394-gc849047c2473 #1
[ 30.902572] Hardware name: Allwinner sun8i Family
[ 30.902781] unwind_backtrace from show_stack+0x10/0x14
[ 30.902895] show_stack from dump_stack_lvl+0x68/0x90
[ 30.902970] dump_stack_lvl from __lock_acquire+0x1680/0x31a0
[ 30.903047] __lock_acquire from lock_acquire+0x148/0x3dc
[ 30.903118] lock_acquire from _raw_spin_lock_irqsave+0x50/0x6c
[ 30.903197] _raw_spin_lock_irqsave from __irq_get_desc_lock+0x58/0xa0
[ 30.903282] __irq_get_desc_lock from irq_set_irq_wake+0x2c/0x19c
[ 30.903366] irq_set_irq_wake from irq_set_irq_wake+0x13c/0x19c
[ 30.903442] irq_set_irq_wake from gpio_keys_suspend+0x80/0x1a4
[ 30.903523] gpio_keys_suspend from gpio_keys_shutdown+0x10/0x2c
[ 30.903603] gpio_keys_shutdown from device_shutdown+0x180/0x224
[ 30.903685] device_shutdown from __do_sys_reboot+0x134/0x23c
[ 30.903764] __do_sys_reboot from ret_fast_syscall+0x0/0x1c
[ 30.903894] Exception stack(0xc584ffa8 to 0xc584fff0)
[ 30.904013] ffa0: 01234567 000c623f fee1dead 28121969 01234567 00000000
[ 30.904117] ffc0: 01234567 000c623f 00000001 00000058 000d85c0 00000000 00000000 00000000
[ 30.904213] ffe0: 000d8298 be84ddf4 000918bc b6eb0edc
[ 30.905189] reboot: Restarting system
The warning is no longer seen after reverting this patch.
The problem exists but is not seen in v5.17-rc4 because a bug in commit
8df89a7cbc63 ("pinctrl-sunxi: don't call pinctrl_gpio_direction()")
hides it. That problem is fixed with commit 3c5412cdec9f ("pinctrl-sunxi:
sunxi_pinctrl_gpio_direction_in/output: use correct offset") in linux-next,
and the traceback is seen there.
Guenter
next prev parent reply other threads:[~2022-02-15 0:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 16:55 [PATCH v2] ARM: dts: sun8i: Adjust power key nodes Jernej Skrabec
2021-11-29 17:16 ` Chen-Yu Tsai
2021-11-29 17:29 ` Jernej Škrabec
2021-11-29 17:35 ` Chen-Yu Tsai
2021-12-01 8:21 ` (subset) " Maxime Ripard
2022-02-15 0:27 ` Guenter Roeck [this message]
2022-02-15 20:34 ` Jernej Škrabec
2022-02-15 22:20 ` Guenter Roeck
2022-02-16 4:11 ` Samuel Holland
2022-02-16 4:26 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220215002732.GA3215504@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=michael@fossekall.de \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).