From: Guenter Roeck <linux@roeck-us.net>
To: Samuel Holland <samuel@sholland.org>
Cc: "Jernej Škrabec" <jernej.skrabec@gmail.com>,
mripard@kernel.org, wens@csie.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
"Michael Klein" <michael@fossekall.de>,
"Hans Verkuil" <hverkuil-cisco@xs4all.nl>
Subject: Re: [PATCH v2] ARM: dts: sun8i: Adjust power key nodes
Date: Tue, 15 Feb 2022 20:26:14 -0800 [thread overview]
Message-ID: <20220216042614.GA63304@roeck-us.net> (raw)
In-Reply-To: <35ca9258-3129-240c-7a0a-cacfa0a13253@sholland.org>
On Tue, Feb 15, 2022 at 10:11:36PM -0600, Samuel Holland wrote:
[ ... ]
>
> I don't think there is any real issue here. The two irq_desc's being locked are
> always different, so there is no deadlock. This recursive irq_set_irq_wake seems
> to be a reasonably common pattern in GPIO drivers, and several of them contain
> code to silence lockdep. I've sent a patch adding a copy of that to the sunxi
> driver:
>
> https://lore.kernel.org/lkml/20220216040037.22730-1-samuel@sholland.org/
>
> Please see if it works for you.
>
Yes, it does. The warning is gone with your patch applied on top of linux-next.
Thanks,
Guenter
prev parent reply other threads:[~2022-02-16 4:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 16:55 [PATCH v2] ARM: dts: sun8i: Adjust power key nodes Jernej Skrabec
2021-11-29 17:16 ` Chen-Yu Tsai
2021-11-29 17:29 ` Jernej Škrabec
2021-11-29 17:35 ` Chen-Yu Tsai
2021-12-01 8:21 ` (subset) " Maxime Ripard
2022-02-15 0:27 ` Guenter Roeck
2022-02-15 20:34 ` Jernej Škrabec
2022-02-15 22:20 ` Guenter Roeck
2022-02-16 4:11 ` Samuel Holland
2022-02-16 4:26 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220216042614.GA63304@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=michael@fossekall.de \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).