* [PATCH 2/2] arm64: dts: ti: k3-*: Drop address and size cells from flash nodes
2022-02-17 18:10 [PATCH 1/2] arm64: dts: ti: k3-*: Fix whitespace around flash@0 nodes Pratyush Yadav
@ 2022-02-17 18:10 ` Pratyush Yadav
2022-02-22 15:04 ` Apurva Nandan
2022-02-22 15:03 ` [PATCH 1/2] arm64: dts: ti: k3-*: Fix whitespace around flash@0 nodes Apurva Nandan
2022-02-22 19:32 ` Nishanth Menon
2 siblings, 1 reply; 5+ messages in thread
From: Pratyush Yadav @ 2022-02-17 18:10 UTC (permalink / raw)
To: Nishanth Menon
Cc: Pratyush Yadav, Vignesh Raghavendra, Tero Kristo, Rob Herring,
Krzysztof Kozlowski, linux-arm-kernel, devicetree, linux-kernel
Specifying partitions directly under the flash nodes is deprecated. A
partitions node should used instead. The address and size cells are not
needed. Remove them.
Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
---
Only compile-tested.
arch/arm64/boot/dts/ti/k3-am642-evm.dts | 2 --
arch/arm64/boot/dts/ti/k3-am642-sk.dts | 2 --
arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi | 2 --
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts | 2 --
arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 2 --
arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi | 2 --
6 files changed, 12 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
index edf80e277267..8e7893e58b03 100644
--- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
@@ -509,8 +509,6 @@ flash@0 {
cdns,tchsh-ns = <60>;
cdns,tslch-ns = <60>;
cdns,read-delay = <4>;
- #address-cells = <1>;
- #size-cells = <1>;
};
};
diff --git a/arch/arm64/boot/dts/ti/k3-am642-sk.dts b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
index 30b956276060..1d7db8bf3a5c 100644
--- a/arch/arm64/boot/dts/ti/k3-am642-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
@@ -380,8 +380,6 @@ flash@0 {
cdns,tchsh-ns = <60>;
cdns,tslch-ns = <60>;
cdns,read-delay = <4>;
- #address-cells = <1>;
- #size-cells = <1>;
};
};
diff --git a/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi
index 7d819f0db8df..2d615c3e9fa1 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi
@@ -267,7 +267,5 @@ flash@0 {
cdns,tchsh-ns = <60>;
cdns,tslch-ns = <60>;
cdns,read-delay = <4>;
- #address-cells = <1>;
- #size-cells = <1>;
};
};
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
index 2ecc4541f6d8..f5ca8e26ed99 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
@@ -493,8 +493,6 @@ flash@0 {
cdns,tchsh-ns = <60>;
cdns,tslch-ns = <60>;
cdns,read-delay = <2>;
- #address-cells = <1>;
- #size-cells = <1>;
};
};
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
index b726310d867c..f25d85169e0d 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
@@ -475,8 +475,6 @@ flash@0 {
cdns,tchsh-ns = <60>;
cdns,tslch-ns = <60>;
cdns,read-delay = <4>;
- #address-cells = <1>;
- #size-cells = <1>;
};
};
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi
index 990dfcd61018..e36335232cf8 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi
@@ -182,8 +182,6 @@ flash@0 {
cdns,tchsh-ns = <60>;
cdns,tslch-ns = <60>;
cdns,read-delay = <0>;
- #address-cells = <1>;
- #size-cells = <1>;
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] arm64: dts: ti: k3-*: Drop address and size cells from flash nodes
2022-02-17 18:10 ` [PATCH 2/2] arm64: dts: ti: k3-*: Drop address and size cells from flash nodes Pratyush Yadav
@ 2022-02-22 15:04 ` Apurva Nandan
0 siblings, 0 replies; 5+ messages in thread
From: Apurva Nandan @ 2022-02-22 15:04 UTC (permalink / raw)
To: Pratyush Yadav, Nishanth Menon
Cc: Vignesh Raghavendra, Tero Kristo, Rob Herring,
Krzysztof Kozlowski, linux-arm-kernel, devicetree, linux-kernel
On 17/02/22 23:40, Pratyush Yadav wrote:
> Specifying partitions directly under the flash nodes is deprecated. A
> partitions node should used instead. The address and size cells are not
> needed. Remove them.
>
> Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
Reviewed-by: Apurva Nandan<a-nandan@ti.com>
> ---
>
> Only compile-tested.
>
> arch/arm64/boot/dts/ti/k3-am642-evm.dts | 2 --
> arch/arm64/boot/dts/ti/k3-am642-sk.dts | 2 --
> arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi | 2 --
> arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts | 2 --
> arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 2 --
> arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi | 2 --
> 6 files changed, 12 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> index edf80e277267..8e7893e58b03 100644
> --- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> @@ -509,8 +509,6 @@ flash@0 {
> cdns,tchsh-ns = <60>;
> cdns,tslch-ns = <60>;
> cdns,read-delay = <4>;
> - #address-cells = <1>;
> - #size-cells = <1>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am642-sk.dts b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> index 30b956276060..1d7db8bf3a5c 100644
> --- a/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> @@ -380,8 +380,6 @@ flash@0 {
> cdns,tchsh-ns = <60>;
> cdns,tslch-ns = <60>;
> cdns,read-delay = <4>;
> - #address-cells = <1>;
> - #size-cells = <1>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi
> index 7d819f0db8df..2d615c3e9fa1 100644
> --- a/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi
> @@ -267,7 +267,5 @@ flash@0 {
> cdns,tchsh-ns = <60>;
> cdns,tslch-ns = <60>;
> cdns,read-delay = <4>;
> - #address-cells = <1>;
> - #size-cells = <1>;
> };
> };
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> index 2ecc4541f6d8..f5ca8e26ed99 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> @@ -493,8 +493,6 @@ flash@0 {
> cdns,tchsh-ns = <60>;
> cdns,tslch-ns = <60>;
> cdns,read-delay = <2>;
> - #address-cells = <1>;
> - #size-cells = <1>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> index b726310d867c..f25d85169e0d 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> @@ -475,8 +475,6 @@ flash@0 {
> cdns,tchsh-ns = <60>;
> cdns,tslch-ns = <60>;
> cdns,read-delay = <4>;
> - #address-cells = <1>;
> - #size-cells = <1>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi
> index 990dfcd61018..e36335232cf8 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi
> @@ -182,8 +182,6 @@ flash@0 {
> cdns,tchsh-ns = <60>;
> cdns,tslch-ns = <60>;
> cdns,read-delay = <0>;
> - #address-cells = <1>;
> - #size-cells = <1>;
> };
> };
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] arm64: dts: ti: k3-*: Fix whitespace around flash@0 nodes
2022-02-17 18:10 [PATCH 1/2] arm64: dts: ti: k3-*: Fix whitespace around flash@0 nodes Pratyush Yadav
2022-02-17 18:10 ` [PATCH 2/2] arm64: dts: ti: k3-*: Drop address and size cells from flash nodes Pratyush Yadav
@ 2022-02-22 15:03 ` Apurva Nandan
2022-02-22 19:32 ` Nishanth Menon
2 siblings, 0 replies; 5+ messages in thread
From: Apurva Nandan @ 2022-02-22 15:03 UTC (permalink / raw)
To: Pratyush Yadav, Nishanth Menon
Cc: Vignesh Raghavendra, Tero Kristo, Rob Herring,
Krzysztof Kozlowski, linux-arm-kernel, devicetree, linux-kernel
On 17/02/22 23:40, Pratyush Yadav wrote:
> The OSPI flash nodes are missing a space before the opening brace. Fix
> that.
>
> Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
Reviewed-by: Apurva Nandan<a-nandan@ti.com>
> ---
>
> Only compile-tested.
>
> arch/arm64/boot/dts/ti/k3-am642-evm.dts | 2 +-
> arch/arm64/boot/dts/ti/k3-am642-sk.dts | 2 +-
> arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi | 2 +-
> arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts | 2 +-
> arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> index e94ae178b1ae..edf80e277267 100644
> --- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> @@ -498,7 +498,7 @@ &ospi0 {
> pinctrl-names = "default";
> pinctrl-0 = <&ospi0_pins_default>;
>
> - flash@0{
> + flash@0 {
> compatible = "jedec,spi-nor";
> reg = <0x0>;
> spi-tx-bus-width = <8>;
> diff --git a/arch/arm64/boot/dts/ti/k3-am642-sk.dts b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> index a9785bec12df..30b956276060 100644
> --- a/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> @@ -369,7 +369,7 @@ &ospi0 {
> pinctrl-names = "default";
> pinctrl-0 = <&ospi0_pins_default>;
>
> - flash@0{
> + flash@0 {
> compatible = "jedec,spi-nor";
> reg = <0x0>;
> spi-tx-bus-width = <8>;
> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi
> index 34724440171a..7d819f0db8df 100644
> --- a/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi
> @@ -256,7 +256,7 @@ &ospi0 {
> pinctrl-names = "default";
> pinctrl-0 = <&mcu_fss0_ospi0_pins_default>;
>
> - flash@0{
> + flash@0 {
> compatible = "jedec,spi-nor";
> reg = <0x0>;
> spi-tx-bus-width = <8>;
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> index 2d7596911b27..2ecc4541f6d8 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> @@ -482,7 +482,7 @@ &ospi1 {
> pinctrl-names = "default";
> pinctrl-0 = <&mcu_fss0_ospi1_pins_default>;
>
> - flash@0{
> + flash@0 {
> compatible = "jedec,spi-nor";
> reg = <0x0>;
> spi-tx-bus-width = <1>;
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi
> index 2fee2906183d..990dfcd61018 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi
> @@ -171,7 +171,7 @@ &ospi0 {
> pinctrl-names = "default";
> pinctrl-0 = <&mcu_fss0_ospi0_pins_default>;
>
> - flash@0{
> + flash@0 {
> compatible = "jedec,spi-nor";
> reg = <0x0>;
> spi-tx-bus-width = <8>;
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] arm64: dts: ti: k3-*: Fix whitespace around flash@0 nodes
2022-02-17 18:10 [PATCH 1/2] arm64: dts: ti: k3-*: Fix whitespace around flash@0 nodes Pratyush Yadav
2022-02-17 18:10 ` [PATCH 2/2] arm64: dts: ti: k3-*: Drop address and size cells from flash nodes Pratyush Yadav
2022-02-22 15:03 ` [PATCH 1/2] arm64: dts: ti: k3-*: Fix whitespace around flash@0 nodes Apurva Nandan
@ 2022-02-22 19:32 ` Nishanth Menon
2 siblings, 0 replies; 5+ messages in thread
From: Nishanth Menon @ 2022-02-22 19:32 UTC (permalink / raw)
To: Pratyush Yadav
Cc: Nishanth Menon, linux-kernel, Vignesh Raghavendra,
Krzysztof Kozlowski, linux-arm-kernel, Tero Kristo, Rob Herring,
devicetree
Hi Pratyush Yadav,
On Thu, 17 Feb 2022 23:40:24 +0530, Pratyush Yadav wrote:
> The OSPI flash nodes are missing a space before the opening brace. Fix
> that.
>
>
I have applied the following to branch ti-k3-dts-next on [1].
Thank you!
[1/2] arm64: dts: ti: k3-*: Fix whitespace around flash@0 nodes
commit: 672e89d731c46b1f4118a070366dc117afed0f7c
[2/2] arm64: dts: ti: k3-*: Drop address and size cells from flash nodes
commit: cd9342109a7a901a115227978b86a3db6ee3d7a9
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
[1] git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 5+ messages in thread