* [PATCH] crypto: ccree: don't attempt 0 len DMA mappings
@ 2022-02-17 19:27 Gilad Ben-Yossef
2022-02-20 19:24 ` Corentin Labbe
2022-02-23 3:32 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Gilad Ben-Yossef @ 2022-02-17 19:27 UTC (permalink / raw)
To: Gilad Ben-Yossef, Herbert Xu, David S. Miller
Cc: Ofir Drang, Corentin Labbe, linux-crypto, linux-kernel
Refuse to try mapping zero bytes as this may cause a fault
on some configurations / platforms and it seems the prev.
attempt is not enough and we need to be more explicit.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Reported-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Fixes: ce0fc6db38de ("crypto: ccree - protect against empty or NULL
scatterlists")
---
drivers/crypto/ccree/cc_buffer_mgr.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/crypto/ccree/cc_buffer_mgr.c b/drivers/crypto/ccree/cc_buffer_mgr.c
index a5e041d9d2cf..11e0278c8631 100644
--- a/drivers/crypto/ccree/cc_buffer_mgr.c
+++ b/drivers/crypto/ccree/cc_buffer_mgr.c
@@ -258,6 +258,13 @@ static int cc_map_sg(struct device *dev, struct scatterlist *sg,
{
int ret = 0;
+ if (!nbytes) {
+ *mapped_nents = 0;
+ *lbytes = 0;
+ *nents = 0;
+ return 0;
+ }
+
*nents = cc_get_sgl_nents(dev, sg, nbytes, lbytes);
if (*nents > max_sg_nents) {
*nents = 0;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: ccree: don't attempt 0 len DMA mappings
2022-02-17 19:27 [PATCH] crypto: ccree: don't attempt 0 len DMA mappings Gilad Ben-Yossef
@ 2022-02-20 19:24 ` Corentin Labbe
2022-02-23 3:32 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Corentin Labbe @ 2022-02-20 19:24 UTC (permalink / raw)
To: Gilad Ben-Yossef
Cc: Herbert Xu, David S. Miller, Ofir Drang, linux-crypto, linux-kernel
Le Thu, Feb 17, 2022 at 09:27:26PM +0200, Gilad Ben-Yossef a écrit :
> Refuse to try mapping zero bytes as this may cause a fault
> on some configurations / platforms and it seems the prev.
> attempt is not enough and we need to be more explicit.
>
> Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
> Reported-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> Fixes: ce0fc6db38de ("crypto: ccree - protect against empty or NULL
> scatterlists")
> ---
> drivers/crypto/ccree/cc_buffer_mgr.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/crypto/ccree/cc_buffer_mgr.c b/drivers/crypto/ccree/cc_buffer_mgr.c
> index a5e041d9d2cf..11e0278c8631 100644
> --- a/drivers/crypto/ccree/cc_buffer_mgr.c
> +++ b/drivers/crypto/ccree/cc_buffer_mgr.c
> @@ -258,6 +258,13 @@ static int cc_map_sg(struct device *dev, struct scatterlist *sg,
> {
> int ret = 0;
>
> + if (!nbytes) {
> + *mapped_nents = 0;
> + *lbytes = 0;
> + *nents = 0;
> + return 0;
> + }
> +
> *nents = cc_get_sgl_nents(dev, sg, nbytes, lbytes);
> if (*nents > max_sg_nents) {
> *nents = 0;
> --
> 2.25.1
>
Hello
With this patch, the stacktrace I reported is not present anymore.
Tested-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Tested-on: r8a7795-salvator-x
Regards
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: ccree: don't attempt 0 len DMA mappings
2022-02-17 19:27 [PATCH] crypto: ccree: don't attempt 0 len DMA mappings Gilad Ben-Yossef
2022-02-20 19:24 ` Corentin Labbe
@ 2022-02-23 3:32 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2022-02-23 3:32 UTC (permalink / raw)
To: Gilad Ben-Yossef
Cc: David S. Miller, Ofir Drang, Corentin Labbe, linux-crypto, linux-kernel
On Thu, Feb 17, 2022 at 09:27:26PM +0200, Gilad Ben-Yossef wrote:
> Refuse to try mapping zero bytes as this may cause a fault
> on some configurations / platforms and it seems the prev.
> attempt is not enough and we need to be more explicit.
>
> Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
> Reported-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> Fixes: ce0fc6db38de ("crypto: ccree - protect against empty or NULL
> scatterlists")
> ---
> drivers/crypto/ccree/cc_buffer_mgr.c | 7 +++++++
> 1 file changed, 7 insertions(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-23 3:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-17 19:27 [PATCH] crypto: ccree: don't attempt 0 len DMA mappings Gilad Ben-Yossef
2022-02-20 19:24 ` Corentin Labbe
2022-02-23 3:32 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).