From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Christophe Kerello <christophe.kerello@foss.st.com>
Cc: <richard@nod.at>, <vigneshr@ti.com>, <robh+dt@kernel.org>,
<srinivas.kandagatla@linaro.org>, <p.yadav@ti.com>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<devicetree@vger.kernel.org>, <chenshumin86@sina.com>,
<stable@vger.kernel.org>
Subject: Re: [PATCH v3 4/4] mtd: core: Fix a conflict between MTD and NVMEM on wp-gpios property
Date: Fri, 18 Feb 2022 14:22:41 +0100 [thread overview]
Message-ID: <20220218142241.7a86aebb@xps13> (raw)
In-Reply-To: <20220217144755.270679-5-christophe.kerello@foss.st.com>
Hi Srinivas,
christophe.kerello@foss.st.com wrote on Thu, 17 Feb 2022 15:47:55 +0100:
> Wp-gpios property can be used on NVMEM nodes and the same property can
> be also used on MTD NAND nodes. In case of the wp-gpios property is
> defined at NAND level node, the GPIO management is done at NAND driver
> level. Write protect is disabled when the driver is probed or resumed
> and is enabled when the driver is released or suspended.
>
> When no partitions are defined in the NAND DT node, then the NAND DT node
> will be passed to NVMEM framework. If wp-gpios property is defined in
> this node, the GPIO resource is taken twice and the NAND controller
> driver fails to probe.
>
> A new Boolean flag named ignore_wp has been added in nvmem_config.
> In case ignore_wp is set, it means that the GPIO is handled by the
> provider. Lets set this flag in MTD layer to avoid the conflict on
> wp_gpios property.
>
> Fixes: 2a127da461a9 ("nvmem: add support for the write-protect pin")
> Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com>
> Cc: stable@vger.kernel.org
You can take patches 3 and 4 through the nvmem tree.
Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
next prev parent reply other threads:[~2022-02-18 13:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 14:47 [PATCH v3 0/4] mtd: rawnand: stm32_fmc2: Add NAND Write Protect support Christophe Kerello
2022-02-17 14:47 ` [PATCH v3 1/4] dt-binding: mtd: nand: Document the wp-gpios property Christophe Kerello
2022-02-18 14:33 ` Miquel Raynal
2022-02-17 14:47 ` [PATCH v3 2/4] mtd: rawnand: stm32_fmc2: Add NAND Write Protect support Christophe Kerello
2022-02-18 14:33 ` Miquel Raynal
2022-02-17 14:47 ` [PATCH v3 3/4] nvmem: core: Fix a conflict between MTD and NVMEM on wp-gpios property Christophe Kerello
2022-02-18 13:24 ` Srinivas Kandagatla
2022-02-17 14:47 ` [PATCH v3 4/4] mtd: " Christophe Kerello
2022-02-18 9:46 ` Srinivas Kandagatla
2022-02-18 13:22 ` Miquel Raynal [this message]
2022-02-18 13:25 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220218142241.7a86aebb@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=chenshumin86@sina.com \
--cc=christophe.kerello@foss.st.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=stable@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).