From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Christophe Kerello <christophe.kerello@foss.st.com>,
miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
robh+dt@kernel.org, p.yadav@ti.com
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
devicetree@vger.kernel.org, chenshumin86@sina.com,
stable@vger.kernel.org
Subject: Re: [PATCH v3 3/4] nvmem: core: Fix a conflict between MTD and NVMEM on wp-gpios property
Date: Fri, 18 Feb 2022 13:24:45 +0000 [thread overview]
Message-ID: <6f3ff8f3-82fb-1bb1-d854-bb48f1ea9b1d@linaro.org> (raw)
In-Reply-To: <20220217144755.270679-4-christophe.kerello@foss.st.com>
On 17/02/2022 14:47, Christophe Kerello wrote:
> Wp-gpios property can be used on NVMEM nodes and the same property can
> be also used on MTD NAND nodes. In case of the wp-gpios property is
> defined at NAND level node, the GPIO management is done at NAND driver
> level. Write protect is disabled when the driver is probed or resumed
> and is enabled when the driver is released or suspended.
>
> When no partitions are defined in the NAND DT node, then the NAND DT node
> will be passed to NVMEM framework. If wp-gpios property is defined in
> this node, the GPIO resource is taken twice and the NAND controller
> driver fails to probe.
>
> It would be possible to set config->wp_gpio at MTD level before calling
> nvmem_register function but NVMEM framework will toggle this GPIO on
> each write when this GPIO should only be controlled at NAND level driver
> to ensure that the Write Protect has not been enabled.
>
> A way to fix this conflict is to add a new boolean flag in nvmem_config
> named ignore_wp. In case ignore_wp is set, the GPIO resource will
> be managed by the provider.
>
> Fixes: 2a127da461a9 ("nvmem: add support for the write-protect pin")
> Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com>
> Cc: stable@vger.kernel.org
> ---
> Changes in v3:
> - add a fixes tag.
> - rename skip_wp_gpio by ignore_wp in nvmen_config.
Applied thanks,
--srini
>
> Changes in v2:
> - rework the proposal done to fix a conflict between MTD and NVMEM on
> wp-gpios property.
>
> drivers/nvmem/core.c | 2 +-
> include/linux/nvmem-provider.h | 4 +++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> index 23a38dcf0fc4..9fd1602b539d 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c
> @@ -771,7 +771,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)
>
> if (config->wp_gpio)
> nvmem->wp_gpio = config->wp_gpio;
> - else
> + else if (!config->ignore_wp)
> nvmem->wp_gpio = gpiod_get_optional(config->dev, "wp",
> GPIOD_OUT_HIGH);
> if (IS_ERR(nvmem->wp_gpio)) {
> diff --git a/include/linux/nvmem-provider.h b/include/linux/nvmem-provider.h
> index 98efb7b5660d..c9a3ac9efeaa 100644
> --- a/include/linux/nvmem-provider.h
> +++ b/include/linux/nvmem-provider.h
> @@ -70,7 +70,8 @@ struct nvmem_keepout {
> * @word_size: Minimum read/write access granularity.
> * @stride: Minimum read/write access stride.
> * @priv: User context passed to read/write callbacks.
> - * @wp-gpio: Write protect pin
> + * @wp-gpio: Write protect pin
> + * @ignore_wp: Write Protect pin is managed by the provider.
> *
> * Note: A default "nvmem<id>" name will be assigned to the device if
> * no name is specified in its configuration. In such case "<id>" is
> @@ -92,6 +93,7 @@ struct nvmem_config {
> enum nvmem_type type;
> bool read_only;
> bool root_only;
> + bool ignore_wp;
> struct device_node *of_node;
> bool no_of_node;
> nvmem_reg_read_t reg_read;
next prev parent reply other threads:[~2022-02-18 13:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 14:47 [PATCH v3 0/4] mtd: rawnand: stm32_fmc2: Add NAND Write Protect support Christophe Kerello
2022-02-17 14:47 ` [PATCH v3 1/4] dt-binding: mtd: nand: Document the wp-gpios property Christophe Kerello
2022-02-18 14:33 ` Miquel Raynal
2022-02-17 14:47 ` [PATCH v3 2/4] mtd: rawnand: stm32_fmc2: Add NAND Write Protect support Christophe Kerello
2022-02-18 14:33 ` Miquel Raynal
2022-02-17 14:47 ` [PATCH v3 3/4] nvmem: core: Fix a conflict between MTD and NVMEM on wp-gpios property Christophe Kerello
2022-02-18 13:24 ` Srinivas Kandagatla [this message]
2022-02-17 14:47 ` [PATCH v3 4/4] mtd: " Christophe Kerello
2022-02-18 9:46 ` Srinivas Kandagatla
2022-02-18 13:22 ` Miquel Raynal
2022-02-18 13:25 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f3ff8f3-82fb-1bb1-d854-bb48f1ea9b1d@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=chenshumin86@sina.com \
--cc=christophe.kerello@foss.st.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=stable@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).