* [PATCH v2 net] net: dsa: fix panic when removing unoffloaded port from bridge
@ 2022-02-21 20:35 Alvin Šipraga
2022-02-21 20:44 ` Vladimir Oltean
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Alvin Šipraga @ 2022-02-21 20:35 UTC (permalink / raw)
To: Andrew Lunn, Vivien Didelot, Florian Fainelli, Vladimir Oltean,
David S. Miller, Jakub Kicinski, Alvin Šipraga
Cc: Vladimir Oltean, netdev, linux-kernel
From: Alvin Šipraga <alsi@bang-olufsen.dk>
If a bridged port is not offloaded to the hardware - either because the
underlying driver does not implement the port_bridge_{join,leave} ops,
or because the operation failed - then its dp->bridge pointer will be
NULL when dsa_port_bridge_leave() is called. Avoid dereferncing NULL.
This fixes the following splat when removing a port from a bridge:
Unable to handle kernel access to user memory outside uaccess routines at virtual address 0000000000000000
Internal error: Oops: 96000004 [#1] PREEMPT_RT SMP
CPU: 3 PID: 1119 Comm: brctl Tainted: G O 5.17.0-rc4-rt4 #1
Call trace:
dsa_port_bridge_leave+0x8c/0x1e4
dsa_slave_changeupper+0x40/0x170
dsa_slave_netdevice_event+0x494/0x4d4
notifier_call_chain+0x80/0xe0
raw_notifier_call_chain+0x1c/0x24
call_netdevice_notifiers_info+0x5c/0xac
__netdev_upper_dev_unlink+0xa4/0x200
netdev_upper_dev_unlink+0x38/0x60
del_nbp+0x1b0/0x300
br_del_if+0x38/0x114
add_del_if+0x60/0xa0
br_ioctl_stub+0x128/0x2dc
br_ioctl_call+0x68/0xb0
dev_ifsioc+0x390/0x554
dev_ioctl+0x128/0x400
sock_do_ioctl+0xb4/0xf4
sock_ioctl+0x12c/0x4e0
__arm64_sys_ioctl+0xa8/0xf0
invoke_syscall+0x4c/0x110
el0_svc_common.constprop.0+0x48/0xf0
do_el0_svc+0x28/0x84
el0_svc+0x1c/0x50
el0t_64_sync_handler+0xa8/0xb0
el0t_64_sync+0x17c/0x180
Code: f9402f00 f0002261 f9401302 913cc021 (a9401404)
---[ end trace 0000000000000000 ]---
Fixes: d3eed0e57d5d ("net: dsa: keep the bridge_dev and bridge_num as part of the same structure")
Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk>
---
v1 -> v2:
- replace trailing comma with semicolon *facepalm*
---
net/dsa/port.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/net/dsa/port.c b/net/dsa/port.c
index eef4a98f2628..1a40c52f5a42 100644
--- a/net/dsa/port.c
+++ b/net/dsa/port.c
@@ -395,10 +395,17 @@ void dsa_port_bridge_leave(struct dsa_port *dp, struct net_device *br)
.tree_index = dp->ds->dst->index,
.sw_index = dp->ds->index,
.port = dp->index,
- .bridge = *dp->bridge,
};
int err;
+ /* If the port could not be offloaded to begin with, then
+ * there is nothing to do.
+ */
+ if (!dp->bridge)
+ return;
+
+ info.bridge = *dp->bridge;
+
/* Here the port is already unbridged. Reflect the current configuration
* so that drivers can program their chips accordingly.
*/
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 net] net: dsa: fix panic when removing unoffloaded port from bridge
2022-02-21 20:35 [PATCH v2 net] net: dsa: fix panic when removing unoffloaded port from bridge Alvin Šipraga
@ 2022-02-21 20:44 ` Vladimir Oltean
2022-02-22 2:56 ` Florian Fainelli
2022-02-23 1:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Vladimir Oltean @ 2022-02-21 20:44 UTC (permalink / raw)
To: Alvin Šipraga
Cc: Andrew Lunn, Vivien Didelot, Florian Fainelli, David S. Miller,
Jakub Kicinski, Alvin Šipraga, Vladimir Oltean, netdev,
linux-kernel
On Mon, Feb 21, 2022 at 09:35:38PM +0100, Alvin Šipraga wrote:
> From: Alvin Šipraga <alsi@bang-olufsen.dk>
>
> If a bridged port is not offloaded to the hardware - either because the
> underlying driver does not implement the port_bridge_{join,leave} ops,
> or because the operation failed - then its dp->bridge pointer will be
> NULL when dsa_port_bridge_leave() is called. Avoid dereferncing NULL.
>
> This fixes the following splat when removing a port from a bridge:
>
> Unable to handle kernel access to user memory outside uaccess routines at virtual address 0000000000000000
> Internal error: Oops: 96000004 [#1] PREEMPT_RT SMP
> CPU: 3 PID: 1119 Comm: brctl Tainted: G O 5.17.0-rc4-rt4 #1
> Call trace:
> dsa_port_bridge_leave+0x8c/0x1e4
> dsa_slave_changeupper+0x40/0x170
> dsa_slave_netdevice_event+0x494/0x4d4
> notifier_call_chain+0x80/0xe0
> raw_notifier_call_chain+0x1c/0x24
> call_netdevice_notifiers_info+0x5c/0xac
> __netdev_upper_dev_unlink+0xa4/0x200
> netdev_upper_dev_unlink+0x38/0x60
> del_nbp+0x1b0/0x300
> br_del_if+0x38/0x114
> add_del_if+0x60/0xa0
> br_ioctl_stub+0x128/0x2dc
> br_ioctl_call+0x68/0xb0
> dev_ifsioc+0x390/0x554
> dev_ioctl+0x128/0x400
> sock_do_ioctl+0xb4/0xf4
> sock_ioctl+0x12c/0x4e0
> __arm64_sys_ioctl+0xa8/0xf0
> invoke_syscall+0x4c/0x110
> el0_svc_common.constprop.0+0x48/0xf0
> do_el0_svc+0x28/0x84
> el0_svc+0x1c/0x50
> el0t_64_sync_handler+0xa8/0xb0
> el0t_64_sync+0x17c/0x180
> Code: f9402f00 f0002261 f9401302 913cc021 (a9401404)
> ---[ end trace 0000000000000000 ]---
>
> Fixes: d3eed0e57d5d ("net: dsa: keep the bridge_dev and bridge_num as part of the same structure")
> Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk>
> ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 net] net: dsa: fix panic when removing unoffloaded port from bridge
2022-02-21 20:35 [PATCH v2 net] net: dsa: fix panic when removing unoffloaded port from bridge Alvin Šipraga
2022-02-21 20:44 ` Vladimir Oltean
@ 2022-02-22 2:56 ` Florian Fainelli
2022-02-23 1:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2022-02-22 2:56 UTC (permalink / raw)
To: Alvin Šipraga, Andrew Lunn, Vivien Didelot, Vladimir Oltean,
David S. Miller, Jakub Kicinski, Alvin Šipraga
Cc: Vladimir Oltean, netdev, linux-kernel
On 2/21/2022 12:35 PM, Alvin Šipraga wrote:
> From: Alvin Šipraga <alsi@bang-olufsen.dk>
>
> If a bridged port is not offloaded to the hardware - either because the
> underlying driver does not implement the port_bridge_{join,leave} ops,
> or because the operation failed - then its dp->bridge pointer will be
> NULL when dsa_port_bridge_leave() is called. Avoid dereferncing NULL.
>
> This fixes the following splat when removing a port from a bridge:
>
> Unable to handle kernel access to user memory outside uaccess routines at virtual address 0000000000000000
> Internal error: Oops: 96000004 [#1] PREEMPT_RT SMP
> CPU: 3 PID: 1119 Comm: brctl Tainted: G O 5.17.0-rc4-rt4 #1
> Call trace:
> dsa_port_bridge_leave+0x8c/0x1e4
> dsa_slave_changeupper+0x40/0x170
> dsa_slave_netdevice_event+0x494/0x4d4
> notifier_call_chain+0x80/0xe0
> raw_notifier_call_chain+0x1c/0x24
> call_netdevice_notifiers_info+0x5c/0xac
> __netdev_upper_dev_unlink+0xa4/0x200
> netdev_upper_dev_unlink+0x38/0x60
> del_nbp+0x1b0/0x300
> br_del_if+0x38/0x114
> add_del_if+0x60/0xa0
> br_ioctl_stub+0x128/0x2dc
> br_ioctl_call+0x68/0xb0
> dev_ifsioc+0x390/0x554
> dev_ioctl+0x128/0x400
> sock_do_ioctl+0xb4/0xf4
> sock_ioctl+0x12c/0x4e0
> __arm64_sys_ioctl+0xa8/0xf0
> invoke_syscall+0x4c/0x110
> el0_svc_common.constprop.0+0x48/0xf0
> do_el0_svc+0x28/0x84
> el0_svc+0x1c/0x50
> el0t_64_sync_handler+0xa8/0xb0
> el0t_64_sync+0x17c/0x180
> Code: f9402f00 f0002261 f9401302 913cc021 (a9401404)
> ---[ end trace 0000000000000000 ]---
>
> Fixes: d3eed0e57d5d ("net: dsa: keep the bridge_dev and bridge_num as part of the same structure")
> Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 net] net: dsa: fix panic when removing unoffloaded port from bridge
2022-02-21 20:35 [PATCH v2 net] net: dsa: fix panic when removing unoffloaded port from bridge Alvin Šipraga
2022-02-21 20:44 ` Vladimir Oltean
2022-02-22 2:56 ` Florian Fainelli
@ 2022-02-23 1:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-02-23 1:10 UTC (permalink / raw)
To: =?utf-8?b?QWx2aW4gxaBpcHJhZ2EgPGFsdmluQHBxcnMuZGs+?=
Cc: andrew, vivien.didelot, f.fainelli, olteanv, davem, kuba, alsi,
vladimir.oltean, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 21 Feb 2022 21:35:38 +0100 you wrote:
> From: Alvin Šipraga <alsi@bang-olufsen.dk>
>
> If a bridged port is not offloaded to the hardware - either because the
> underlying driver does not implement the port_bridge_{join,leave} ops,
> or because the operation failed - then its dp->bridge pointer will be
> NULL when dsa_port_bridge_leave() is called. Avoid dereferncing NULL.
>
> [...]
Here is the summary with links:
- [v2,net] net: dsa: fix panic when removing unoffloaded port from bridge
https://git.kernel.org/netdev/net/c/342b6419193c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-23 1:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-21 20:35 [PATCH v2 net] net: dsa: fix panic when removing unoffloaded port from bridge Alvin Šipraga
2022-02-21 20:44 ` Vladimir Oltean
2022-02-22 2:56 ` Florian Fainelli
2022-02-23 1:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).