From: <conor.dooley@microchip.com>
To: <u.kleine-koenig@pengutronix.de>, <krzysztof.kozlowski@canonical.com>
Cc: <a.zummo@towertech.it>, <alexandre.belloni@bootlin.com>,
<aou@eecs.berkeley.edu>, <atishp@rivosinc.com>, <brgl@bgdev.pl>,
<conor.dooley@microchip.com>, <daire.mcnamara@microchip.com>,
<devicetree@vger.kernel.org>, <geert@linux-m68k.org>,
<ivan.griffin@microchip.com>, <jassisinghbrar@gmail.com>,
<lee.jones@linaro.org>, <lewis.hanly@microchip.com>,
<linus.walleij@linaro.org>, <linux-gpio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-pwm@vger.kernel.org>,
<linux-riscv@lists.infradead.org>, <linux-rtc@vger.kernel.org>,
<palmer@dabbelt.com>, <palmer@rivosinc.com>,
<paul.walmsley@sifive.com>, <robh+dt@kernel.org>,
<robh@kernel.org>, <thierry.reding@gmail.com>
Subject: Re: [PATCH v7 05/11] dt-bindings: pwm: add microchip corepwm binding
Date: Wed, 23 Feb 2022 08:55:10 +0000 [thread overview]
Message-ID: <20220223085509.3664942-1-conor.dooley@microchip.com> (raw)
In-Reply-To: <20220223082018.degrftmxpk5uc6xn@pengutronix.de>
On 23/02/2022 08:20, Uwe Kleine-König wrote:
> On Wed, Feb 23, 2022 at 08:12:49AM +0100, Krzysztof Kozlowski wrote:
> > On 23/02/2022 07:20, Uwe Kleine-König wrote:
> > > On Mon, Feb 14, 2022 at 01:58:35PM +0000, conor.dooley@microchip.com wrote:
> > >> From: Conor Dooley <conor.dooley@microchip.com>
> > >>
> > >> Add device tree bindings for the Microchip fpga fabric based "core" PWM
> > >> controller.
> > >>
> > >> Reviewed-by: Rob Herring <robh@kernel.org>
> > >> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> > >> Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
> > >
> > > I like it:
> > >
> > > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > >
> > > nitpick: Put your S-o-b last in the commit log. (This doesn't justify a
> > > resend IMHO)
> >
> > It should be the opposite - the first. First author signs the patch,
> > then comes review and finally an ack. Putting SoB at then suggests that
> > tags were accumulated before sending patch, out of mailing list.
>
> well, or in an earlier revision of this patch as is the case here. One
> of the ideas of S-o-b is that the order shows the flow of the patch
> states and if this patch ends in git with:
>
> Referred-by: Rob Herring <robh@kernel.org>
> Singed-off-by: Conor Dooley <conor.dooley@microchip.com>
> Backed-by: Palmer Dabbelt <palmer@rivosinc.com>
> Singed-off-by: Peter Maintainer <pm@example.com>
>
> I'd expect that Backed-by was added by Peter, not Conor.
> (Modified the tags on purpose to not interfere with b4's tag pickup, I
> guess you humans still get the point.)
I had put the acks after the S-o-B for patches I hadn't changed since the ack,
but I think that may have been a misinterpretation of what was meant by Rob
when he said tags should be in chronological order. Won't do it this way in
the future.
If the remaining patch gets a maintainer ack, the order will be fine I guess
since it'll be Palmer taking it anyway. If there's a v8, I will fix the order.
Thanks,
Conor
next prev parent reply other threads:[~2022-02-23 8:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 13:58 [PATCH v7 00/11] Update the Icicle Kit device tree conor.dooley
2022-02-14 13:58 ` [PATCH v7 01/11] dt-bindings: soc/microchip: update syscontroller compatibles conor.dooley
2022-02-14 13:58 ` [PATCH v7 02/11] dt-bindings: soc/microchip: add info about services to mpfs sysctrl conor.dooley
2022-02-21 7:40 ` Conor.Dooley
2022-02-22 21:39 ` Rob Herring
2022-02-14 13:58 ` [PATCH v7 03/11] dt-bindings: rtc: add bindings for microchip mpfs rtc conor.dooley
2022-02-23 7:41 ` Conor.Dooley
2022-02-23 15:18 ` Alexandre Belloni
2022-02-23 15:25 ` Conor.Dooley
2022-02-23 20:20 ` Alexandre Belloni
2022-02-23 20:26 ` Conor Dooley
2022-02-14 13:58 ` [PATCH v7 04/11] dt-bindings: gpio: add bindings for microchip mpfs gpio conor.dooley
2022-02-14 13:58 ` [PATCH v7 05/11] dt-bindings: pwm: add microchip corepwm binding conor.dooley
2022-02-21 7:55 ` Conor.Dooley
2022-02-23 6:20 ` Uwe Kleine-König
2022-02-23 7:12 ` Krzysztof Kozlowski
2022-02-23 8:20 ` Uwe Kleine-König
2022-02-23 8:55 ` conor.dooley [this message]
2022-02-23 9:09 ` Lee Jones
2022-02-24 13:19 ` Thierry Reding
2022-02-14 13:58 ` [PATCH v7 06/11] riscv: dts: microchip: use clk defines for icicle kit conor.dooley
2022-02-14 13:58 ` [PATCH v7 07/11] riscv: dts: microchip: add fpga fabric section to " conor.dooley
2022-02-14 13:58 ` [PATCH v7 08/11] riscv: dts: microchip: refactor icicle kit device tree conor.dooley
2022-02-14 13:58 ` [PATCH v7 09/11] riscv: dts: microchip: update peripherals in " conor.dooley
2022-02-14 13:58 ` [PATCH v7 10/11] riscv: dts: microchip: add new peripherals to " conor.dooley
2022-02-14 13:58 ` [PATCH v7 11/11] MAINTAINERS: update riscv/microchip entry conor.dooley
2022-02-23 20:48 ` [PATCH v7 00/11] Update the Icicle Kit device tree Conor Dooley
2022-03-10 7:07 ` Palmer Dabbelt
2022-03-10 7:35 ` Conor.Dooley
2022-03-11 7:59 ` Zong Li
2022-03-11 19:56 ` Conor Dooley
2022-03-16 6:51 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220223085509.3664942-1-conor.dooley@microchip.com \
--to=conor.dooley@microchip.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=aou@eecs.berkeley.edu \
--cc=atishp@rivosinc.com \
--cc=brgl@bgdev.pl \
--cc=daire.mcnamara@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=ivan.griffin@microchip.com \
--cc=jassisinghbrar@gmail.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=lee.jones@linaro.org \
--cc=lewis.hanly@microchip.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).