* [PATCH] arm64: dts: rockchip: set vdd_gpu regulator on rk3568-evb1-v10 to always on
@ 2022-02-23 11:20 Michael Riesch
2022-02-23 23:44 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Michael Riesch @ 2022-02-23 11:20 UTC (permalink / raw)
To: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Cc: Rob Herring, Heiko Stuebner, Michael Riesch, Liang Chen
As discussed in [0], the Rockchip power domain driver does not consider
the external supplies (such as VDD_GPU on the RK3568 EVB1). In the scope of
this discussion it has been pointed out that turning this voltage on/off
on the fly is not explicitly supported. This patch follows the other RK356x
boards by example and sets the vdd_gpu regulator to always on.
[0] https://lore.kernel.org/linux-rockchip/20211217130919.3035788-1-s.hauer@pengutronix.de/
Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
---
arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
index f3d0bc259166..bb7177ff92ac 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
@@ -219,6 +219,7 @@ regulator-state-mem {
vdd_gpu: DCDC_REG2 {
regulator-name = "vdd_gpu";
+ regulator-always-on;
regulator-init-microvolt = <900000>;
regulator-initial-mode = <0x2>;
regulator-min-microvolt = <500000>;
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: set vdd_gpu regulator on rk3568-evb1-v10 to always on
2022-02-23 11:20 [PATCH] arm64: dts: rockchip: set vdd_gpu regulator on rk3568-evb1-v10 to always on Michael Riesch
@ 2022-02-23 23:44 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2022-02-23 23:44 UTC (permalink / raw)
To: linux-rockchip, Michael Riesch, devicetree, linux-arm-kernel,
linux-kernel
Cc: Heiko Stuebner, Rob Herring, Liang Chen
On Wed, 23 Feb 2022 12:20:08 +0100, Michael Riesch wrote:
> As discussed in [0], the Rockchip power domain driver does not consider
> the external supplies (such as VDD_GPU on the RK3568 EVB1). In the scope of
> this discussion it has been pointed out that turning this voltage on/off
> on the fly is not explicitly supported. This patch follows the other RK356x
> boards by example and sets the vdd_gpu regulator to always on.
>
> [0] https://lore.kernel.org/linux-rockchip/20211217130919.3035788-1-s.hauer@pengutronix.de/
Applied, thanks!
[1/1] arm64: dts: rockchip: set vdd_gpu regulator on rk3568-evb1-v10 to always on
commit: bbe5d394c76bd534a0819f78a900ac1a83f3ee9e
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-23 23:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-23 11:20 [PATCH] arm64: dts: rockchip: set vdd_gpu regulator on rk3568-evb1-v10 to always on Michael Riesch
2022-02-23 23:44 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).