linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/3] nvmem: patches (set 2) for 5.18
@ 2022-02-23 22:34 Srinivas Kandagatla
  2022-02-23 22:35 ` [PATCH 1/3] nvmem: qfprom: Increase fuse blow timeout to prevent write fail Srinivas Kandagatla
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Srinivas Kandagatla @ 2022-02-23 22:34 UTC (permalink / raw)
  To: gregkh; +Cc: linux-kernel, Srinivas Kandagatla

Hi Greg,

Here is final set of nvmem patches for 5.18 which includes

- Add new Sunplus nvmem provider and bindings.
- fix in qfprom to increase blow timeout.

Can you please queue them up for 5.18.

thanks for you help,
srini

Knox Chiou (1):
  nvmem: qfprom: Increase fuse blow timeout to prevent write fail

Vincent Shih (2):
  nvmem: Add driver for OCOTP in Sunplus SP7021
  dt-bindings: nvmem: Add bindings doc for Sunplus OCOTP driver

 .../bindings/nvmem/sunplus,sp7021-ocotp.yaml  |  86 +++++++
 MAINTAINERS                                   |   6 +
 drivers/nvmem/Kconfig                         |  12 +
 drivers/nvmem/Makefile                        |   2 +
 drivers/nvmem/qfprom.c                        |   2 +-
 drivers/nvmem/sunplus-ocotp.c                 | 228 ++++++++++++++++++
 6 files changed, 335 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/nvmem/sunplus,sp7021-ocotp.yaml
 create mode 100644 drivers/nvmem/sunplus-ocotp.c

-- 
2.21.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/3] nvmem: qfprom: Increase fuse blow timeout to prevent write fail
  2022-02-23 22:34 [PATCH 0/3] nvmem: patches (set 2) for 5.18 Srinivas Kandagatla
@ 2022-02-23 22:35 ` Srinivas Kandagatla
  2022-02-23 22:35 ` [PATCH 2/3] nvmem: Add driver for OCOTP in Sunplus SP7021 Srinivas Kandagatla
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 8+ messages in thread
From: Srinivas Kandagatla @ 2022-02-23 22:35 UTC (permalink / raw)
  To: gregkh; +Cc: linux-kernel, Knox Chiou, Douglas Anderson, Srinivas Kandagatla

From: Knox Chiou <knoxchiou@chromium.org>

sc7180 blow fuses got slightly chances to hit qfprom_reg_write timeout.
Current timeout is simply too low. Since blowing fuses is a
very rare operation, so the risk associated with overestimating this
number is low.
Increase fuse blow timeout from 1ms to 10ms.

Signed-off-by: Knox Chiou <knoxchiou@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 drivers/nvmem/qfprom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c
index 061293f9136b..162132c7dab9 100644
--- a/drivers/nvmem/qfprom.c
+++ b/drivers/nvmem/qfprom.c
@@ -22,7 +22,7 @@
 
 /* Amount of time required to hold charge to blow fuse in micro-seconds */
 #define QFPROM_FUSE_BLOW_POLL_US	100
-#define QFPROM_FUSE_BLOW_TIMEOUT_US	1000
+#define QFPROM_FUSE_BLOW_TIMEOUT_US	10000
 
 #define QFPROM_BLOW_STATUS_OFFSET	0x048
 #define QFPROM_BLOW_STATUS_BUSY		0x1
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/3] nvmem: Add driver for OCOTP in Sunplus SP7021
  2022-02-23 22:34 [PATCH 0/3] nvmem: patches (set 2) for 5.18 Srinivas Kandagatla
  2022-02-23 22:35 ` [PATCH 1/3] nvmem: qfprom: Increase fuse blow timeout to prevent write fail Srinivas Kandagatla
@ 2022-02-23 22:35 ` Srinivas Kandagatla
  2022-02-23 22:35 ` [PATCH 3/3] dt-bindings: nvmem: Add bindings doc for Sunplus OCOTP driver Srinivas Kandagatla
  2022-02-25 10:52 ` [PATCH 0/3] nvmem: patches (set 2) for 5.18 Srinivas Kandagatla
  3 siblings, 0 replies; 8+ messages in thread
From: Srinivas Kandagatla @ 2022-02-23 22:35 UTC (permalink / raw)
  To: gregkh; +Cc: linux-kernel, Vincent Shih, Srinivas Kandagatla

From: Vincent Shih <vincent.sunplus@gmail.com>

Add driver for OCOTP in Sunplus SP7021

Signed-off-by: Vincent Shih <vincent.sunplus@gmail.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 MAINTAINERS                   |   5 +
 drivers/nvmem/Kconfig         |  12 ++
 drivers/nvmem/Makefile        |   2 +
 drivers/nvmem/sunplus-ocotp.c | 228 ++++++++++++++++++++++++++++++++++
 4 files changed, 247 insertions(+)
 create mode 100644 drivers/nvmem/sunplus-ocotp.c

diff --git a/MAINTAINERS b/MAINTAINERS
index ea3e6c914384..534772dfc3ef 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18491,6 +18491,11 @@ S:	Maintained
 F:	Documentation/devicetree/bindings/rtc/sunplus,sp7021-rtc.yaml
 F:	drivers/rtc/rtc-sunplus.c
 
+SUNPLUS OCOTP DRIVER
+M:	Vincent Shih <vincent.sunplus@gmail.com>
+S:	Maintained
+F:	drivers/nvmem/sunplus-ocotp.c
+
 SUPERH
 M:	Yoshinori Sato <ysato@users.sourceforge.jp>
 M:	Rich Felker <dalias@libc.org>
diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
index 4063ea15f7d2..555aa77a574d 100644
--- a/drivers/nvmem/Kconfig
+++ b/drivers/nvmem/Kconfig
@@ -312,4 +312,16 @@ config NVMEM_LAYERSCAPE_SFP
 	  This driver can also be built as a module. If so, the module
 	  will be called layerscape-sfp.
 
+config NVMEM_SUNPLUS_OCOTP
+	tristate "Sunplus SoC OTP support"
+	depends on SOC_SP7021 || COMPILE_TEST
+	depends on HAS_IOMEM
+	help
+	  This is a driver for the On-chip OTP controller (OCOTP) available
+	  on Sunplus SoCs. It provides access to 128 bytes of one-time
+	  programmable eFuse.
+
+	  This driver can also be built as a module. If so, the module
+	  will be called nvmem-sunplus-ocotp.
+
 endif
diff --git a/drivers/nvmem/Makefile b/drivers/nvmem/Makefile
index d4e1052d2b95..891958e29d25 100644
--- a/drivers/nvmem/Makefile
+++ b/drivers/nvmem/Makefile
@@ -63,3 +63,5 @@ obj-$(CONFIG_NVMEM_BRCM_NVRAM)	+= nvmem_brcm_nvram.o
 nvmem_brcm_nvram-y		:= brcm_nvram.o
 obj-$(CONFIG_NVMEM_LAYERSCAPE_SFP)	+= nvmem-layerscape-sfp.o
 nvmem-layerscape-sfp-y		:= layerscape-sfp.o
+obj-$(CONFIG_NVMEM_SUNPLUS_OCOTP)	+= nvmem_sunplus_ocotp.o
+nvmem_sunplus_ocotp-y		:= sunplus-ocotp.o
diff --git a/drivers/nvmem/sunplus-ocotp.c b/drivers/nvmem/sunplus-ocotp.c
new file mode 100644
index 000000000000..2dc59c22eb55
--- /dev/null
+++ b/drivers/nvmem/sunplus-ocotp.c
@@ -0,0 +1,228 @@
+// SPDX-License-Identifier: GPL-2.0
+
+/*
+ * The OCOTP driver for Sunplus	SP7021
+ *
+ * Copyright (C) 2019 Sunplus Technology Inc., All rights reserved.
+ */
+
+#include <linux/bitfield.h>
+#include <linux/clk.h>
+#include <linux/delay.h>
+#include <linux/device.h>
+#include <linux/io.h>
+#include <linux/iopoll.h>
+#include <linux/module.h>
+#include <linux/nvmem-provider.h>
+#include <linux/of_device.h>
+#include <linux/platform_device.h>
+
+/*
+ * OTP memory
+ * Each bank contains 4 words (32 bits).
+ * Bank 0 starts at offset 0 from the base.
+ */
+
+#define OTP_WORDS_PER_BANK		4
+#define OTP_WORD_SIZE			sizeof(u32)
+#define OTP_BIT_ADDR_OF_BANK		(8 * OTP_WORD_SIZE * OTP_WORDS_PER_BANK)
+#define QAC628_OTP_NUM_BANKS		8
+#define QAC628_OTP_SIZE			(QAC628_OTP_NUM_BANKS * OTP_WORDS_PER_BANK * OTP_WORD_SIZE)
+#define OTP_READ_TIMEOUT_US		200000
+
+/* HB_GPIO */
+#define ADDRESS_8_DATA			0x20
+
+/* OTP_RX */
+#define OTP_CONTROL_2			0x48
+#define OTP_RD_PERIOD			GENMASK(15, 8)
+#define OTP_RD_PERIOD_MASK		~GENMASK(15, 8)
+#define CPU_CLOCK			FIELD_PREP(OTP_RD_PERIOD, 30)
+#define SEL_BAK_KEY2			BIT(5)
+#define SEL_BAK_KEY2_MASK		~BIT(5)
+#define SW_TRIM_EN			BIT(4)
+#define SW_TRIM_EN_MASK			~BIT(4)
+#define SEL_BAK_KEY			BIT(3)
+#define SEL_BAK_KEY_MASK		~BIT(3)
+#define OTP_READ			BIT(2)
+#define OTP_LOAD_SECURE_DATA		BIT(1)
+#define OTP_LOAD_SECURE_DATA_MASK	~BIT(1)
+#define OTP_DO_CRC			BIT(0)
+#define OTP_DO_CRC_MASK			~BIT(0)
+#define OTP_STATUS			0x4c
+#define OTP_READ_DONE			BIT(4)
+#define OTP_READ_DONE_MASK		~BIT(4)
+#define OTP_LOAD_SECURE_DONE_MASK	~BIT(2)
+#define OTP_READ_ADDRESS		0x50
+
+enum base_type {
+	HB_GPIO,
+	OTPRX,
+	BASEMAX,
+};
+
+struct sp_ocotp_priv {
+	struct device *dev;
+	void __iomem *base[BASEMAX];
+	struct clk *clk;
+};
+
+struct sp_ocotp_data {
+	int size;
+};
+
+const struct sp_ocotp_data  sp_otp_v0 = {
+	.size = QAC628_OTP_SIZE,
+};
+
+static int sp_otp_read_real(struct sp_ocotp_priv *otp, int addr, char *value)
+{
+	unsigned int addr_data;
+	unsigned int byte_shift;
+	unsigned int status;
+	int ret;
+
+	addr_data = addr % (OTP_WORD_SIZE * OTP_WORDS_PER_BANK);
+	addr_data = addr_data / OTP_WORD_SIZE;
+
+	byte_shift = addr % (OTP_WORD_SIZE * OTP_WORDS_PER_BANK);
+	byte_shift = byte_shift % OTP_WORD_SIZE;
+
+	addr = addr / (OTP_WORD_SIZE * OTP_WORDS_PER_BANK);
+	addr = addr * OTP_BIT_ADDR_OF_BANK;
+
+	writel(readl(otp->base[OTPRX] + OTP_STATUS) & OTP_READ_DONE_MASK &
+	       OTP_LOAD_SECURE_DONE_MASK, otp->base[OTPRX] + OTP_STATUS);
+	writel(addr, otp->base[OTPRX] + OTP_READ_ADDRESS);
+	writel(readl(otp->base[OTPRX] + OTP_CONTROL_2) | OTP_READ,
+	       otp->base[OTPRX] + OTP_CONTROL_2);
+	writel(readl(otp->base[OTPRX] + OTP_CONTROL_2) & SEL_BAK_KEY2_MASK & SW_TRIM_EN_MASK
+	       & SEL_BAK_KEY_MASK & OTP_LOAD_SECURE_DATA_MASK & OTP_DO_CRC_MASK,
+	       otp->base[OTPRX] + OTP_CONTROL_2);
+	writel((readl(otp->base[OTPRX] + OTP_CONTROL_2) & OTP_RD_PERIOD_MASK) | CPU_CLOCK,
+	       otp->base[OTPRX] + OTP_CONTROL_2);
+
+	ret = readl_poll_timeout(otp->base[OTPRX] + OTP_STATUS, status,
+				 status & OTP_READ_DONE, 10, OTP_READ_TIMEOUT_US);
+
+	if (ret < 0)
+		return ret;
+
+	*value = (readl(otp->base[HB_GPIO] + ADDRESS_8_DATA + addr_data * OTP_WORD_SIZE)
+		  >> (8 * byte_shift)) & 0xff;
+
+	return ret;
+}
+
+static int sp_ocotp_read(void *priv, unsigned int offset, void *value, size_t bytes)
+{
+	struct sp_ocotp_priv *otp = priv;
+	unsigned int addr;
+	char *buf = value;
+	char val[4];
+	int ret;
+
+	ret = clk_enable(otp->clk);
+	if (ret)
+		return ret;
+
+	*buf = 0;
+	for (addr = offset; addr < (offset + bytes); addr++) {
+		ret = sp_otp_read_real(otp, addr, val);
+		if (ret < 0) {
+			dev_err(otp->dev, "OTP read fail:%d at %d", ret, addr);
+			goto disable_clk;
+		}
+
+		*buf++ = *val;
+	}
+
+disable_clk:
+	clk_disable(otp->clk);
+
+	return ret;
+}
+
+static struct nvmem_config sp_ocotp_nvmem_config = {
+	.name = "sp-ocotp",
+	.read_only = true,
+	.word_size = 1,
+	.size = QAC628_OTP_SIZE,
+	.stride = 1,
+	.reg_read = sp_ocotp_read,
+	.owner = THIS_MODULE,
+};
+
+static int sp_ocotp_probe(struct platform_device *pdev)
+{
+	struct device *dev = &pdev->dev;
+	struct nvmem_device *nvmem;
+	struct sp_ocotp_priv *otp;
+	struct resource *res;
+	int ret;
+
+	otp = devm_kzalloc(dev, sizeof(*otp), GFP_KERNEL);
+	if (!otp)
+		return -ENOMEM;
+
+	otp->dev = dev;
+
+	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "hb_gpio");
+	otp->base[HB_GPIO] = devm_ioremap_resource(dev, res);
+	if (IS_ERR(otp->base[HB_GPIO]))
+		return PTR_ERR(otp->base[HB_GPIO]);
+
+	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "otprx");
+	otp->base[OTPRX] = devm_ioremap_resource(dev, res);
+	if (IS_ERR(otp->base[OTPRX]))
+		return PTR_ERR(otp->base[OTPRX]);
+
+	otp->clk = devm_clk_get(&pdev->dev, NULL);
+	if (IS_ERR(otp->clk))
+		return dev_err_probe(&pdev->dev, PTR_ERR(otp->clk),
+						"devm_clk_get fail\n");
+
+	ret = clk_prepare(otp->clk);
+	if (ret < 0) {
+		dev_err(dev, "failed to prepare clk: %d\n", ret);
+		return ret;
+	}
+
+	sp_ocotp_nvmem_config.priv = otp;
+	sp_ocotp_nvmem_config.dev = dev;
+
+	nvmem = devm_nvmem_register(dev, &sp_ocotp_nvmem_config);
+	if (IS_ERR(nvmem))
+		return dev_err_probe(&pdev->dev, PTR_ERR(nvmem),
+						"register nvmem device fail\n");
+
+	platform_set_drvdata(pdev, nvmem);
+
+	dev_dbg(dev, "banks:%d x wpb:%d x wsize:%d = %d",
+		(int)QAC628_OTP_NUM_BANKS, (int)OTP_WORDS_PER_BANK,
+		(int)OTP_WORD_SIZE, (int)QAC628_OTP_SIZE);
+
+	dev_info(dev, "by Sunplus (C) 2020");
+
+	return 0;
+}
+
+static const struct of_device_id sp_ocotp_dt_ids[] = {
+	{ .compatible = "sunplus,sp7021-ocotp", .data = &sp_otp_v0 },
+	{ }
+};
+MODULE_DEVICE_TABLE(of, sp_ocotp_dt_ids);
+
+static struct platform_driver sp_otp_driver = {
+	.probe     = sp_ocotp_probe,
+	.driver    = {
+		.name           = "sunplus,sp7021-ocotp",
+		.of_match_table = sp_ocotp_dt_ids,
+	}
+};
+module_platform_driver(sp_otp_driver);
+
+MODULE_AUTHOR("Vincent Shih <vincent.sunplus@gmail.com>");
+MODULE_DESCRIPTION("Sunplus On-Chip OTP driver");
+MODULE_LICENSE("GPL");
+
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 3/3] dt-bindings: nvmem: Add bindings doc for Sunplus OCOTP driver
  2022-02-23 22:34 [PATCH 0/3] nvmem: patches (set 2) for 5.18 Srinivas Kandagatla
  2022-02-23 22:35 ` [PATCH 1/3] nvmem: qfprom: Increase fuse blow timeout to prevent write fail Srinivas Kandagatla
  2022-02-23 22:35 ` [PATCH 2/3] nvmem: Add driver for OCOTP in Sunplus SP7021 Srinivas Kandagatla
@ 2022-02-23 22:35 ` Srinivas Kandagatla
  2022-02-25 10:52 ` [PATCH 0/3] nvmem: patches (set 2) for 5.18 Srinivas Kandagatla
  3 siblings, 0 replies; 8+ messages in thread
From: Srinivas Kandagatla @ 2022-02-23 22:35 UTC (permalink / raw)
  To: gregkh; +Cc: linux-kernel, Vincent Shih, Rob Herring, Srinivas Kandagatla

From: Vincent Shih <vincent.sunplus@gmail.com>

Add bindings doc for Sunplus OCOTP driver

Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Vincent Shih <vincent.sunplus@gmail.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 .../bindings/nvmem/sunplus,sp7021-ocotp.yaml  | 86 +++++++++++++++++++
 MAINTAINERS                                   |  1 +
 2 files changed, 87 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/nvmem/sunplus,sp7021-ocotp.yaml

diff --git a/Documentation/devicetree/bindings/nvmem/sunplus,sp7021-ocotp.yaml b/Documentation/devicetree/bindings/nvmem/sunplus,sp7021-ocotp.yaml
new file mode 100644
index 000000000000..4b28f37dfb67
--- /dev/null
+++ b/Documentation/devicetree/bindings/nvmem/sunplus,sp7021-ocotp.yaml
@@ -0,0 +1,86 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright (C) Sunplus Co., Ltd. 2021
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/nvmem/sunplus,sp7021-ocotp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: On-Chip OTP Memory for Sunplus SP7021
+
+maintainers:
+  - Vincent Shih <vincent.sunplus@gmail.com>
+
+allOf:
+  - $ref: "nvmem.yaml#"
+
+properties:
+  compatible:
+    const: sunplus,sp7021-ocotp
+
+  reg:
+    maxItems: 2
+
+  reg-names:
+    items:
+      - const: hb_gpio
+      - const: otprx
+
+  clocks:
+    maxItems: 1
+
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 1
+
+  thermal-calibration:
+    type: object
+    description: thermal calibration values
+
+  disconnect-voltage:
+    type: object
+    description: disconnect voltages of usb2 port 0 and port 1
+
+  mac-address0:
+    type: object
+    description: MAC address of ethernet port 0
+
+  mac-address1:
+    type: object
+    description: MAC address of ethernet port 1
+
+required:
+  - compatible
+  - reg
+  - reg-names
+  - clocks
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/sp-sp7021.h>
+
+    otp: otp@9c00af00 {
+        compatible = "sunplus,sp7021-ocotp";
+        reg = <0x9c00af00 0x34>, <0x9c00af80 0x58>;
+        reg-names = "hb_gpio", "otprx";
+        clocks = <&clks OTPRX>;
+
+        #address-cells = <1>;
+        #size-cells = <1>;
+        therm_calib: thermal-calibration@14 {
+          reg = <0x14 0x3>;
+        };
+        disc_vol: disconnect-voltage@18 {
+          reg = <0x18 0x2>;
+        };
+        mac_addr0: mac-address0@34 {
+          reg = <0x34 0x6>;
+        };
+        mac_addr1: mac-address1@3a {
+          reg = <0x3a 0x6>;
+        };
+    };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 534772dfc3ef..507697a11838 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18494,6 +18494,7 @@ F:	drivers/rtc/rtc-sunplus.c
 SUNPLUS OCOTP DRIVER
 M:	Vincent Shih <vincent.sunplus@gmail.com>
 S:	Maintained
+F:	Documentation/devicetree/bindings/nvmem/sunplus,sp7021-ocotp.yaml
 F:	drivers/nvmem/sunplus-ocotp.c
 
 SUPERH
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/3] nvmem: patches (set 2) for 5.18
  2022-02-23 22:34 [PATCH 0/3] nvmem: patches (set 2) for 5.18 Srinivas Kandagatla
                   ` (2 preceding siblings ...)
  2022-02-23 22:35 ` [PATCH 3/3] dt-bindings: nvmem: Add bindings doc for Sunplus OCOTP driver Srinivas Kandagatla
@ 2022-02-25 10:52 ` Srinivas Kandagatla
  2022-02-25 11:17   ` Srinivas Kandagatla
  2022-02-25 11:18   ` Greg KH
  3 siblings, 2 replies; 8+ messages in thread
From: Srinivas Kandagatla @ 2022-02-25 10:52 UTC (permalink / raw)
  To: gregkh; +Cc: linux-kernel

Hi Greg,

On 23/02/2022 22:34, Srinivas Kandagatla wrote:
> Hi Greg,
> 
> Here is final set of nvmem patches for 5.18 which includes
> 
> - Add new Sunplus nvmem provider and bindings.
> - fix in qfprom to increase blow timeout.
> 
> Can you please queue them up for 5.18.
> 
> thanks for you help,
> srini
> 
> Knox Chiou (1):
>    nvmem: qfprom: Increase fuse blow timeout to prevent write fail
> 
> Vincent Shih (2):
>    nvmem: Add driver for OCOTP in Sunplus SP7021
>    dt-bindings: nvmem: Add bindings doc for Sunplus OCOTP driver

Sorry for inconvenience, but can you please ignore this set if you have 
not already applied them.

There seems to be a issue with yaml file which fails dt-bindings check 
and there are few more patches that can go for 5.18.

I will a send new set soon.

Thanks for your help
--srini

> 
>   .../bindings/nvmem/sunplus,sp7021-ocotp.yaml  |  86 +++++++
>   MAINTAINERS                                   |   6 +
>   drivers/nvmem/Kconfig                         |  12 +
>   drivers/nvmem/Makefile                        |   2 +
>   drivers/nvmem/qfprom.c                        |   2 +-
>   drivers/nvmem/sunplus-ocotp.c                 | 228 ++++++++++++++++++
>   6 files changed, 335 insertions(+), 1 deletion(-)
>   create mode 100644 Documentation/devicetree/bindings/nvmem/sunplus,sp7021-ocotp.yaml
>   create mode 100644 drivers/nvmem/sunplus-ocotp.c
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/3] nvmem: patches (set 2) for 5.18
  2022-02-25 10:52 ` [PATCH 0/3] nvmem: patches (set 2) for 5.18 Srinivas Kandagatla
@ 2022-02-25 11:17   ` Srinivas Kandagatla
  2022-02-25 11:31     ` Greg KH
  2022-02-25 11:18   ` Greg KH
  1 sibling, 1 reply; 8+ messages in thread
From: Srinivas Kandagatla @ 2022-02-25 11:17 UTC (permalink / raw)
  To: gregkh; +Cc: linux-kernel



On 25/02/2022 10:52, Srinivas Kandagatla wrote:
> Hi Greg,
> 
> On 23/02/2022 22:34, Srinivas Kandagatla wrote:
>> Hi Greg,
>>
>> Here is final set of nvmem patches for 5.18 which includes
>>
>> - Add new Sunplus nvmem provider and bindings.
>> - fix in qfprom to increase blow timeout.
>>
>> Can you please queue them up for 5.18.
>>
>> thanks for you help,
>> srini
>>
>> Knox Chiou (1):
>>    nvmem: qfprom: Increase fuse blow timeout to prevent write fail
>>
>> Vincent Shih (2):
>>    nvmem: Add driver for OCOTP in Sunplus SP7021
>>    dt-bindings: nvmem: Add bindings doc for Sunplus OCOTP driver
> 
> Sorry for inconvenience, but can you please ignore this set if you have 
> not already applied them.
> 
Opps, It looks like these were just applied.

I can send other patches along with fix to yaml as next set, if that 
works for you?


thanks,
srini


> There seems to be a issue with yaml file which fails dt-bindings check 
> and there are few more patches that can go for 5.18.
> 
> I will a send new set soon.
> 
> Thanks for your help
> --srini
> 
>>
>>   .../bindings/nvmem/sunplus,sp7021-ocotp.yaml  |  86 +++++++
>>   MAINTAINERS                                   |   6 +
>>   drivers/nvmem/Kconfig                         |  12 +
>>   drivers/nvmem/Makefile                        |   2 +
>>   drivers/nvmem/qfprom.c                        |   2 +-
>>   drivers/nvmem/sunplus-ocotp.c                 | 228 ++++++++++++++++++
>>   6 files changed, 335 insertions(+), 1 deletion(-)
>>   create mode 100644 
>> Documentation/devicetree/bindings/nvmem/sunplus,sp7021-ocotp.yaml
>>   create mode 100644 drivers/nvmem/sunplus-ocotp.c
>>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/3] nvmem: patches (set 2) for 5.18
  2022-02-25 10:52 ` [PATCH 0/3] nvmem: patches (set 2) for 5.18 Srinivas Kandagatla
  2022-02-25 11:17   ` Srinivas Kandagatla
@ 2022-02-25 11:18   ` Greg KH
  1 sibling, 0 replies; 8+ messages in thread
From: Greg KH @ 2022-02-25 11:18 UTC (permalink / raw)
  To: Srinivas Kandagatla; +Cc: linux-kernel

On Fri, Feb 25, 2022 at 10:52:59AM +0000, Srinivas Kandagatla wrote:
> Hi Greg,
> 
> On 23/02/2022 22:34, Srinivas Kandagatla wrote:
> > Hi Greg,
> > 
> > Here is final set of nvmem patches for 5.18 which includes
> > 
> > - Add new Sunplus nvmem provider and bindings.
> > - fix in qfprom to increase blow timeout.
> > 
> > Can you please queue them up for 5.18.
> > 
> > thanks for you help,
> > srini
> > 
> > Knox Chiou (1):
> >    nvmem: qfprom: Increase fuse blow timeout to prevent write fail
> > 
> > Vincent Shih (2):
> >    nvmem: Add driver for OCOTP in Sunplus SP7021
> >    dt-bindings: nvmem: Add bindings doc for Sunplus OCOTP driver
> 
> Sorry for inconvenience, but can you please ignore this set if you have not
> already applied them.

I already applied them :(

> There seems to be a issue with yaml file which fails dt-bindings check and
> there are few more patches that can go for 5.18.
> 
> I will a send new set soon.

Send a fixup patch?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/3] nvmem: patches (set 2) for 5.18
  2022-02-25 11:17   ` Srinivas Kandagatla
@ 2022-02-25 11:31     ` Greg KH
  0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2022-02-25 11:31 UTC (permalink / raw)
  To: Srinivas Kandagatla; +Cc: linux-kernel

On Fri, Feb 25, 2022 at 11:17:47AM +0000, Srinivas Kandagatla wrote:
> 
> 
> On 25/02/2022 10:52, Srinivas Kandagatla wrote:
> > Hi Greg,
> > 
> > On 23/02/2022 22:34, Srinivas Kandagatla wrote:
> > > Hi Greg,
> > > 
> > > Here is final set of nvmem patches for 5.18 which includes
> > > 
> > > - Add new Sunplus nvmem provider and bindings.
> > > - fix in qfprom to increase blow timeout.
> > > 
> > > Can you please queue them up for 5.18.
> > > 
> > > thanks for you help,
> > > srini
> > > 
> > > Knox Chiou (1):
> > >    nvmem: qfprom: Increase fuse blow timeout to prevent write fail
> > > 
> > > Vincent Shih (2):
> > >    nvmem: Add driver for OCOTP in Sunplus SP7021
> > >    dt-bindings: nvmem: Add bindings doc for Sunplus OCOTP driver
> > 
> > Sorry for inconvenience, but can you please ignore this set if you have
> > not already applied them.
> > 
> Opps, It looks like these were just applied.
> 
> I can send other patches along with fix to yaml as next set, if that works
> for you?

Yes please.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-02-25 11:31 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-23 22:34 [PATCH 0/3] nvmem: patches (set 2) for 5.18 Srinivas Kandagatla
2022-02-23 22:35 ` [PATCH 1/3] nvmem: qfprom: Increase fuse blow timeout to prevent write fail Srinivas Kandagatla
2022-02-23 22:35 ` [PATCH 2/3] nvmem: Add driver for OCOTP in Sunplus SP7021 Srinivas Kandagatla
2022-02-23 22:35 ` [PATCH 3/3] dt-bindings: nvmem: Add bindings doc for Sunplus OCOTP driver Srinivas Kandagatla
2022-02-25 10:52 ` [PATCH 0/3] nvmem: patches (set 2) for 5.18 Srinivas Kandagatla
2022-02-25 11:17   ` Srinivas Kandagatla
2022-02-25 11:31     ` Greg KH
2022-02-25 11:18   ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).