From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Yang Shi <shy828301@gmail.com>,
vbabka@suse.cz, kirill.shutemov@linux.intel.com,
songliubraving@fb.com, linmiaohe@huawei.com, riel@surriel.com,
willy@infradead.org, ziy@nvidia.com, akpm@linux-foundation.org,
tytso@mit.edu, adilger.kernel@dilger.ca, darrick.wong@oracle.com
Cc: lkp@intel.com, kbuild-all@lists.01.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/8] mm: thp: only regular file could be THP eligible
Date: Thu, 3 Mar 2022 14:43:53 +0300 [thread overview]
Message-ID: <202203020034.2Ii9kTrs-lkp@intel.com> (raw)
In-Reply-To: <20220228235741.102941-5-shy828301@gmail.com>
Hi Yang,
url: https://github.com/0day-ci/linux/commits/Yang-Shi/Make-khugepaged-collapse-readonly-FS-THP-more-consistent/20220301-075903
base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
config: arm64-randconfig-m031-20220227 (https://download.01.org/0day-ci/archive/20220302/202203020034.2Ii9kTrs-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
include/linux/huge_mm.h:179 file_thp_enabled() warn: variable dereferenced before check 'vma->vm_file' (see line 177)
mm/khugepaged.c:468 hugepage_vma_check() error: we previously assumed 'vma->vm_file' could be null (see line 455)
include/linux/huge_mm.h:179 file_thp_enabled() warn: variable dereferenced before check 'vma->vm_file' (see line 177)
vim +179 include/linux/huge_mm.h
2224ed1155c07b Yang Shi 2022-02-28 175 static inline bool file_thp_enabled(struct vm_area_struct *vma)
2224ed1155c07b Yang Shi 2022-02-28 176 {
2224ed1155c07b Yang Shi 2022-02-28 @177 struct inode *inode = vma->vm_file->f_inode;
^^^^^^^^^^^^^^
Dereference.
2224ed1155c07b Yang Shi 2022-02-28 178
2224ed1155c07b Yang Shi 2022-02-28 @179 return (IS_ENABLED(CONFIG_READ_ONLY_THP_FOR_FS)) && vma->vm_file &&
^^^^^^^^^^^^
Checked too late.
2224ed1155c07b Yang Shi 2022-02-28 180 (vma->vm_flags & VM_EXEC) &&
2224ed1155c07b Yang Shi 2022-02-28 181 !inode_is_open_for_write(inode) && S_ISREG(inode->i_mode);
2224ed1155c07b Yang Shi 2022-02-28 182 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next prev parent reply other threads:[~2022-03-03 11:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 23:57 [PATCH 0/8] Make khugepaged collapse readonly FS THP more consistent Yang Shi
2022-02-28 23:57 ` [PATCH 1/8] sched: coredump.h: clarify the use of MMF_VM_HUGEPAGE Yang Shi
2022-03-01 8:45 ` Miaohe Lin
2022-03-01 21:49 ` Yang Shi
2022-03-02 1:39 ` Miaohe Lin
2022-02-28 23:57 ` [PATCH 2/8] mm: khugepaged: remove redundant check for VM_NO_KHUGEPAGED Yang Shi
2022-03-01 9:07 ` Miaohe Lin
2022-03-02 18:43 ` Yang Shi
2022-03-03 10:53 ` Miaohe Lin
2022-02-28 23:57 ` [PATCH 3/8] mm: khugepaged: skip DAX vma Yang Shi
2022-03-02 3:21 ` Miaohe Lin
2022-02-28 23:57 ` [PATCH 4/8] mm: thp: only regular file could be THP eligible Yang Shi
2022-03-03 11:43 ` Dan Carpenter [this message]
2022-03-03 11:48 ` Miaohe Lin
2022-03-03 19:14 ` Yang Shi
2022-02-28 23:57 ` [PATCH 5/8] mm: khugepaged: make khugepaged_enter() void function Yang Shi
2022-02-28 23:57 ` [PATCH 6/8] mm: khugepaged: move some khugepaged_* functions to khugepaged.c Yang Shi
2022-02-28 23:57 ` [PATCH 7/8] mm: khugepaged: introduce khugepaged_enter_file() helper Yang Shi
2022-02-28 23:57 ` [PATCH 8/8] fs: register suitable readonly vmas for khugepaged Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202203020034.2Ii9kTrs-lkp@intel.com \
--to=dan.carpenter@oracle.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=darrick.wong@oracle.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linmiaohe@huawei.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=lkp@intel.com \
--cc=riel@surriel.com \
--cc=shy828301@gmail.com \
--cc=songliubraving@fb.com \
--cc=tytso@mit.edu \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).