From: Miaohe Lin <linmiaohe@huawei.com>
To: Yang Shi <shy828301@gmail.com>
Cc: <linux-mm@kvack.org>, <linux-fsdevel@vger.kernel.org>,
<linux-ext4@vger.kernel.org>, <linux-xfs@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <vbabka@suse.cz>,
<kirill.shutemov@linux.intel.com>, <songliubraving@fb.com>,
<riel@surriel.com>, <willy@infradead.org>, <ziy@nvidia.com>,
<akpm@linux-foundation.org>, <tytso@mit.edu>,
<adilger.kernel@dilger.ca>, <darrick.wong@oracle.com>
Subject: Re: [PATCH 1/8] sched: coredump.h: clarify the use of MMF_VM_HUGEPAGE
Date: Tue, 1 Mar 2022 16:45:20 +0800 [thread overview]
Message-ID: <cfaefe6f-dd51-1595-a23c-1aa5dc8350ff@huawei.com> (raw)
In-Reply-To: <20220228235741.102941-2-shy828301@gmail.com>
On 2022/3/1 7:57, Yang Shi wrote:
> MMF_VM_HUGEPAGE is set as long as the mm is available for khugepaged by
> khugepaged_enter(), not only when VM_HUGEPAGE is set on vma. Correct
> the comment to avoid confusion.
>
> Signed-off-by: Yang Shi <shy828301@gmail.com>
> ---
> include/linux/sched/coredump.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/sched/coredump.h b/include/linux/sched/coredump.h
> index 4d9e3a656875..4d0a5be28b70 100644
> --- a/include/linux/sched/coredump.h
> +++ b/include/linux/sched/coredump.h
> @@ -57,7 +57,8 @@ static inline int get_dumpable(struct mm_struct *mm)
> #endif
> /* leave room for more dump flags */
> #define MMF_VM_MERGEABLE 16 /* KSM may merge identical pages */
> -#define MMF_VM_HUGEPAGE 17 /* set when VM_HUGEPAGE is set on vma */
> +#define MMF_VM_HUGEPAGE 17 /* set when mm is available for
> + khugepaged */
I think this comment could be written in one line. Anyway, this patch looks good to me.
Thanks.
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
> /*
> * This one-shot flag is dropped due to necessity of changing exe once again
> * on NFS restore
>
next prev parent reply other threads:[~2022-03-01 8:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 23:57 [PATCH 0/8] Make khugepaged collapse readonly FS THP more consistent Yang Shi
2022-02-28 23:57 ` [PATCH 1/8] sched: coredump.h: clarify the use of MMF_VM_HUGEPAGE Yang Shi
2022-03-01 8:45 ` Miaohe Lin [this message]
2022-03-01 21:49 ` Yang Shi
2022-03-02 1:39 ` Miaohe Lin
2022-02-28 23:57 ` [PATCH 2/8] mm: khugepaged: remove redundant check for VM_NO_KHUGEPAGED Yang Shi
2022-03-01 9:07 ` Miaohe Lin
2022-03-02 18:43 ` Yang Shi
2022-03-03 10:53 ` Miaohe Lin
2022-02-28 23:57 ` [PATCH 3/8] mm: khugepaged: skip DAX vma Yang Shi
2022-03-02 3:21 ` Miaohe Lin
2022-02-28 23:57 ` [PATCH 4/8] mm: thp: only regular file could be THP eligible Yang Shi
2022-03-03 11:43 ` Dan Carpenter
2022-03-03 11:48 ` Miaohe Lin
2022-03-03 19:14 ` Yang Shi
2022-02-28 23:57 ` [PATCH 5/8] mm: khugepaged: make khugepaged_enter() void function Yang Shi
2022-02-28 23:57 ` [PATCH 6/8] mm: khugepaged: move some khugepaged_* functions to khugepaged.c Yang Shi
2022-02-28 23:57 ` [PATCH 7/8] mm: khugepaged: introduce khugepaged_enter_file() helper Yang Shi
2022-02-28 23:57 ` [PATCH 8/8] fs: register suitable readonly vmas for khugepaged Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfaefe6f-dd51-1595-a23c-1aa5dc8350ff@huawei.com \
--to=linmiaohe@huawei.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=darrick.wong@oracle.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=riel@surriel.com \
--cc=shy828301@gmail.com \
--cc=songliubraving@fb.com \
--cc=tytso@mit.edu \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).