Re: [PATCH 2/2] nvmem: Add Apple eFuse driver

[kernel test robot <lkp@intel.com>]

Hi Sven,

I love your patch! Perhaps something to improve:

[auto build test WARNING on soc/for-next]
[also build test WARNING on linus/master v5.17-rc6]
[cannot apply to robh/for-next next-20220303]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sven-Peter/dt-bindings-nvmem-Add-apple-efuses/20220227-195847
base:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
config: ia64-randconfig-s031-20220302 (https://download.01.org/0day-ci/archive/20220303/202203032219.gDn8cX7m-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/0day-ci/linux/commit/e47f957c24fcbc9f99a972b1b7c802eec04ed40a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Sven-Peter/dt-bindings-nvmem-Add-apple-efuses/20220227-195847
        git checkout e47f957c24fcbc9f99a972b1b7c802eec04ed40a
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/nvmem/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> drivers/nvmem/apple-efuses.c:17:31: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected void [noderef] __iomem *fuses @@     got void *context @@
   drivers/nvmem/apple-efuses.c:17:31: sparse:     expected void [noderef] __iomem *fuses
   drivers/nvmem/apple-efuses.c:17:31: sparse:     got void *context
>> drivers/nvmem/apple-efuses.c:42:21: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected void *priv @@     got void [noderef] __iomem * @@
   drivers/nvmem/apple-efuses.c:42:21: sparse:     expected void *priv
   drivers/nvmem/apple-efuses.c:42:21: sparse:     got void [noderef] __iomem *
   drivers/nvmem/apple-efuses.c: note: in included file (through arch/ia64/include/asm/io.h, include/linux/io.h):
   include/asm-generic/io.h:267:16: sparse: sparse: cast to restricted __le32

vim +17 drivers/nvmem/apple-efuses.c

    13	
    14	static int apple_efuses_read(void *context, unsigned int offset, void *val,
    15				     size_t bytes)
    16	{
  > 17		void __iomem *fuses = context;
    18		u32 *dst = val;
    19	
    20		while (bytes >= sizeof(u32)) {
    21			*dst++ = readl_relaxed(fuses + offset);
    22			bytes -= sizeof(u32);
    23			offset += sizeof(u32);
    24		}
    25	
    26		return 0;
    27	}
    28	
    29	static int apple_efuses_probe(struct platform_device *pdev)
    30	{
    31		struct resource *res;
    32		struct nvmem_config config = {
    33			.dev = &pdev->dev,
    34			.read_only = true,
    35			.reg_read = apple_efuses_read,
    36			.stride = sizeof(u32),
    37			.word_size = sizeof(u32),
    38			.name = "apple_efuses_nvmem",
    39			.id = NVMEM_DEVID_AUTO,
    40		};
    41	
  > 42		config.priv = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
    43		if (IS_ERR(config.priv))
    44			return PTR_ERR(config.priv);
    45	
    46		config.size = resource_size(res);
    47	
    48		return PTR_ERR_OR_ZERO(devm_nvmem_register(config.dev, &config));
    49	}
    50	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org