From: "Sven Peter" <sven@svenpeter.dev>
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>
Cc: "Hector Martin" <marcan@marcan.st>,
"Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
"Mark Kettenis" <kettenis@openbsd.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: nvmem: Add apple,efuses
Date: Sat, 05 Mar 2022 13:00:17 +0100 [thread overview]
Message-ID: <2e36dae0-7eff-43fc-b1a5-2c530f56e877@www.fastmail.com> (raw)
In-Reply-To: <0d7b9a17-f5fc-69e5-173f-1c897522d3f3@canonical.com>
On Thu, Mar 3, 2022, at 19:00, Krzysztof Kozlowski wrote:
> On 27/02/2022 12:57, Sven Peter wrote:
>> Apple SoCs come with eFuses used to store factory-programmed data
>> such as calibration settings for the PCIe and Type-C PHY.
>>
>> Signed-off-by: Sven Peter <sven@svenpeter.dev>
>> ---
>> .../bindings/nvmem/apple,efuses.yaml | 50 +++++++++++++++++++
>> MAINTAINERS | 1 +
>> 2 files changed, 51 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/nvmem/apple,efuses.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/nvmem/apple,efuses.yaml b/Documentation/devicetree/bindings/nvmem/apple,efuses.yaml
>> new file mode 100644
>> index 000000000000..a735d54856ae
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/nvmem/apple,efuses.yaml
>> @@ -0,0 +1,50 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/nvmem/apple,efuses.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Apple SoC eFuse-based NVMEM
>> +
>> +description: |
>> + Apple SoCs such as the M1 contain factory-programmed eFuses used to e.g. store
>> + calibration data for the PCIe and the Type-C PHY or unique chip identifiers such
>> + as the ECID.
>> +
>> +maintainers:
>> + - Sven Peter <sven@svenpeter.dev>
>> +
>> +allOf:
>> + - $ref: "nvmem.yaml#"
>> +
>> +properties:
>> + compatible:
>> + items:
>> + - enum:
>> + - apple,t8103-efuses
>> + - apple,t6000-efuses
>> + - const: apple,efuses
>> +
>> + reg:
>> + maxItems: 1
>> +
>> +required:
>> + - compatible
>> + - reg
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> + - |
>> + efuse@3d2bc000 {
>> + compatible = "apple,t8103-efuses", "apple,efuses";
>> + reg = <0x3d2bc000 0x1000>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> +
>> + ecid: efuse@500 {
>> + reg = <0x500 0x8>;
>
> Mismatched indentation. Rest looks good.
Good catch, thanks! Will fix it for v2.
Best,
Sven
prev parent reply other threads:[~2022-03-05 12:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-27 11:57 [PATCH 1/2] dt-bindings: nvmem: Add apple,efuses Sven Peter
2022-02-27 11:57 ` [PATCH 2/2] nvmem: Add Apple eFuse driver Sven Peter
2022-03-03 14:16 ` kernel test robot
2022-03-03 18:00 ` [PATCH 1/2] dt-bindings: nvmem: Add apple,efuses Krzysztof Kozlowski
2022-03-05 12:00 ` Sven Peter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e36dae0-7eff-43fc-b1a5-2c530f56e877@www.fastmail.com \
--to=sven@svenpeter.dev \
--cc=alyssa@rosenzweig.io \
--cc=devicetree@vger.kernel.org \
--cc=kettenis@openbsd.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).