* [PATCH] lib/Kconfig.debug: add ARCH dependency for FUNCTION_ALIGN option
@ 2022-03-03 8:20 Feng Tang
2022-03-04 1:45 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Feng Tang @ 2022-03-03 8:20 UTC (permalink / raw)
To: Masahiro Yamada, Michal Marek, Andrew Morton, kernel test robot,
linux-kbuild, linux-kernel
Cc: Feng Tang, Guo Ren
0Day robots reported there is compiling issue for 'csky' ARCH
when CONFIG_DEBUG_FORCE_DATA_SECTION_ALIGNED is enabled [1]:
"
All errors (new ones prefixed by >>):
{standard input}: Assembler messages:
>> {standard input}:2277: Error: pcrel offset for branch to .LS000B too far (0x3c)
"
Which has been discussed in [2]. And as there is no solution for csky
yet, add some dependency for this config to limit it to several ARCHs
which have no compiling issue so far.
[1]. https://lore.kernel.org/lkml/202202271612.W32UJAj2-lkp@intel.com/
[2]. https://www.spinics.net/lists/linux-kbuild/msg30298.html
Reported-by: kernel test robot <lkp@intel.com>
Cc: Guo Ren <guoren@kernel.org>
Signed-off-by: Feng Tang <feng.tang@intel.com>
---
lib/Kconfig.debug | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index d6b5c94df099..a270a64e4429 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -401,8 +401,8 @@ config SECTION_MISMATCH_WARN_ONLY
If unsure, say Y.
config DEBUG_FORCE_FUNCTION_ALIGN_64B
- bool "Force all function address 64B aligned" if EXPERT
- depends on PPC || ARM || X86
+ bool "Force all function address 64B aligned"
+ depends on EXPERT && (X86_64 || ARM64 || PPC32 || PPC64 || ARC)
help
There are cases that a commit from one domain changes the function
address alignment of other domains, and cause magic performance
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] lib/Kconfig.debug: add ARCH dependency for FUNCTION_ALIGN option
2022-03-03 8:20 [PATCH] lib/Kconfig.debug: add ARCH dependency for FUNCTION_ALIGN option Feng Tang
@ 2022-03-04 1:45 ` Andrew Morton
2022-03-04 2:11 ` Feng Tang
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2022-03-04 1:45 UTC (permalink / raw)
To: Feng Tang
Cc: Masahiro Yamada, Michal Marek, kernel test robot, linux-kbuild,
linux-kernel, Guo Ren
On Thu, 3 Mar 2022 16:20:48 +0800 Feng Tang <feng.tang@intel.com> wrote:
> 0Day robots reported there is compiling issue for 'csky' ARCH
> when CONFIG_DEBUG_FORCE_DATA_SECTION_ALIGNED is enabled [1]:
>
> ...
>
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -401,8 +401,8 @@ config SECTION_MISMATCH_WARN_ONLY
> If unsure, say Y.
>
> config DEBUG_FORCE_FUNCTION_ALIGN_64B
> - bool "Force all function address 64B aligned" if EXPERT
> - depends on PPC || ARM || X86
I cannot find a kernel which contains the above line?
> + bool "Force all function address 64B aligned"
> + depends on EXPERT && (X86_64 || ARM64 || PPC32 || PPC64 || ARC)
> help
> There are cases that a commit from one domain changes the function
> address alignment of other domains, and cause magic performance
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] lib/Kconfig.debug: add ARCH dependency for FUNCTION_ALIGN option
2022-03-04 1:45 ` Andrew Morton
@ 2022-03-04 2:11 ` Feng Tang
0 siblings, 0 replies; 3+ messages in thread
From: Feng Tang @ 2022-03-04 2:11 UTC (permalink / raw)
To: Andrew Morton
Cc: Masahiro Yamada, Michal Marek, kernel test robot, linux-kbuild,
linux-kernel, Guo Ren
On Thu, Mar 03, 2022 at 05:45:50PM -0800, Andrew Morton wrote:
> On Thu, 3 Mar 2022 16:20:48 +0800 Feng Tang <feng.tang@intel.com> wrote:
>
> > 0Day robots reported there is compiling issue for 'csky' ARCH
> > when CONFIG_DEBUG_FORCE_DATA_SECTION_ALIGNED is enabled [1]:
> >
> > ...
> >
> > --- a/lib/Kconfig.debug
> > +++ b/lib/Kconfig.debug
> > @@ -401,8 +401,8 @@ config SECTION_MISMATCH_WARN_ONLY
> > If unsure, say Y.
> >
> > config DEBUG_FORCE_FUNCTION_ALIGN_64B
> > - bool "Force all function address 64B aligned" if EXPERT
> > - depends on PPC || ARM || X86
>
> I cannot find a kernel which contains the above line?
Sorry. I generated the patch while forgetting to revert the older version
https://lore.kernel.org/lkml/20220228022022.GG4548@shbuild999.sh.intel.com/
Here is the correct versin, thanks!
---
From 817dca1a74778979ba71ed362eac36feab5ac112 Mon Sep 17 00:00:00 2001
From: Feng Tang <feng.tang@intel.com>
Date: Fri, 4 Mar 2022 10:03:40 +0800
Subject: [PATCH] lib/Kconfig.debug: add ARCH dependency for FUNCTION_ALIGN
option
0Day robots reported there is compiling issue for 'csky' ARCH
when CONFIG_DEBUG_FORCE_DATA_SECTION_ALIGNED is enabled [1]:
"
All errors (new ones prefixed by >>):
{standard input}: Assembler messages:
>> {standard input}:2277: Error: pcrel offset for branch to .LS000B too far (0x3c)
"
Which has been discussed in [2]. And as there is no solution for csky
yet, add some dependency for this config to limit it to several ARCHs
which have no compiling issue so far.
[1]. https://lore.kernel.org/lkml/202202271612.W32UJAj2-lkp@intel.com/
[2]. https://www.spinics.net/lists/linux-kbuild/msg30298.html
Reported-by: kernel test robot <lkp@intel.com>
Cc: Guo Ren <guoren@kernel.org>
Signed-off-by: Feng Tang <feng.tang@intel.com>
---
lib/Kconfig.debug | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 14b89aa37c5c..440fd666c16d 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -416,7 +416,8 @@ config SECTION_MISMATCH_WARN_ONLY
If unsure, say Y.
config DEBUG_FORCE_FUNCTION_ALIGN_64B
- bool "Force all function address 64B aligned" if EXPERT
+ bool "Force all function address 64B aligned"
+ depends on EXPERT && (X86_64 || ARM64 || PPC32 || PPC64 || ARC)
help
There are cases that a commit from one domain changes the function
address alignment of other domains, and cause magic performance
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-04 2:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-03 8:20 [PATCH] lib/Kconfig.debug: add ARCH dependency for FUNCTION_ALIGN option Feng Tang
2022-03-04 1:45 ` Andrew Morton
2022-03-04 2:11 ` Feng Tang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).