* [PATCH 1/6] staging: r8188eu: remove unnecessary initializations
2022-03-05 18:53 [PATCH 0/6] staging: r8188eu: some rx cleanups Martin Kaiser
@ 2022-03-05 18:53 ` Martin Kaiser
2022-03-05 18:53 ` [PATCH 2/6] staging: r8188eu: remove three unused receive defines Martin Kaiser
` (5 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Martin Kaiser @ 2022-03-05 18:53 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Larry Finger, Phillip Potter, Michael Straube, linux-staging,
linux-kernel, Martin Kaiser
Do not initialise bPacketMatchBSSID, bPacketToSelf and bPacketBeacon to
false at the start of update_recvframe_phyinfo_88e. All of them are set to
their actual values before they're used.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/hal/rtl8188e_rxdesc.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/r8188eu/hal/rtl8188e_rxdesc.c b/drivers/staging/r8188eu/hal/rtl8188e_rxdesc.c
index b4c9738ed868..387af789797d 100644
--- a/drivers/staging/r8188eu/hal/rtl8188e_rxdesc.c
+++ b/drivers/staging/r8188eu/hal/rtl8188e_rxdesc.c
@@ -118,10 +118,6 @@ void update_recvframe_phyinfo_88e(struct recv_frame *precvframe, struct phy_stat
struct sta_priv *pstapriv;
struct sta_info *psta;
- pkt_info.bPacketMatchBSSID = false;
- pkt_info.bPacketToSelf = false;
- pkt_info.bPacketBeacon = false;
-
pkt_info.bPacketMatchBSSID = ((!IsFrameTypeCtrl(wlanhdr)) &&
!pattrib->icv_err && !pattrib->crc_err &&
!memcmp(get_hdr_bssid(wlanhdr),
--
2.30.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 2/6] staging: r8188eu: remove three unused receive defines
2022-03-05 18:53 [PATCH 0/6] staging: r8188eu: some rx cleanups Martin Kaiser
2022-03-05 18:53 ` [PATCH 1/6] staging: r8188eu: remove unnecessary initializations Martin Kaiser
@ 2022-03-05 18:53 ` Martin Kaiser
2022-03-05 18:53 ` [PATCH 3/6] staging: r8188eu: remove unused function prototype Martin Kaiser
` (4 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Martin Kaiser @ 2022-03-05 18:53 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Larry Finger, Phillip Potter, Michael Straube, linux-staging,
linux-kernel, Martin Kaiser
Remove three unused defines from rtl8188e_recv.h.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/include/rtl8188e_recv.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/r8188eu/include/rtl8188e_recv.h b/drivers/staging/r8188eu/include/rtl8188e_recv.h
index a2320af11216..09adffd756de 100644
--- a/drivers/staging/r8188eu/include/rtl8188e_recv.h
+++ b/drivers/staging/r8188eu/include/rtl8188e_recv.h
@@ -6,10 +6,6 @@
#define TX_RPT1_PKT_LEN 8
-#define RECV_BLK_SZ 512
-#define RECV_BLK_CNT 16
-#define RECV_BLK_TH RECV_BLK_CNT
-
#define NR_PREALLOC_RECV_SKB (8)
#define NR_RECVBUFF (4)
--
2.30.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 3/6] staging: r8188eu: remove unused function prototype
2022-03-05 18:53 [PATCH 0/6] staging: r8188eu: some rx cleanups Martin Kaiser
2022-03-05 18:53 ` [PATCH 1/6] staging: r8188eu: remove unnecessary initializations Martin Kaiser
2022-03-05 18:53 ` [PATCH 2/6] staging: r8188eu: remove three unused receive defines Martin Kaiser
@ 2022-03-05 18:53 ` Martin Kaiser
2022-03-05 18:53 ` [PATCH 4/6] staging: r8188eu: make rtl8188e_process_phy_info static Martin Kaiser
` (3 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Martin Kaiser @ 2022-03-05 18:53 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Larry Finger, Phillip Potter, Michael Straube, linux-staging,
linux-kernel, Martin Kaiser
Remove the prototype for rtl8188eu_recv_hdl. This function does not exist
in the r8188eu driver.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/include/rtl8188e_recv.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/r8188eu/include/rtl8188e_recv.h b/drivers/staging/r8188eu/include/rtl8188e_recv.h
index 09adffd756de..8d06815d0374 100644
--- a/drivers/staging/r8188eu/include/rtl8188e_recv.h
+++ b/drivers/staging/r8188eu/include/rtl8188e_recv.h
@@ -35,7 +35,6 @@ enum rx_packet_type {
s32 rtl8188eu_init_recv_priv(struct adapter *padapter);
void rtl8188eu_free_recv_priv(struct adapter * padapter);
-void rtl8188eu_recv_hdl(struct adapter * padapter, struct recv_buf *precvbuf);
void rtl8188eu_recv_tasklet(unsigned long priv);
void rtl8188e_process_phy_info(struct adapter * padapter, void *prframe);
void update_recvframe_phyinfo_88e(struct recv_frame *fra, struct phy_stat *phy);
--
2.30.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 4/6] staging: r8188eu: make rtl8188e_process_phy_info static
2022-03-05 18:53 [PATCH 0/6] staging: r8188eu: some rx cleanups Martin Kaiser
` (2 preceding siblings ...)
2022-03-05 18:53 ` [PATCH 3/6] staging: r8188eu: remove unused function prototype Martin Kaiser
@ 2022-03-05 18:53 ` Martin Kaiser
2022-03-05 18:53 ` [PATCH 5/6] staging: r8188eu: remove some unused local ieee80211 macros Martin Kaiser
` (2 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Martin Kaiser @ 2022-03-05 18:53 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Larry Finger, Phillip Potter, Michael Straube, linux-staging,
linux-kernel, Martin Kaiser
rtl8188e_process_phy_info is used only in rtl8188e_rxdesc.c. Make the
function static and remove its prototype from rtl8188e_recv.h.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/hal/rtl8188e_rxdesc.c | 2 +-
drivers/staging/r8188eu/include/rtl8188e_recv.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/r8188eu/hal/rtl8188e_rxdesc.c b/drivers/staging/r8188eu/hal/rtl8188e_rxdesc.c
index 387af789797d..9bf7a9248026 100644
--- a/drivers/staging/r8188eu/hal/rtl8188e_rxdesc.c
+++ b/drivers/staging/r8188eu/hal/rtl8188e_rxdesc.c
@@ -45,7 +45,7 @@ static void process_link_qual(struct adapter *padapter, struct recv_frame *prfra
signal_stat->avg_val = signal_stat->total_val / signal_stat->total_num;
}
-void rtl8188e_process_phy_info(struct adapter *padapter, void *prframe)
+static void rtl8188e_process_phy_info(struct adapter *padapter, void *prframe)
{
struct recv_frame *precvframe = (struct recv_frame *)prframe;
diff --git a/drivers/staging/r8188eu/include/rtl8188e_recv.h b/drivers/staging/r8188eu/include/rtl8188e_recv.h
index 8d06815d0374..b752c5c06309 100644
--- a/drivers/staging/r8188eu/include/rtl8188e_recv.h
+++ b/drivers/staging/r8188eu/include/rtl8188e_recv.h
@@ -36,7 +36,6 @@ enum rx_packet_type {
s32 rtl8188eu_init_recv_priv(struct adapter *padapter);
void rtl8188eu_free_recv_priv(struct adapter * padapter);
void rtl8188eu_recv_tasklet(unsigned long priv);
-void rtl8188e_process_phy_info(struct adapter * padapter, void *prframe);
void update_recvframe_phyinfo_88e(struct recv_frame *fra, struct phy_stat *phy);
void update_recvframe_attrib_88e(struct recv_frame *fra, struct recv_stat *stat);
--
2.30.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 5/6] staging: r8188eu: remove some unused local ieee80211 macros
2022-03-05 18:53 [PATCH 0/6] staging: r8188eu: some rx cleanups Martin Kaiser
` (3 preceding siblings ...)
2022-03-05 18:53 ` [PATCH 4/6] staging: r8188eu: make rtl8188e_process_phy_info static Martin Kaiser
@ 2022-03-05 18:53 ` Martin Kaiser
2022-03-05 18:53 ` [PATCH 6/6] staging: r8188eu: remove local BIT macro Martin Kaiser
2022-03-14 17:30 ` [PATCH 0/6] staging: r8188eu: some rx cleanups Greg Kroah-Hartman
6 siblings, 0 replies; 10+ messages in thread
From: Martin Kaiser @ 2022-03-05 18:53 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Larry Finger, Phillip Potter, Michael Straube, linux-staging,
linux-kernel, Martin Kaiser
Remove some macros from wifi.h which are not used by this driver.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/include/wifi.h | 27 --------------------------
1 file changed, 27 deletions(-)
diff --git a/drivers/staging/r8188eu/include/wifi.h b/drivers/staging/r8188eu/include/wifi.h
index c1c9bae58d6d..c331be19ff83 100644
--- a/drivers/staging/r8188eu/include/wifi.h
+++ b/drivers/staging/r8188eu/include/wifi.h
@@ -167,17 +167,11 @@ enum WIFI_REG_DOMAIN {
#define GetToDs(pbuf) (((*(__le16 *)(pbuf)) & cpu_to_le16(_TO_DS_)) != 0)
-#define ClearToDs(pbuf) \
- *(__le16 *)(pbuf) &= (~cpu_to_le16(_TO_DS_))
-
#define SetFrDs(pbuf) \
*(__le16 *)(pbuf) |= cpu_to_le16(_FROM_DS_)
#define GetFrDs(pbuf) (((*(__le16 *)(pbuf)) & cpu_to_le16(_FROM_DS_)) != 0)
-#define ClearFrDs(pbuf) \
- *(__le16 *)(pbuf) &= (~cpu_to_le16(_FROM_DS_))
-
#define get_tofr_ds(pframe) ((GetToDs(pframe) << 1) | GetFrDs(pframe))
#define SetMFrag(pbuf) \
@@ -186,46 +180,25 @@ enum WIFI_REG_DOMAIN {
#define ClearMFrag(pbuf) \
*(__le16 *)(pbuf) &= (~cpu_to_le16(_MORE_FRAG_))
-#define SetRetry(pbuf) \
- *(__le16 *)(pbuf) |= cpu_to_le16(_RETRY_)
-
#define GetRetry(pbuf) (((*(__le16 *)(pbuf)) & cpu_to_le16(_RETRY_)) != 0)
-#define ClearRetry(pbuf) \
- *(__le16 *)(pbuf) &= (~cpu_to_le16(_RETRY_))
-
#define SetPwrMgt(pbuf) \
*(__le16 *)(pbuf) |= cpu_to_le16(_PWRMGT_)
#define GetPwrMgt(pbuf) (((*(__le16 *)(pbuf)) & cpu_to_le16(_PWRMGT_)) != 0)
-#define ClearPwrMgt(pbuf) \
- *(__le16 *)(pbuf) &= (~cpu_to_le16(_PWRMGT_))
-
#define SetMData(pbuf) \
*(__le16 *)(pbuf) |= cpu_to_le16(_MORE_DATA_)
-#define ClearMData(pbuf) \
- *(__le16 *)(pbuf) &= (~cpu_to_le16(_MORE_DATA_))
-
#define SetPrivacy(pbuf) \
*(__le16 *)(pbuf) |= cpu_to_le16(_PRIVACY_)
#define GetPrivacy(pbuf) \
(((*(__le16 *)(pbuf)) & cpu_to_le16(_PRIVACY_)) != 0)
-#define ClearPrivacy(pbuf) \
- *(__le16 *)(pbuf) &= (~cpu_to_le16(_PRIVACY_))
-
#define GetFrameType(pbuf) \
(le16_to_cpu(*(__le16 *)(pbuf)) & (BIT(3) | BIT(2)))
-#define SetFrameType(pbuf, type) \
- do { \
- *(unsigned short *)(pbuf) &= __constant_cpu_to_le16(~(BIT(3) | BIT(2))); \
- *(unsigned short *)(pbuf) |= __constant_cpu_to_le16(type); \
- } while (0)
-
#define GetFrameSubType(pbuf) (le16_to_cpu(*(__le16 *)(pbuf)) & (BIT(7) |\
BIT(6) | BIT(5) | BIT(4) | BIT(3) | BIT(2)))
--
2.30.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 6/6] staging: r8188eu: remove local BIT macro
2022-03-05 18:53 [PATCH 0/6] staging: r8188eu: some rx cleanups Martin Kaiser
` (4 preceding siblings ...)
2022-03-05 18:53 ` [PATCH 5/6] staging: r8188eu: remove some unused local ieee80211 macros Martin Kaiser
@ 2022-03-05 18:53 ` Martin Kaiser
2022-03-14 17:30 ` [PATCH 0/6] staging: r8188eu: some rx cleanups Greg Kroah-Hartman
6 siblings, 0 replies; 10+ messages in thread
From: Martin Kaiser @ 2022-03-05 18:53 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Larry Finger, Phillip Potter, Michael Straube, linux-staging,
linux-kernel, Martin Kaiser
The r8188eu driver defines a local BIT(x) macro. Remove this local macro
and use the one from include/linux/bits.h.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/include/wifi.h | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/r8188eu/include/wifi.h b/drivers/staging/r8188eu/include/wifi.h
index c331be19ff83..299553351246 100644
--- a/drivers/staging/r8188eu/include/wifi.h
+++ b/drivers/staging/r8188eu/include/wifi.h
@@ -4,14 +4,9 @@
#ifndef _WIFI_H_
#define _WIFI_H_
+#include <linux/bits.h>
#include <linux/ieee80211.h>
-#ifdef BIT
-/* error "BIT define occurred earlier elsewhere!\n" */
-#undef BIT
-#endif
-#define BIT(x) (1 << (x))
-
#define WLAN_ETHHDR_LEN 14
#define WLAN_HDR_A3_LEN 24
#define WLAN_HDR_A3_QOS_LEN 26
--
2.30.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 0/6] staging: r8188eu: some rx cleanups
2022-03-05 18:53 [PATCH 0/6] staging: r8188eu: some rx cleanups Martin Kaiser
` (5 preceding siblings ...)
2022-03-05 18:53 ` [PATCH 6/6] staging: r8188eu: remove local BIT macro Martin Kaiser
@ 2022-03-14 17:30 ` Greg Kroah-Hartman
2022-03-15 20:55 ` Martin Kaiser
6 siblings, 1 reply; 10+ messages in thread
From: Greg Kroah-Hartman @ 2022-03-14 17:30 UTC (permalink / raw)
To: Martin Kaiser
Cc: Larry Finger, Phillip Potter, Michael Straube, linux-staging,
linux-kernel
On Sat, Mar 05, 2022 at 07:53:45PM +0100, Martin Kaiser wrote:
> Here's another set with simple cleanups in the code for receiving frames.
>
> Martin Kaiser (6):
> staging: r8188eu: remove unnecessary initializations
> staging: r8188eu: remove three unused receive defines
> staging: r8188eu: remove unused function prototype
> staging: r8188eu: make rtl8188e_process_phy_info static
> staging: r8188eu: remove some unused local ieee80211 macros
> staging: r8188eu: remove local BIT macro
>
> drivers/staging/r8188eu/hal/rtl8188e_rxdesc.c | 6 +---
> .../staging/r8188eu/include/rtl8188e_recv.h | 6 ----
> drivers/staging/r8188eu/include/wifi.h | 34 +------------------
> 3 files changed, 2 insertions(+), 44 deletions(-)
>
> --
> 2.30.2
>
>
This series breaks the build:
drivers/staging/r8188eu/core/rtw_wlan_util.c: In function ‘update_IOT_info’:
drivers/staging/r8188eu/core/rtw_wlan_util.c:1279:42: error: conversion from ‘long unsigned int’ to ‘u32’ {aka ‘unsigned int’} changes value from ‘18446744073709551611’ to ‘4294967291’ [-Werror=overflow]
1279 | Switch_DM_Func(padapter, (~DYNAMIC_BB_DYNAMIC_TXPWR), false);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/staging/r8188eu/core/rtw_wlan_util.c:1285:42: error: conversion from ‘long unsigned int’ to ‘u32’ {aka ‘unsigned int’} changes value from ‘18446744073709551611’ to ‘4294967291’ [-Werror=overflow]
1285 | Switch_DM_Func(padapter, (~DYNAMIC_BB_DYNAMIC_TXPWR), false);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
I'm going to drop it from my queue now.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 0/6] staging: r8188eu: some rx cleanups
2022-03-14 17:30 ` [PATCH 0/6] staging: r8188eu: some rx cleanups Greg Kroah-Hartman
@ 2022-03-15 20:55 ` Martin Kaiser
2022-03-16 6:39 ` Greg Kroah-Hartman
0 siblings, 1 reply; 10+ messages in thread
From: Martin Kaiser @ 2022-03-15 20:55 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Larry Finger, Phillip Potter, Michael Straube, linux-staging,
linux-kernel
Thus wrote Greg Kroah-Hartman (gregkh@linuxfoundation.org):
> On Sat, Mar 05, 2022 at 07:53:45PM +0100, Martin Kaiser wrote:
> > Here's another set with simple cleanups in the code for receiving frames.
> > Martin Kaiser (6):
> > staging: r8188eu: remove unnecessary initializations
> > staging: r8188eu: remove three unused receive defines
> > staging: r8188eu: remove unused function prototype
> > staging: r8188eu: make rtl8188e_process_phy_info static
> > staging: r8188eu: remove some unused local ieee80211 macros
> > staging: r8188eu: remove local BIT macro
> > drivers/staging/r8188eu/hal/rtl8188e_rxdesc.c | 6 +---
> > .../staging/r8188eu/include/rtl8188e_recv.h | 6 ----
> > drivers/staging/r8188eu/include/wifi.h | 34 +------------------
> > 3 files changed, 2 insertions(+), 44 deletions(-)
> > --
> > 2.30.2
> This series breaks the build:
on x86_64 - and I tested only on arm32 :-(
> drivers/staging/r8188eu/core/rtw_wlan_util.c: In function ‘update_IOT_info’:
> drivers/staging/r8188eu/core/rtw_wlan_util.c:1279:42: error: conversion from ‘long unsigned int’ to ‘u32’ {aka ‘unsigned int’} changes value from ‘18446744073709551611’ to ‘4294967291’ [-Werror=overflow]
> 1279 | Switch_DM_Func(padapter, (~DYNAMIC_BB_DYNAMIC_TXPWR), false);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/staging/r8188eu/core/rtw_wlan_util.c:1285:42: error: conversion from ‘long unsigned int’ to ‘u32’ {aka ‘unsigned int’} changes value from ‘18446744073709551611’ to ‘4294967291’ [-Werror=overflow]
> 1285 | Switch_DM_Func(padapter, (~DYNAMIC_BB_DYNAMIC_TXPWR), false);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> I'm going to drop it from my queue now.
The driver's BIT(x) macro was 1 << (x), the "global" one uses 1UL << (x).
DYNAMIC_BB_DYNAMIC_TXPWR needs a cast to u32. I've just sent v2.
Thanks,
Martin
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 0/6] staging: r8188eu: some rx cleanups
2022-03-15 20:55 ` Martin Kaiser
@ 2022-03-16 6:39 ` Greg Kroah-Hartman
0 siblings, 0 replies; 10+ messages in thread
From: Greg Kroah-Hartman @ 2022-03-16 6:39 UTC (permalink / raw)
To: Martin Kaiser
Cc: Larry Finger, Phillip Potter, Michael Straube, linux-staging,
linux-kernel
On Tue, Mar 15, 2022 at 09:55:28PM +0100, Martin Kaiser wrote:
> Thus wrote Greg Kroah-Hartman (gregkh@linuxfoundation.org):
>
> > On Sat, Mar 05, 2022 at 07:53:45PM +0100, Martin Kaiser wrote:
> > > Here's another set with simple cleanups in the code for receiving frames.
>
> > > Martin Kaiser (6):
> > > staging: r8188eu: remove unnecessary initializations
> > > staging: r8188eu: remove three unused receive defines
> > > staging: r8188eu: remove unused function prototype
> > > staging: r8188eu: make rtl8188e_process_phy_info static
> > > staging: r8188eu: remove some unused local ieee80211 macros
> > > staging: r8188eu: remove local BIT macro
>
> > > drivers/staging/r8188eu/hal/rtl8188e_rxdesc.c | 6 +---
> > > .../staging/r8188eu/include/rtl8188e_recv.h | 6 ----
> > > drivers/staging/r8188eu/include/wifi.h | 34 +------------------
> > > 3 files changed, 2 insertions(+), 44 deletions(-)
>
> > > --
> > > 2.30.2
>
>
>
> > This series breaks the build:
>
> on x86_64 - and I tested only on arm32 :-(
>
> > drivers/staging/r8188eu/core/rtw_wlan_util.c: In function ‘update_IOT_info’:
> > drivers/staging/r8188eu/core/rtw_wlan_util.c:1279:42: error: conversion from ‘long unsigned int’ to ‘u32’ {aka ‘unsigned int’} changes value from ‘18446744073709551611’ to ‘4294967291’ [-Werror=overflow]
> > 1279 | Switch_DM_Func(padapter, (~DYNAMIC_BB_DYNAMIC_TXPWR), false);
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/staging/r8188eu/core/rtw_wlan_util.c:1285:42: error: conversion from ‘long unsigned int’ to ‘u32’ {aka ‘unsigned int’} changes value from ‘18446744073709551611’ to ‘4294967291’ [-Werror=overflow]
> > 1285 | Switch_DM_Func(padapter, (~DYNAMIC_BB_DYNAMIC_TXPWR), false);
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
>
> > I'm going to drop it from my queue now.
>
> The driver's BIT(x) macro was 1 << (x), the "global" one uses 1UL << (x).
> DYNAMIC_BB_DYNAMIC_TXPWR needs a cast to u32. I've just sent v2.
There shouldn't need to be a cast when using the BIT macro, so be
careful...
^ permalink raw reply [flat|nested] 10+ messages in thread