* [PATCH] ACPI: APEI: fix return value of __setup handlers
@ 2022-03-06 2:46 Randy Dunlap
2022-03-07 1:51 ` Huang, Ying
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2022-03-06 2:46 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Igor Zhbanov, Huang Ying, Rafael J. Wysocki,
Len Brown, linux-acpi, James Morse, Tony Luck, Borislav Petkov
__setup() handlers should return 1 to indicate that the boot option
has been handled. Returning 0 causes a boot option to be listed in
the Unknown kernel command line parameters and also added to init's
arg list (if no '=' sign) or environment list (if of the form 'a=b').
Unknown kernel command line parameters "erst_disable
bert_disable hest_disable BOOT_IMAGE=/boot/bzImage-517rc6", will be
passed to user space.
Run /sbin/init as init process
with arguments:
/sbin/init
erst_disable
bert_disable
hest_disable
with environment:
HOME=/
TERM=linux
BOOT_IMAGE=/boot/bzImage-517rc6
Fixes: a3e2acc5e37b ("ACPI / APEI: Add Boot Error Record Table (BERT) support")
Fixes: a08f82d08053 ("ACPI, APEI, Error Record Serialization Table (ERST) support")
Fixes: 9dc966641677 ("ACPI, APEI, HEST table parsing")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Igor Zhbanov <i.zhbanov@omprussia.ru>
Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru
Cc: Huang Ying <ying.huang@intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org
Cc: James Morse <james.morse@arm.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Borislav Petkov <bp@alien8.de>
---
drivers/acpi/apei/bert.c | 2 +-
drivers/acpi/apei/erst.c | 2 +-
drivers/acpi/apei/hest.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
--- lnx-517-rc6.orig/drivers/acpi/apei/bert.c
+++ lnx-517-rc6/drivers/acpi/apei/bert.c
@@ -77,7 +77,7 @@ static int __init setup_bert_disable(cha
{
bert_disable = 1;
- return 0;
+ return 1;
}
__setup("bert_disable", setup_bert_disable);
--- lnx-517-rc6.orig/drivers/acpi/apei/erst.c
+++ lnx-517-rc6/drivers/acpi/apei/erst.c
@@ -891,7 +891,7 @@ EXPORT_SYMBOL_GPL(erst_clear);
static int __init setup_erst_disable(char *str)
{
erst_disable = 1;
- return 0;
+ return 1;
}
__setup("erst_disable", setup_erst_disable);
--- lnx-517-rc6.orig/drivers/acpi/apei/hest.c
+++ lnx-517-rc6/drivers/acpi/apei/hest.c
@@ -224,7 +224,7 @@ err:
static int __init setup_hest_disable(char *str)
{
hest_disable = HEST_DISABLED;
- return 0;
+ return 1;
}
__setup("hest_disable", setup_hest_disable);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ACPI: APEI: fix return value of __setup handlers
2022-03-06 2:46 [PATCH] ACPI: APEI: fix return value of __setup handlers Randy Dunlap
@ 2022-03-07 1:51 ` Huang, Ying
2022-03-08 18:45 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Huang, Ying @ 2022-03-07 1:51 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Igor Zhbanov, Rafael J. Wysocki, Len Brown,
linux-acpi, James Morse, Tony Luck, Borislav Petkov
Randy Dunlap <rdunlap@infradead.org> writes:
> __setup() handlers should return 1 to indicate that the boot option
> has been handled. Returning 0 causes a boot option to be listed in
> the Unknown kernel command line parameters and also added to init's
> arg list (if no '=' sign) or environment list (if of the form 'a=b').
>
> Unknown kernel command line parameters "erst_disable
> bert_disable hest_disable BOOT_IMAGE=/boot/bzImage-517rc6", will be
> passed to user space.
>
> Run /sbin/init as init process
> with arguments:
> /sbin/init
> erst_disable
> bert_disable
> hest_disable
> with environment:
> HOME=/
> TERM=linux
> BOOT_IMAGE=/boot/bzImage-517rc6
>
> Fixes: a3e2acc5e37b ("ACPI / APEI: Add Boot Error Record Table (BERT) support")
> Fixes: a08f82d08053 ("ACPI, APEI, Error Record Serialization Table (ERST) support")
> Fixes: 9dc966641677 ("ACPI, APEI, HEST table parsing")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Good catch! Thanks for fixing!
Reviewed-by: "Huang, Ying" <ying.huang@intel.com>
Best Regards,
Huang, Ying
> Reported-by: Igor Zhbanov <i.zhbanov@omprussia.ru>
> Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru
> Cc: Huang Ying <ying.huang@intel.com>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: Len Brown <lenb@kernel.org>
> Cc: linux-acpi@vger.kernel.org
> Cc: James Morse <james.morse@arm.com>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Borislav Petkov <bp@alien8.de>
> ---
> drivers/acpi/apei/bert.c | 2 +-
> drivers/acpi/apei/erst.c | 2 +-
> drivers/acpi/apei/hest.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> --- lnx-517-rc6.orig/drivers/acpi/apei/bert.c
> +++ lnx-517-rc6/drivers/acpi/apei/bert.c
> @@ -77,7 +77,7 @@ static int __init setup_bert_disable(cha
> {
> bert_disable = 1;
>
> - return 0;
> + return 1;
> }
> __setup("bert_disable", setup_bert_disable);
>
> --- lnx-517-rc6.orig/drivers/acpi/apei/erst.c
> +++ lnx-517-rc6/drivers/acpi/apei/erst.c
> @@ -891,7 +891,7 @@ EXPORT_SYMBOL_GPL(erst_clear);
> static int __init setup_erst_disable(char *str)
> {
> erst_disable = 1;
> - return 0;
> + return 1;
> }
>
> __setup("erst_disable", setup_erst_disable);
> --- lnx-517-rc6.orig/drivers/acpi/apei/hest.c
> +++ lnx-517-rc6/drivers/acpi/apei/hest.c
> @@ -224,7 +224,7 @@ err:
> static int __init setup_hest_disable(char *str)
> {
> hest_disable = HEST_DISABLED;
> - return 0;
> + return 1;
> }
>
> __setup("hest_disable", setup_hest_disable);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ACPI: APEI: fix return value of __setup handlers
2022-03-07 1:51 ` Huang, Ying
@ 2022-03-08 18:45 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2022-03-08 18:45 UTC (permalink / raw)
To: Huang, Ying, Randy Dunlap
Cc: Linux Kernel Mailing List, Igor Zhbanov, Rafael J. Wysocki,
Len Brown, ACPI Devel Maling List, James Morse, Tony Luck,
Borislav Petkov
On Mon, Mar 7, 2022 at 2:51 AM Huang, Ying <ying.huang@intel.com> wrote:
>
> Randy Dunlap <rdunlap@infradead.org> writes:
>
> > __setup() handlers should return 1 to indicate that the boot option
> > has been handled. Returning 0 causes a boot option to be listed in
> > the Unknown kernel command line parameters and also added to init's
> > arg list (if no '=' sign) or environment list (if of the form 'a=b').
> >
> > Unknown kernel command line parameters "erst_disable
> > bert_disable hest_disable BOOT_IMAGE=/boot/bzImage-517rc6", will be
> > passed to user space.
> >
> > Run /sbin/init as init process
> > with arguments:
> > /sbin/init
> > erst_disable
> > bert_disable
> > hest_disable
> > with environment:
> > HOME=/
> > TERM=linux
> > BOOT_IMAGE=/boot/bzImage-517rc6
> >
> > Fixes: a3e2acc5e37b ("ACPI / APEI: Add Boot Error Record Table (BERT) support")
> > Fixes: a08f82d08053 ("ACPI, APEI, Error Record Serialization Table (ERST) support")
> > Fixes: 9dc966641677 ("ACPI, APEI, HEST table parsing")
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>
> Good catch! Thanks for fixing!
>
> Reviewed-by: "Huang, Ying" <ying.huang@intel.com>
Applied as 5.18 material, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-08 18:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-06 2:46 [PATCH] ACPI: APEI: fix return value of __setup handlers Randy Dunlap
2022-03-07 1:51 ` Huang, Ying
2022-03-08 18:45 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).