* [PATCH v2] bonding: helper macro __ATTR_RO to make code more clear
@ 2022-03-07 1:33 Lianjie Zhang
2022-03-08 21:25 ` Jay Vosburgh
0 siblings, 1 reply; 2+ messages in thread
From: Lianjie Zhang @ 2022-03-07 1:33 UTC (permalink / raw)
To: Jakub Kicinski
Cc: David S. Miller, Jay Vosburgh, Veaceslav Falico, Andy Gospodarek,
netdev, linux-kernel, zhanglianjie, Jay Vosburgh
From: zhanglianjie <zhanglianjie@uniontech.com>
Delete SLAVE_ATTR macro, use __ATTR_RO replacement,
make code logic clearer and unified.
Signed-off-by: Lianjie Zhang <zhanglianjie@uniontech.com>
Reviewed-by: Jay Vosburgh <jay.vosburgh@canonical.com>
diff --git a/drivers/net/bonding/bond_sysfs_slave.c b/drivers/net/bonding/bond_sysfs_slave.c
index 6a6cdd0bb258..69b0a3751dff 100644
--- a/drivers/net/bonding/bond_sysfs_slave.c
+++ b/drivers/net/bonding/bond_sysfs_slave.c
@@ -15,14 +15,8 @@ struct slave_attribute {
ssize_t (*show)(struct slave *, char *);
};
-#define SLAVE_ATTR(_name, _mode, _show) \
-const struct slave_attribute slave_attr_##_name = { \
- .attr = {.name = __stringify(_name), \
- .mode = _mode }, \
- .show = _show, \
-};
#define SLAVE_ATTR_RO(_name) \
- SLAVE_ATTR(_name, 0444, _name##_show)
+const struct slave_attribute slave_attr_##_name = __ATTR_RO(_name)
static ssize_t state_show(struct slave *slave, char *buf)
{
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] bonding: helper macro __ATTR_RO to make code more clear
2022-03-07 1:33 [PATCH v2] bonding: helper macro __ATTR_RO to make code more clear Lianjie Zhang
@ 2022-03-08 21:25 ` Jay Vosburgh
0 siblings, 0 replies; 2+ messages in thread
From: Jay Vosburgh @ 2022-03-08 21:25 UTC (permalink / raw)
To: Lianjie Zhang
Cc: Jakub Kicinski, David S. Miller, Veaceslav Falico,
Andy Gospodarek, netdev, linux-kernel
Lianjie Zhang <zhanglianjie@uniontech.com> wrote:
>From: zhanglianjie <zhanglianjie@uniontech.com>
>
>Delete SLAVE_ATTR macro, use __ATTR_RO replacement,
>make code logic clearer and unified.
>
>Signed-off-by: Lianjie Zhang <zhanglianjie@uniontech.com>
>Reviewed-by: Jay Vosburgh <jay.vosburgh@canonical.com>
Please do not add tags that individuals do not explicitly
provide.
Other than the above, the change seems fine.
Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>
-J
>diff --git a/drivers/net/bonding/bond_sysfs_slave.c b/drivers/net/bonding/bond_sysfs_slave.c
>index 6a6cdd0bb258..69b0a3751dff 100644
>--- a/drivers/net/bonding/bond_sysfs_slave.c
>+++ b/drivers/net/bonding/bond_sysfs_slave.c
>@@ -15,14 +15,8 @@ struct slave_attribute {
> ssize_t (*show)(struct slave *, char *);
> };
>
>-#define SLAVE_ATTR(_name, _mode, _show) \
>-const struct slave_attribute slave_attr_##_name = { \
>- .attr = {.name = __stringify(_name), \
>- .mode = _mode }, \
>- .show = _show, \
>-};
> #define SLAVE_ATTR_RO(_name) \
>- SLAVE_ATTR(_name, 0444, _name##_show)
>+const struct slave_attribute slave_attr_##_name = __ATTR_RO(_name)
>
> static ssize_t state_show(struct slave *slave, char *buf)
> {
>--
>2.20.1
---
-Jay Vosburgh, jay.vosburgh@canonical.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-08 21:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-07 1:33 [PATCH v2] bonding: helper macro __ATTR_RO to make code more clear Lianjie Zhang
2022-03-08 21:25 ` Jay Vosburgh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).