* Re: [PATCH vfio-next] PCI/IOV: Fix wrong kernel-doc identifier
2022-03-07 11:33 [PATCH vfio-next] PCI/IOV: Fix wrong kernel-doc identifier Leon Romanovsky
@ 2022-03-07 15:32 ` Alex Williamson
2022-03-07 16:22 ` Randy Dunlap
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Alex Williamson @ 2022-03-07 15:32 UTC (permalink / raw)
To: Leon Romanovsky, Bjorn Helgaas
Cc: Leon Romanovsky, Jason Gunthorpe, Yishai Hadas,
Linux Kernel Mailing List, Linux Next Mailing List,
Stephen Rothwell, linux-pci, kvm
On Mon, 7 Mar 2022 13:33:25 +0200
Leon Romanovsky <leon@kernel.org> wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> Replace "-" to be ":" in comment section to be aligned with
> kernel-doc format.
>
> drivers/pci/iov.c:67: warning: Function parameter or member 'dev' not described in 'pci_iov_get_pf_drvdata'
> drivers/pci/iov.c:67: warning: Function parameter or member 'pf_driver' not described in 'pci_iov_get_pf_drvdata'
>
> Fixes: a7e9f240c0da ("PCI/IOV: Add pci_iov_get_pf_drvdata() to allow VF reaching the drvdata of a PF")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> drivers/pci/iov.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
> index 28ec952e1221..952217572113 100644
> --- a/drivers/pci/iov.c
> +++ b/drivers/pci/iov.c
> @@ -49,8 +49,8 @@ EXPORT_SYMBOL_GPL(pci_iov_vf_id);
>
> /**
> * pci_iov_get_pf_drvdata - Return the drvdata of a PF
> - * @dev - VF pci_dev
> - * @pf_driver - Device driver required to own the PF
> + * @dev: VF pci_dev
> + * @pf_driver: Device driver required to own the PF
> *
> * This must be called from a context that ensures that a VF driver is attached.
> * The value returned is invalid once the VF driver completes its remove()
Bjorn,
I'll be happy to grab this with your ack since the referenced commit is
coming from my branch. Thanks,
Alex
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH vfio-next] PCI/IOV: Fix wrong kernel-doc identifier
2022-03-07 11:33 [PATCH vfio-next] PCI/IOV: Fix wrong kernel-doc identifier Leon Romanovsky
2022-03-07 15:32 ` Alex Williamson
@ 2022-03-07 16:22 ` Randy Dunlap
2022-03-07 17:58 ` Bjorn Helgaas
2022-03-07 19:11 ` Alex Williamson
3 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2022-03-07 16:22 UTC (permalink / raw)
To: Leon Romanovsky, Alex Williamson
Cc: Leon Romanovsky, Jason Gunthorpe, Yishai Hadas,
Linux Kernel Mailing List, Linux Next Mailing List,
Stephen Rothwell, linux-pci, kvm
On 3/7/22 03:33, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> Replace "-" to be ":" in comment section to be aligned with
> kernel-doc format.
>
> drivers/pci/iov.c:67: warning: Function parameter or member 'dev' not described in 'pci_iov_get_pf_drvdata'
> drivers/pci/iov.c:67: warning: Function parameter or member 'pf_driver' not described in 'pci_iov_get_pf_drvdata'
>
> Fixes: a7e9f240c0da ("PCI/IOV: Add pci_iov_get_pf_drvdata() to allow VF reaching the drvdata of a PF")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/pci/iov.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
> index 28ec952e1221..952217572113 100644
> --- a/drivers/pci/iov.c
> +++ b/drivers/pci/iov.c
> @@ -49,8 +49,8 @@ EXPORT_SYMBOL_GPL(pci_iov_vf_id);
>
> /**
> * pci_iov_get_pf_drvdata - Return the drvdata of a PF
> - * @dev - VF pci_dev
> - * @pf_driver - Device driver required to own the PF
> + * @dev: VF pci_dev
> + * @pf_driver: Device driver required to own the PF
> *
> * This must be called from a context that ensures that a VF driver is attached.
> * The value returned is invalid once the VF driver completes its remove()
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH vfio-next] PCI/IOV: Fix wrong kernel-doc identifier
2022-03-07 11:33 [PATCH vfio-next] PCI/IOV: Fix wrong kernel-doc identifier Leon Romanovsky
2022-03-07 15:32 ` Alex Williamson
2022-03-07 16:22 ` Randy Dunlap
@ 2022-03-07 17:58 ` Bjorn Helgaas
2022-03-07 19:11 ` Alex Williamson
3 siblings, 0 replies; 5+ messages in thread
From: Bjorn Helgaas @ 2022-03-07 17:58 UTC (permalink / raw)
To: Leon Romanovsky
Cc: Alex Williamson, Leon Romanovsky, Jason Gunthorpe, Yishai Hadas,
Linux Kernel Mailing List, Linux Next Mailing List,
Stephen Rothwell, linux-pci, kvm
On Mon, Mar 07, 2022 at 01:33:25PM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> Replace "-" to be ":" in comment section to be aligned with
> kernel-doc format.
>
> drivers/pci/iov.c:67: warning: Function parameter or member 'dev' not described in 'pci_iov_get_pf_drvdata'
> drivers/pci/iov.c:67: warning: Function parameter or member 'pf_driver' not described in 'pci_iov_get_pf_drvdata'
>
> Fixes: a7e9f240c0da ("PCI/IOV: Add pci_iov_get_pf_drvdata() to allow VF reaching the drvdata of a PF")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> drivers/pci/iov.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
> index 28ec952e1221..952217572113 100644
> --- a/drivers/pci/iov.c
> +++ b/drivers/pci/iov.c
> @@ -49,8 +49,8 @@ EXPORT_SYMBOL_GPL(pci_iov_vf_id);
>
> /**
> * pci_iov_get_pf_drvdata - Return the drvdata of a PF
> - * @dev - VF pci_dev
> - * @pf_driver - Device driver required to own the PF
> + * @dev: VF pci_dev
> + * @pf_driver: Device driver required to own the PF
> *
> * This must be called from a context that ensures that a VF driver is attached.
> * The value returned is invalid once the VF driver completes its remove()
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH vfio-next] PCI/IOV: Fix wrong kernel-doc identifier
2022-03-07 11:33 [PATCH vfio-next] PCI/IOV: Fix wrong kernel-doc identifier Leon Romanovsky
` (2 preceding siblings ...)
2022-03-07 17:58 ` Bjorn Helgaas
@ 2022-03-07 19:11 ` Alex Williamson
3 siblings, 0 replies; 5+ messages in thread
From: Alex Williamson @ 2022-03-07 19:11 UTC (permalink / raw)
To: Leon Romanovsky
Cc: Leon Romanovsky, Jason Gunthorpe, Yishai Hadas,
Linux Kernel Mailing List, Linux Next Mailing List,
Stephen Rothwell, linux-pci, kvm
On Mon, 7 Mar 2022 13:33:25 +0200
Leon Romanovsky <leon@kernel.org> wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> Replace "-" to be ":" in comment section to be aligned with
> kernel-doc format.
>
> drivers/pci/iov.c:67: warning: Function parameter or member 'dev' not described in 'pci_iov_get_pf_drvdata'
> drivers/pci/iov.c:67: warning: Function parameter or member 'pf_driver' not described in 'pci_iov_get_pf_drvdata'
>
> Fixes: a7e9f240c0da ("PCI/IOV: Add pci_iov_get_pf_drvdata() to allow VF reaching the drvdata of a PF")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> drivers/pci/iov.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
> index 28ec952e1221..952217572113 100644
> --- a/drivers/pci/iov.c
> +++ b/drivers/pci/iov.c
> @@ -49,8 +49,8 @@ EXPORT_SYMBOL_GPL(pci_iov_vf_id);
>
> /**
> * pci_iov_get_pf_drvdata - Return the drvdata of a PF
> - * @dev - VF pci_dev
> - * @pf_driver - Device driver required to own the PF
> + * @dev: VF pci_dev
> + * @pf_driver: Device driver required to own the PF
> *
> * This must be called from a context that ensures that a VF driver is attached.
> * The value returned is invalid once the VF driver completes its remove()
Applied to vfio next branch for v5.18 with acks from Randy and Bjorn.
Thanks,
Alex
^ permalink raw reply [flat|nested] 5+ messages in thread