From: Shuai Xue <xueshuai@linux.alibaba.com>
To: bp@alien8.de, rric@kernel.org
Cc: mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com,
ardb@kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
xueshuai@linux.alibaba.com, zhangliguang@linux.alibaba.com,
zhuo.song@linux.alibaba.com
Subject: [PATCH v7 0/3] EDAC/ghes: refactor memory error reporting to avoid code duplication
Date: Tue, 8 Mar 2022 22:40:50 +0800 [thread overview]
Message-ID: <20220308144053.49090-1-xueshuai@linux.alibaba.com> (raw)
In-Reply-To: <20211210134019.28536-1-xueshuai@linux.alibaba.com>
ghes_edac_report_mem_error() in ghes_edac.c is a Long Method and have
Duplicated Code with cper_mem_err_location(), cper_dimm_err_location(), and
cper_mem_err_type_str() in drivers/firmware/efi/cper.c. In addition, the
cper_print_mem() in drivers/firmware/efi/cper.c only reports the error
status and misses its description.
This patch set is to refactor ghes_edac_report_mem_error with:
- Patch 01 is to wrap up error status decoding logics and reuse it in
cper_print_mem().
- Patch 02 is to introduces cper_*(), into ghes_edac_report_mem_error(),
this can avoid bunch of duplicate code lines;
- Patch 03 is to improve report format
Changes since v6:
- Rework patch 02 by Borislav Petkov
- add patch 03 to improve format
- Link: https://lore.kernel.org/r/20220303122626.99740-3-xueshuai@linux.alibaba.com
Changes since v5:
- Delete change summary in commit log
- Link: https://lore.kernel.org/all/20220126081702.55167-1-xueshuai@linux.alibaba.com/
- Thanks Borislav Petkov for review comments.
Changes since v4:
- Fix alignment and format problem
- Link: https://lore.kernel.org/all/20220125024939.30635-1-xueshuai@linux.alibaba.com/
Changes since v3:
- make cper_mem_err_status_str table a lot more compact
- Fix alignment and format problem
- Link: https://lore.kernel.org/all/20220124024759.19176-1-xueshuai@linux.alibaba.com/
Changes since v2:
- delete the unified patch
- adjusted the order of patches
- Link: https://lore.kernel.org/all/20211210134019.28536-1-xueshuai@linux.alibaba.com/
Changes since v1:
- add a new patch to unify ghes and cper before removing duplication.
- document the changes in patch description
- add EXPORT_SYMBOL_GPL()s for cper_*()
- document and the dependency and add UEFI_CPER dependency explicitly
- Link: https://lore.kernel.org/all/20211207031905.61906-2-xueshuai@linux.alibaba.com/
Shuai Xue (3):
efi/cper: add cper_mem_err_status_str to decode error description
EDAC/ghes: Unify CPER memory error location reporting
efi/cper: reformat CPER memory error location to more readable
drivers/edac/Kconfig | 1 +
drivers/edac/ghes_edac.c | 200 +++++++-----------------------------
drivers/firmware/efi/cper.c | 64 ++++++++----
include/linux/cper.h | 3 +
4 files changed, 87 insertions(+), 181 deletions(-)
--
2.20.1.12.g72788fdb
next prev parent reply other threads:[~2022-03-08 14:41 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 13:40 [PATCH v2 0/3] ghes_edac: refactor memory error reporting to avoid code duplication Shuai Xue
2021-12-10 13:40 ` [PATCH v2 1/3] ghes_edac: unify memory error report format with cper Shuai Xue
2021-12-28 17:12 ` Borislav Petkov
2021-12-29 3:22 ` Shuai Xue
2021-12-30 17:57 ` Borislav Petkov
2021-12-31 3:04 ` Shuai Xue
2021-12-10 13:40 ` [PATCH v2 2/3] ghes_edac: refactor memory error location processing Shuai Xue
2021-12-10 13:40 ` [PATCH v2 3/3] ghes_edac: refactor error status fields decoding Shuai Xue
2021-12-16 12:54 ` [PATCH v2 0/3] ghes_edac: refactor memory error reporting to avoid code duplication Shuai Xue
2022-01-16 7:36 ` [PATCH v3 0/2] EDAC/ghes: refactor memory error reporting to avoid Shuai Xue
2022-01-16 7:36 ` [PATCH v3 1/2] efi/cper: add cper_mem_err_status_str to decode error description Shuai Xue
2022-01-16 7:36 ` [PATCH v3 2/2] EDAC/ghes: use cper functions to avoid code duplication Shuai Xue
2022-01-24 2:47 ` [RESEND PATCH v3 0/2] EDAC/ghes: refactor memory error reporting to avoid Shuai Xue
2022-01-24 2:47 ` [RESEND PATCH v3 1/2] efi/cper: add cper_mem_err_status_str to decode error description Shuai Xue
2022-01-24 21:16 ` Borislav Petkov
2022-01-25 2:45 ` Shuai Xue
2022-01-25 10:21 ` Borislav Petkov
2022-01-25 11:49 ` Shuai Xue
2022-01-25 12:37 ` Borislav Petkov
2022-01-25 15:02 ` Shuai Xue
2022-01-24 2:47 ` [RESEND PATCH v3 2/2] EDAC/ghes: use cper functions to avoid code duplication Shuai Xue
2022-01-25 2:49 ` [PATCH v4 0/2] EDAC/ghes: refactor memory error reporting " Shuai Xue
2022-01-25 2:49 ` [PATCH v4 1/2] efi/cper: add cper_mem_err_status_str to decode error description Shuai Xue
2022-01-25 19:08 ` Borislav Petkov
2022-01-26 5:25 ` Shuai Xue
2022-01-25 2:49 ` [PATCH v4 2/2] EDAC/ghes: use cper functions to avoid code duplication Shuai Xue
2022-01-26 8:17 ` [PATCH v5 0/2] EDAC/ghes: refactor memory error reporting " Shuai Xue
2022-01-26 8:20 ` Borislav Petkov
2022-01-26 9:26 ` Shuai Xue
2022-01-26 10:16 ` Boris Petkov
2022-01-27 2:28 ` Shuai Xue
2022-01-26 8:17 ` [PATCH v5 1/2] efi/cper: add cper_mem_err_status_str to decode error description Shuai Xue
2022-01-26 8:17 ` [PATCH v5 2/2] EDAC/ghes: use cper functions to avoid code duplication Shuai Xue
2022-01-29 13:09 ` Borislav Petkov
2022-02-12 11:28 ` Shuai Xue
2022-03-03 12:26 ` [PATCH v6 0/2] EDAC/ghes: refactor memory error reporting " Shuai Xue
2022-03-03 12:26 ` [PATCH v6 1/2] efi/cper: add cper_mem_err_status_str to decode error description Shuai Xue
2022-03-03 12:26 ` [PATCH v6 2/2] EDAC/ghes: use cper functions to avoid code duplication Shuai Xue
2022-03-04 10:16 ` Borislav Petkov
2022-03-07 6:16 ` Shuai Xue
2022-03-07 7:08 ` Borislav Petkov
2022-03-08 14:40 ` Shuai Xue [this message]
2022-03-22 6:09 ` [PATCH v7 0/3] EDAC/ghes: refactor memory error reporting " Shuai Xue
2022-04-01 6:20 ` Shuai Xue
2022-04-08 15:53 ` Borislav Petkov
2022-03-08 14:40 ` [PATCH v7 1/3] efi/cper: add cper_mem_err_status_str to decode error description Shuai Xue
2022-04-01 20:44 ` Borislav Petkov
2022-04-06 21:37 ` Ard Biesheuvel
2022-03-08 14:40 ` [PATCH v7 2/3] EDAC/ghes: Unify CPER memory error location reporting Shuai Xue
2022-03-08 14:40 ` [PATCH v7 3/3] efi/cper: reformat CPER memory error location to more readable Shuai Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220308144053.49090-1-xueshuai@linux.alibaba.com \
--to=xueshuai@linux.alibaba.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=zhangliguang@linux.alibaba.com \
--cc=zhuo.song@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).