* [PATCH] clk: imx: remove redundant re-assignment of pll->base
@ 2022-03-03 9:05 Colin Ian King
2022-03-09 18:39 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2022-03-03 9:05 UTC (permalink / raw)
To: Abel Vesa, Michael Turquette, Stephen Boyd, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, linux-clk, linux-arm-kernel
Cc: kernel-janitors, linux-kernel
There are two identical assignments of pll->base to the same value,
the second assignment is redundant and can be removed.
Cleans up cppcheck warning:
drivers/clk/imx/clk-sscg-pll.c:528:12: style: Variable 'pll->base' is
reassigned a value before the old one has been used. [redundantAssignment]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/clk/imx/clk-sscg-pll.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clk/imx/clk-sscg-pll.c b/drivers/clk/imx/clk-sscg-pll.c
index 9d6cdff0537f..81f304fae908 100644
--- a/drivers/clk/imx/clk-sscg-pll.c
+++ b/drivers/clk/imx/clk-sscg-pll.c
@@ -525,7 +525,6 @@ struct clk_hw *imx_clk_hw_sscg_pll(const char *name,
init.parent_names = parent_names;
init.num_parents = num_parents;
- pll->base = base;
pll->hw.init = &init;
hw = &pll->hw;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: imx: remove redundant re-assignment of pll->base
2022-03-03 9:05 [PATCH] clk: imx: remove redundant re-assignment of pll->base Colin Ian King
@ 2022-03-09 18:39 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2022-03-09 18:39 UTC (permalink / raw)
To: Abel Vesa, Colin Ian King, Fabio Estevam, Michael Turquette,
NXP Linux Team, Pengutronix Kernel Team, Sascha Hauer, Shawn Guo,
linux-arm-kernel, linux-clk
Cc: kernel-janitors, linux-kernel
Quoting Colin Ian King (2022-03-03 01:05:08)
> There are two identical assignments of pll->base to the same value,
> the second assignment is redundant and can be removed.
>
> Cleans up cppcheck warning:
> drivers/clk/imx/clk-sscg-pll.c:528:12: style: Variable 'pll->base' is
> reassigned a value before the old one has been used. [redundantAssignment]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-09 18:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-03 9:05 [PATCH] clk: imx: remove redundant re-assignment of pll->base Colin Ian King
2022-03-09 18:39 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).