* [PATCH] media: platform: mtk-vcodec: fix platform_get_irq.cocci warning
@ 2022-03-10 2:36 Yihao Han
2022-03-10 3:18 ` Miles Chen
0 siblings, 1 reply; 2+ messages in thread
From: Yihao Han @ 2022-03-10 2:36 UTC (permalink / raw)
To: Tiffany Lin, Andrew-CT Chen, Mauro Carvalho Chehab,
Matthias Brugger, linux-media, linux-arm-kernel, linux-mediatek,
linux-kernel
Cc: kernel, Yihao Han
Remove dev_err() messages after platform_get_irq*() failures.
platform_get_irq() already prints an error.
Generated by: scripts/coccinelle/api/platform_get_irq.cocci
Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c
index 48dad9bb13d2..df7b25e9cbc8 100644
--- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c
+++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c
@@ -115,10 +115,8 @@ static int mtk_vcodec_init_dec_resources(struct mtk_vcodec_dev *dev)
return 0;
dev->dec_irq = platform_get_irq(pdev, 0);
- if (dev->dec_irq < 0) {
- dev_err(&pdev->dev, "failed to get irq number");
+ if (dev->dec_irq < 0)
return dev->dec_irq;
- }
irq_set_status_flags(dev->dec_irq, IRQ_NOAUTOEN);
ret = devm_request_irq(&pdev->dev, dev->dec_irq,
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: platform: mtk-vcodec: fix platform_get_irq.cocci warning
2022-03-10 2:36 [PATCH] media: platform: mtk-vcodec: fix platform_get_irq.cocci warning Yihao Han
@ 2022-03-10 3:18 ` Miles Chen
0 siblings, 0 replies; 2+ messages in thread
From: Miles Chen @ 2022-03-10 3:18 UTC (permalink / raw)
To: hanyihao
Cc: andrew-ct.chen, kernel, linux-arm-kernel, linux-kernel,
linux-media, linux-mediatek, matthias.bgg, mchehab, tiffany.lin
Hi Yihao,
> Remove dev_err() messages after platform_get_irq*() failures.
> platform_get_irq() already prints an error.
>
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
>
> Signed-off-by: Yihao Han <hanyihao@vivo.com>
Thanks for the patch.
Reviewed-by: Miles Chen <miles.chen@mediatek.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-10 3:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-10 2:36 [PATCH] media: platform: mtk-vcodec: fix platform_get_irq.cocci warning Yihao Han
2022-03-10 3:18 ` Miles Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).