linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: extcon: maxim,max77843: fix ports type
@ 2022-03-10  7:32 Krzysztof Kozlowski
  2022-03-10 23:25 ` Rob Herring
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-10  7:32 UTC (permalink / raw)
  To: Chanwoo Choi, Krzysztof Kozlowski, MyungJoo Ham, Rob Herring,
	Lee Jones, linux-kernel, devicetree
  Cc: Rob Herring

The "ports" property can contain multiple ports as name suggests, so it
should be using "ports" type from device graphs.

Reported-by: Rob Herring <robh@kernel.org>
Fixes: 9729cad0278b ("dt-bindings: extcon: maxim,max77843: Add MAX77843 bindings")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

---

Hi Lee,

This is a fix for a commit in your next branch.
---
 Documentation/devicetree/bindings/extcon/maxim,max77843.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/extcon/maxim,max77843.yaml b/Documentation/devicetree/bindings/extcon/maxim,max77843.yaml
index f9ffe3d6f957..0216ec868c3e 100644
--- a/Documentation/devicetree/bindings/extcon/maxim,max77843.yaml
+++ b/Documentation/devicetree/bindings/extcon/maxim,max77843.yaml
@@ -25,7 +25,7 @@ properties:
     $ref: /schemas/connector/usb-connector.yaml#
 
   ports:
-    $ref: /schemas/graph.yaml#/properties/port
+    $ref: /schemas/graph.yaml#/properties/ports
     description:
       Any connector to the data bus of this controller should be modelled using
       the OF graph bindings specified
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: extcon: maxim,max77843: fix ports type
  2022-03-10  7:32 [PATCH] dt-bindings: extcon: maxim,max77843: fix ports type Krzysztof Kozlowski
@ 2022-03-10 23:25 ` Rob Herring
  2022-03-14  8:52 ` Lee Jones
  2022-03-29 21:26 ` Rob Herring
  2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2022-03-10 23:25 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: devicetree, Lee Jones, linux-kernel, Rob Herring, MyungJoo Ham,
	Chanwoo Choi

On Thu, 10 Mar 2022 08:32:58 +0100, Krzysztof Kozlowski wrote:
> The "ports" property can contain multiple ports as name suggests, so it
> should be using "ports" type from device graphs.
> 
> Reported-by: Rob Herring <robh@kernel.org>
> Fixes: 9729cad0278b ("dt-bindings: extcon: maxim,max77843: Add MAX77843 bindings")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> 
> ---
> 
> Hi Lee,
> 
> This is a fix for a commit in your next branch.
> ---
>  Documentation/devicetree/bindings/extcon/maxim,max77843.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: extcon: maxim,max77843: fix ports type
  2022-03-10  7:32 [PATCH] dt-bindings: extcon: maxim,max77843: fix ports type Krzysztof Kozlowski
  2022-03-10 23:25 ` Rob Herring
@ 2022-03-14  8:52 ` Lee Jones
  2022-03-29 21:26 ` Rob Herring
  2 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2022-03-14  8:52 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Chanwoo Choi, MyungJoo Ham, Rob Herring, linux-kernel,
	devicetree, Rob Herring

On Thu, 10 Mar 2022, Krzysztof Kozlowski wrote:

> The "ports" property can contain multiple ports as name suggests, so it
> should be using "ports" type from device graphs.
> 
> Reported-by: Rob Herring <robh@kernel.org>
> Fixes: 9729cad0278b ("dt-bindings: extcon: maxim,max77843: Add MAX77843 bindings")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> 
> ---
> 
> Hi Lee,
> 
> This is a fix for a commit in your next branch.

Yes and no.

I sent out a pull-request so that follow-up fixes can go in via their
respective trees.

> ---
>  Documentation/devicetree/bindings/extcon/maxim,max77843.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/extcon/maxim,max77843.yaml b/Documentation/devicetree/bindings/extcon/maxim,max77843.yaml
> index f9ffe3d6f957..0216ec868c3e 100644
> --- a/Documentation/devicetree/bindings/extcon/maxim,max77843.yaml
> +++ b/Documentation/devicetree/bindings/extcon/maxim,max77843.yaml
> @@ -25,7 +25,7 @@ properties:
>      $ref: /schemas/connector/usb-connector.yaml#
>  
>    ports:
> -    $ref: /schemas/graph.yaml#/properties/port
> +    $ref: /schemas/graph.yaml#/properties/ports
>      description:
>        Any connector to the data bus of this controller should be modelled using
>        the OF graph bindings specified

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: extcon: maxim,max77843: fix ports type
  2022-03-10  7:32 [PATCH] dt-bindings: extcon: maxim,max77843: fix ports type Krzysztof Kozlowski
  2022-03-10 23:25 ` Rob Herring
  2022-03-14  8:52 ` Lee Jones
@ 2022-03-29 21:26 ` Rob Herring
  2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2022-03-29 21:26 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, Lee Jones, devicetree, linux-kernel, Chanwoo Choi,
	MyungJoo Ham

On Thu, 10 Mar 2022 08:32:58 +0100, Krzysztof Kozlowski wrote:
> The "ports" property can contain multiple ports as name suggests, so it
> should be using "ports" type from device graphs.
> 
> Reported-by: Rob Herring <robh@kernel.org>
> Fixes: 9729cad0278b ("dt-bindings: extcon: maxim,max77843: Add MAX77843 bindings")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> 
> ---
> 
> Hi Lee,
> 
> This is a fix for a commit in your next branch.
> ---
>  Documentation/devicetree/bindings/extcon/maxim,max77843.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied, thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-03-29 21:26 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-10  7:32 [PATCH] dt-bindings: extcon: maxim,max77843: fix ports type Krzysztof Kozlowski
2022-03-10 23:25 ` Rob Herring
2022-03-14  8:52 ` Lee Jones
2022-03-29 21:26 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).