* [PATCH] media: meson-ir-tx: fix platform_get_irq.cocci warning
@ 2022-03-10 7:40 Yihao Han
2022-03-14 8:02 ` Neil Armstrong
0 siblings, 1 reply; 2+ messages in thread
From: Yihao Han @ 2022-03-10 7:40 UTC (permalink / raw)
To: Sean Young, Mauro Carvalho Chehab, Neil Armstrong, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, linux-media,
linux-arm-kernel, linux-amlogic, linux-kernel
Cc: kernel, Yihao Han
Remove dev_err() messages after platform_get_irq*() failures.
platform_get_irq() already prints an error.
Generated by: scripts/coccinelle/api/platform_get_irq.cocci
Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
drivers/media/rc/meson-ir-tx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/rc/meson-ir-tx.c b/drivers/media/rc/meson-ir-tx.c
index 63e1dbf0a4e9..abdb62b16e98 100644
--- a/drivers/media/rc/meson-ir-tx.c
+++ b/drivers/media/rc/meson-ir-tx.c
@@ -323,10 +323,8 @@ static int __init meson_irtx_probe(struct platform_device *pdev)
return PTR_ERR(ir->reg_base);
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(dev, "no irq resource found\n");
+ if (irq < 0)
return -ENODEV;
- }
ir->dev = dev;
ir->carrier = MIRTX_DEFAULT_CARRIER;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: meson-ir-tx: fix platform_get_irq.cocci warning
2022-03-10 7:40 [PATCH] media: meson-ir-tx: fix platform_get_irq.cocci warning Yihao Han
@ 2022-03-14 8:02 ` Neil Armstrong
0 siblings, 0 replies; 2+ messages in thread
From: Neil Armstrong @ 2022-03-14 8:02 UTC (permalink / raw)
To: Yihao Han, Sean Young, Mauro Carvalho Chehab, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, linux-media,
linux-arm-kernel, linux-amlogic, linux-kernel
Cc: kernel
On 10/03/2022 08:40, Yihao Han wrote:
> Remove dev_err() messages after platform_get_irq*() failures.
> platform_get_irq() already prints an error.
>
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
>
> Signed-off-by: Yihao Han <hanyihao@vivo.com>
> ---
> drivers/media/rc/meson-ir-tx.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/rc/meson-ir-tx.c b/drivers/media/rc/meson-ir-tx.c
> index 63e1dbf0a4e9..abdb62b16e98 100644
> --- a/drivers/media/rc/meson-ir-tx.c
> +++ b/drivers/media/rc/meson-ir-tx.c
> @@ -323,10 +323,8 @@ static int __init meson_irtx_probe(struct platform_device *pdev)
> return PTR_ERR(ir->reg_base);
>
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> - dev_err(dev, "no irq resource found\n");
> + if (irq < 0)
> return -ENODEV;
> - }
>
> ir->dev = dev;
> ir->carrier = MIRTX_DEFAULT_CARRIER;
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-14 8:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-10 7:40 [PATCH] media: meson-ir-tx: fix platform_get_irq.cocci warning Yihao Han
2022-03-14 8:02 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).