* [PATCH] vhost: allow batching hint without size
@ 2022-03-10 7:52 Jason Wang
2022-03-10 10:59 ` Eli Cohen
0 siblings, 1 reply; 2+ messages in thread
From: Jason Wang @ 2022-03-10 7:52 UTC (permalink / raw)
To: mst
Cc: kvm, virtualization, netdev, linux-kernel, Jason Wang, Eli Cohen,
Anirudh Rayabharam
Commit e2ae38cf3d91 ("vhost: fix hung thread due to erroneous iotlb
entries") tries to reject the IOTLB message whose size is zero. But
the size is not necessarily meaningful, one example is the batching
hint, so the commit breaks that.
Fixing this be reject zero size message only if the message is used to
update/invalidate the IOTLB.
Fixes: e2ae38cf3d91 ("vhost: fix hung thread due to erroneous iotlb entries")
Reported-by: Eli Cohen <elic@nvidia.com>
Cc: Anirudh Rayabharam <mail@anirudhrb.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
drivers/vhost/vhost.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 082380c03a3e..1768362115c6 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -1170,7 +1170,9 @@ ssize_t vhost_chr_write_iter(struct vhost_dev *dev,
goto done;
}
- if (msg.size == 0) {
+ if ((msg.type == VHOST_IOTLB_UPDATE ||
+ msg.type == VHOST_IOTLB_INVALIDATE) &&
+ msg.size == 0) {
ret = -EINVAL;
goto done;
}
--
2.18.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] vhost: allow batching hint without size
2022-03-10 7:52 [PATCH] vhost: allow batching hint without size Jason Wang
@ 2022-03-10 10:59 ` Eli Cohen
0 siblings, 0 replies; 2+ messages in thread
From: Eli Cohen @ 2022-03-10 10:59 UTC (permalink / raw)
To: Jason Wang, mst
Cc: kvm, virtualization, netdev, linux-kernel, Anirudh Rayabharam
Tested-by: Eli Cohen <elic@nvidia.com>
> -----Original Message-----
> From: Jason Wang <jasowang@redhat.com>
> Sent: Thursday, March 10, 2022 9:52 AM
> To: mst@redhat.com
> Cc: kvm@vger.kernel.org; virtualization@lists.linux-foundation.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Jason Wang
> <jasowang@redhat.com>; Eli Cohen <elic@nvidia.com>; Anirudh Rayabharam <mail@anirudhrb.com>
> Subject: [PATCH] vhost: allow batching hint without size
>
> Commit e2ae38cf3d91 ("vhost: fix hung thread due to erroneous iotlb
> entries") tries to reject the IOTLB message whose size is zero. But
> the size is not necessarily meaningful, one example is the batching
> hint, so the commit breaks that.
>
> Fixing this be reject zero size message only if the message is used to
> update/invalidate the IOTLB.
>
> Fixes: e2ae38cf3d91 ("vhost: fix hung thread due to erroneous iotlb entries")
> Reported-by: Eli Cohen <elic@nvidia.com>
> Cc: Anirudh Rayabharam <mail@anirudhrb.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
> drivers/vhost/vhost.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
> index 082380c03a3e..1768362115c6 100644
> --- a/drivers/vhost/vhost.c
> +++ b/drivers/vhost/vhost.c
> @@ -1170,7 +1170,9 @@ ssize_t vhost_chr_write_iter(struct vhost_dev *dev,
> goto done;
> }
>
> - if (msg.size == 0) {
> + if ((msg.type == VHOST_IOTLB_UPDATE ||
> + msg.type == VHOST_IOTLB_INVALIDATE) &&
> + msg.size == 0) {
> ret = -EINVAL;
> goto done;
> }
> --
> 2.18.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-10 10:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-10 7:52 [PATCH] vhost: allow batching hint without size Jason Wang
2022-03-10 10:59 ` Eli Cohen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).