From: Eugen Hristev <eugen.hristev@microchip.com>
To: <linux-media@vger.kernel.org>, <jacopo@jmondi.org>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<claudiu.beznea@microchip.com>, <robh+dt@kernel.org>,
<nicolas.ferre@microchip.com>,
Eugen Hristev <eugen.hristev@microchip.com>
Subject: [PATCH v9 05/13] media: atmel: atmel-sama5d2-isc: fix wrong mask in YUYV format check
Date: Thu, 10 Mar 2022 11:51:54 +0200 [thread overview]
Message-ID: <20220310095202.2701399-6-eugen.hristev@microchip.com> (raw)
In-Reply-To: <20220310095202.2701399-1-eugen.hristev@microchip.com>
While this does not happen in production, this check should be done
versus the mask, as checking with the YCYC value may not include
some bits that may be set.
Is it correct and safe to check the whole mask.
Fixes: 123aaf816b95 ("media: atmel: atmel-sama5d2-isc: fix YUYV format")
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
---
drivers/media/platform/atmel/atmel-sama5d2-isc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/atmel/atmel-sama5d2-isc.c b/drivers/media/platform/atmel/atmel-sama5d2-isc.c
index c244682ea22f..025c3e8a7e95 100644
--- a/drivers/media/platform/atmel/atmel-sama5d2-isc.c
+++ b/drivers/media/platform/atmel/atmel-sama5d2-isc.c
@@ -291,7 +291,7 @@ static void isc_sama5d2_config_rlp(struct isc_device *isc)
* Thus, if the YCYC mode is selected, replace it with the
* sama5d2-compliant mode which is YYCC .
*/
- if ((rlp_mode & ISC_RLP_CFG_MODE_YCYC) == ISC_RLP_CFG_MODE_YCYC) {
+ if ((rlp_mode & ISC_RLP_CFG_MODE_MASK) == ISC_RLP_CFG_MODE_YCYC) {
rlp_mode &= ~ISC_RLP_CFG_MODE_MASK;
rlp_mode |= ISC_RLP_CFG_MODE_YYCC;
}
--
2.25.1
next prev parent reply other threads:[~2022-03-10 9:53 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 9:51 [PATCH v9 00/13] media: atmel: atmel-isc: implement media controller Eugen Hristev
2022-03-10 9:51 ` [PATCH v9 01/13] media: atmel: atmel-isc-base: use streaming status when queueing buffers Eugen Hristev
2022-03-10 9:51 ` [PATCH v9 02/13] media: atmel: atmel-isc-base: replace is_streaming call in s_fmt_vid_cap Eugen Hristev
2022-03-10 9:51 ` [PATCH v9 03/13] media: atmel: atmel-isc: remove redundant comments Eugen Hristev
2022-03-10 9:51 ` [PATCH v9 04/13] media: atmel: atmel-isc: implement media controller Eugen Hristev
2022-03-10 9:51 ` Eugen Hristev [this message]
2022-03-10 9:51 ` [PATCH v9 06/13] media: atmel: atmel-isc-base: use mutex to lock awb workqueue from streaming Eugen Hristev
2022-04-29 7:41 ` Hans Verkuil
2022-04-29 8:08 ` Eugen.Hristev
2022-04-29 8:18 ` Hans Verkuil
2022-03-10 9:51 ` [PATCH v9 07/13] media: atmel: atmel-isc: compact the controller formats list Eugen Hristev
2022-03-10 9:51 ` [PATCH v9 08/13] media: atmel: atmel-isc: change format propagation to subdev into only verification Eugen Hristev
2022-04-29 8:17 ` Hans Verkuil
2022-04-29 8:28 ` Eugen.Hristev
2022-04-29 8:43 ` Hans Verkuil
2022-04-29 9:58 ` Jacopo Mondi
2022-04-29 10:03 ` Hans Verkuil
2022-04-29 10:09 ` Eugen.Hristev
2022-04-29 10:07 ` Laurent Pinchart
2022-04-29 10:13 ` Hans Verkuil
2022-04-29 10:20 ` Laurent Pinchart
2022-04-29 11:17 ` Hans Verkuil
2022-04-29 12:02 ` Laurent Pinchart
2022-04-29 12:23 ` Hans Verkuil
2022-04-29 12:28 ` Laurent Pinchart
2022-04-29 12:38 ` Jacopo Mondi
2022-04-29 12:47 ` Laurent Pinchart
2022-04-29 12:50 ` Hans Verkuil
2022-04-29 12:59 ` Eugen.Hristev
2022-03-10 9:51 ` [PATCH v9 09/13] media: atmel: atmel-sama7g5-isc: remove stray line Eugen Hristev
2022-03-10 9:51 ` [PATCH v9 10/13] dt-bindings: media: microchip,xisc: add bus-width of 14 Eugen Hristev
2022-03-10 9:52 ` [PATCH v9 11/13] ARM: dts: at91: sama7g5: add nodes for video capture Eugen Hristev
2022-03-10 9:52 ` [PATCH v9 12/13] ARM: configs: at91: sama7: add xisc and csi2dc Eugen Hristev
2022-03-10 9:52 ` [PATCH v9 13/13] ARM: multi_v7_defconfig: add atmel video pipeline modules Eugen Hristev
2022-04-29 8:05 ` [PATCH v9 00/13] media: atmel: atmel-isc: implement media controller Hans Verkuil
2022-04-29 8:20 ` Eugen.Hristev
2022-04-29 8:33 ` Hans Verkuil
2022-04-29 8:39 ` Eugen.Hristev
2022-04-29 8:45 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220310095202.2701399-6-eugen.hristev@microchip.com \
--to=eugen.hristev@microchip.com \
--cc=claudiu.beznea@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=jacopo@jmondi.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).