* Re: [PATCH] atm: eni: Add check for dma_map_single
@ 2022-03-14 1:26 Jiasheng Jiang
0 siblings, 0 replies; 3+ messages in thread
From: Jiasheng Jiang @ 2022-03-14 1:26 UTC (permalink / raw)
To: kuba; +Cc: 3chas3, linux-atm-general, netdev, linux-kernel, Jiasheng Jiang
On Sat, 12 Mar 2022 15:04:38 +0800 Jakub Kicinski wrote:
>> + if (dma_mapping_error(&eni_dev->pci_dev->dev, paddr))
>> + return enq_jam;
>
> Probably better to drop the packet if mapping fails.
Thanks, I will submit a v2 changing to "enq_jam".
Jiang
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] atm: eni: Add check for dma_map_single
2022-03-11 7:16 Jiasheng Jiang
@ 2022-03-12 7:04 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2022-03-12 7:04 UTC (permalink / raw)
To: Jiasheng Jiang; +Cc: 3chas3, linux-atm-general, netdev, linux-kernel
On Fri, 11 Mar 2022 15:16:56 +0800 Jiasheng Jiang wrote:
> As the potential failure of the dma_map_single(),
> it should be better to check it and return error
> if fails.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> drivers/atm/eni.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c
> index 422753d52244..96c2d8f5646b 100644
> --- a/drivers/atm/eni.c
> +++ b/drivers/atm/eni.c
> @@ -1112,6 +1112,8 @@ DPRINTK("iovcnt = %d\n",skb_shinfo(skb)->nr_frags);
> skb_data3 = skb->data[3];
> paddr = dma_map_single(&eni_dev->pci_dev->dev,skb->data,skb->len,
> DMA_TO_DEVICE);
> + if (dma_mapping_error(&eni_dev->pci_dev->dev, paddr))
> + return enq_jam;
Probably better to drop the packet if mapping fails.
> ENI_PRV_PADDR(skb) = paddr;
> /* prepare DMA queue entries */
> j = 0;
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] atm: eni: Add check for dma_map_single
@ 2022-03-11 7:16 Jiasheng Jiang
2022-03-12 7:04 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Jiasheng Jiang @ 2022-03-11 7:16 UTC (permalink / raw)
To: 3chas3; +Cc: linux-atm-general, netdev, linux-kernel, Jiasheng Jiang
As the potential failure of the dma_map_single(),
it should be better to check it and return error
if fails.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
drivers/atm/eni.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c
index 422753d52244..96c2d8f5646b 100644
--- a/drivers/atm/eni.c
+++ b/drivers/atm/eni.c
@@ -1112,6 +1112,8 @@ DPRINTK("iovcnt = %d\n",skb_shinfo(skb)->nr_frags);
skb_data3 = skb->data[3];
paddr = dma_map_single(&eni_dev->pci_dev->dev,skb->data,skb->len,
DMA_TO_DEVICE);
+ if (dma_mapping_error(&eni_dev->pci_dev->dev, paddr))
+ return enq_jam;
ENI_PRV_PADDR(skb) = paddr;
/* prepare DMA queue entries */
j = 0;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-14 1:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-14 1:26 [PATCH] atm: eni: Add check for dma_map_single Jiasheng Jiang
-- strict thread matches above, loose matches on Subject: below --
2022-03-11 7:16 Jiasheng Jiang
2022-03-12 7:04 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).