* [PATCH v2] hv_netvsc: Add check for kvmalloc_array
@ 2022-03-14 2:01 Jiasheng Jiang
2022-03-16 5:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Jiasheng Jiang @ 2022-03-14 2:01 UTC (permalink / raw)
To: stephen
Cc: kys, haiyangz, sthemmin, wei.liu, decui, davem, kuba, ast,
daniel, hawk, john.fastabend, andrii, kafai, songliubraving, yhs,
kpsingh, linux-hyperv, netdev, linux-kernel, bpf, Jiasheng Jiang
As the potential failure of the kvmalloc_array(),
it should be better to check and restore the 'data'
if fails in order to avoid the dereference of the
NULL pointer.
Fixes: 6ae746711263 ("hv_netvsc: Add per-cpu ethtool stats for netvsc")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
Changelog:
v1 -> v2
* Change 1. Remove the unrolled zero.
---
drivers/net/hyperv/netvsc_drv.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index 3646469433b1..fde1c492ca02 100644
--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c
@@ -1587,6 +1587,9 @@ static void netvsc_get_ethtool_stats(struct net_device *dev,
pcpu_sum = kvmalloc_array(num_possible_cpus(),
sizeof(struct netvsc_ethtool_pcpu_stats),
GFP_KERNEL);
+ if (!pcpu_sum)
+ return;
+
netvsc_get_pcpu_stats(dev, pcpu_sum);
for_each_present_cpu(cpu) {
struct netvsc_ethtool_pcpu_stats *this_sum = &pcpu_sum[cpu];
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] hv_netvsc: Add check for kvmalloc_array
2022-03-14 2:01 [PATCH v2] hv_netvsc: Add check for kvmalloc_array Jiasheng Jiang
@ 2022-03-16 5:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-03-16 5:10 UTC (permalink / raw)
To: Jiasheng Jiang
Cc: stephen, kys, haiyangz, sthemmin, wei.liu, decui, davem, kuba,
ast, daniel, hawk, john.fastabend, andrii, kafai, songliubraving,
yhs, kpsingh, linux-hyperv, netdev, linux-kernel, bpf
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 14 Mar 2022 10:01:25 +0800 you wrote:
> As the potential failure of the kvmalloc_array(),
> it should be better to check and restore the 'data'
> if fails in order to avoid the dereference of the
> NULL pointer.
>
> Fixes: 6ae746711263 ("hv_netvsc: Add per-cpu ethtool stats for netvsc")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
>
> [...]
Here is the summary with links:
- [v2] hv_netvsc: Add check for kvmalloc_array
https://git.kernel.org/netdev/net/c/886e44c9298a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-16 5:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-14 2:01 [PATCH v2] hv_netvsc: Add check for kvmalloc_array Jiasheng Jiang
2022-03-16 5:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).