linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Saenz Julienne <nsaenzju@redhat.com>
To: feng.tang@intel.com, tglx@linutronix.de
Cc: andi.kleen@intel.com, bp@alien8.de, dave.hansen@intel.com,
	hpa@zytor.com, len.brown@intel.com, linux-kernel@vger.kernel.org,
	mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org,
	rui.zhang@intel.com, tim.c.chen@intel.com, x86@kernel.org,
	mtosatti@redhat.com, nsaenzju@redhat.com, frederic@kernel.org
Subject: Re: [PATCH v3 1/2] x86/tsc: add a timer to make sure tsc_adjust is always checked
Date: Mon, 14 Mar 2022 18:52:07 +0100	[thread overview]
Message-ID: <20220314175207.274870-1-nsaenzju@redhat.com> (raw)
In-Reply-To: <20211117023751.24190-1-feng.tang@intel.com>

Hi Feng, Thomas,

> On Wed, Nov 17, 2021 at 10:37:51AM +0800, Feng Tang wrote:
> Normally the tsc_sync will get checked every time system enters idle state,
> but Thomas Gleixner mentioned there is still a caveat that a system won't
> enter idle [1], either because it's too busy or configured purposely to not
> enter idle. Setup a periodic timer (every 10 minitues) to make sure the
> check is always on.
> 
> [1]. https://lore.kernel.org/lkml/875z286xtk.fsf@nanos.tec.linutronix.de/
> Signed-off-by: Feng Tang <feng.tang@intel.com>

I can see this timer interrupting my system's nohz_full CPUs. It'd be nice to
be able to avoid the noise. A solution is using 'tsc=reliable', but IIUC this
is not what the flag was created for. Any ideas/suggestions?

Regards,
Nicolas


  parent reply	other threads:[~2022-03-14 17:52 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17  2:37 [PATCH v3 1/2] x86/tsc: add a timer to make sure tsc_adjust is always checked Feng Tang
2021-11-17  2:37 ` [PATCH v3 2/2] x86/tsc: skip tsc watchdog checking for qualified platforms Feng Tang
2021-11-30  6:46   ` Feng Tang
2021-11-30 14:40     ` Paul E. McKenney
2021-11-30 15:02       ` Feng Tang
2021-11-30 16:28         ` Paul E. McKenney
2021-11-30 20:39           ` Thomas Gleixner
2021-11-30 20:47             ` Paul E. McKenney
2021-11-30 21:55               ` Thomas Gleixner
2021-11-30 22:48                 ` Paul E. McKenney
2021-11-30 23:19                   ` Thomas Gleixner
2021-11-30 23:37                     ` Paul E. McKenney
2021-12-01  1:26                       ` Feng Tang
2021-12-01 17:52                         ` Paul E. McKenney
2021-12-07  1:41           ` Feng Tang
2021-12-01  4:45   ` Luming Yu
2021-12-01  5:19     ` Feng Tang
2021-12-01 10:41     ` Thomas Gleixner
2021-12-01 23:47   ` [tip: x86/urgent] x86/tsc: Disable clocksource watchdog for TSC on qualified platorms tip-bot2 for Feng Tang
2021-12-02  4:47   ` [PATCH v3 2/2] x86/tsc: skip tsc watchdog checking for qualified platforms Luming Yu
2021-12-01 23:47 ` [tip: x86/urgent] x86/tsc: Add a timer to make sure TSC_adjust is always checked tip-bot2 for Feng Tang
2022-03-14 17:52 ` Nicolas Saenz Julienne [this message]
2022-03-15  1:33   ` [PATCH v3 1/2] x86/tsc: add a timer to make sure tsc_adjust " Feng Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220314175207.274870-1-nsaenzju@redhat.com \
    --to=nsaenzju@redhat.com \
    --cc=andi.kleen@intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@intel.com \
    --cc=feng.tang@intel.com \
    --cc=frederic@kernel.org \
    --cc=hpa@zytor.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rui.zhang@intel.com \
    --cc=tglx@linutronix.de \
    --cc=tim.c.chen@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).