* [PATCH] scsi: scsi_ioctl:drop needless assignment in sg_io()
@ 2022-03-15 6:15 Lukas Bulwahn
2022-03-15 6:29 ` Christoph Hellwig
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Lukas Bulwahn @ 2022-03-15 6:15 UTC (permalink / raw)
To: Christoph Hellwig, Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
Commit ce70fd9a551a ("scsi: core: Remove the cmd field from struct
scsi_request") refactored sg_io(), so that it does not allocate directly
and hence does not return -ENOMEM in its error case. That makes a
remaining assignment of -ENOMEM to the return variable needless.
Drop this needless assignment in sg_io().
No functional change. No change in resulting object code.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Christoph, please ack.
Martin, please pick this minor clean-up on your -next tree on top of the
commit above.
drivers/scsi/scsi_ioctl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/scsi_ioctl.c b/drivers/scsi/scsi_ioctl.c
index 0613015cae39..a480c4d589f5 100644
--- a/drivers/scsi/scsi_ioctl.c
+++ b/drivers/scsi/scsi_ioctl.c
@@ -434,7 +434,6 @@ static int sg_io(struct scsi_device *sdev, struct sg_io_hdr *hdr, fmode_t mode)
if (hdr->flags & SG_FLAG_Q_AT_HEAD)
at_head = 1;
- ret = -ENOMEM;
rq = scsi_alloc_request(sdev->request_queue, writing ?
REQ_OP_DRV_OUT : REQ_OP_DRV_IN, 0);
if (IS_ERR(rq))
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: scsi_ioctl:drop needless assignment in sg_io()
2022-03-15 6:15 [PATCH] scsi: scsi_ioctl:drop needless assignment in sg_io() Lukas Bulwahn
@ 2022-03-15 6:29 ` Christoph Hellwig
2022-03-15 18:07 ` Martin K. Petersen
2022-03-19 3:56 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2022-03-15 6:29 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: Christoph Hellwig, Martin K . Petersen, linux-scsi,
kernel-janitors, linux-kernel
On Tue, Mar 15, 2022 at 07:15:20AM +0100, Lukas Bulwahn wrote:
> Commit ce70fd9a551a ("scsi: core: Remove the cmd field from struct
> scsi_request") refactored sg_io(), so that it does not allocate directly
> and hence does not return -ENOMEM in its error case. That makes a
> remaining assignment of -ENOMEM to the return variable needless.
>
> Drop this needless assignment in sg_io().
>
> No functional change. No change in resulting object code.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: scsi_ioctl:drop needless assignment in sg_io()
2022-03-15 6:15 [PATCH] scsi: scsi_ioctl:drop needless assignment in sg_io() Lukas Bulwahn
2022-03-15 6:29 ` Christoph Hellwig
@ 2022-03-15 18:07 ` Martin K. Petersen
2022-03-19 3:56 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2022-03-15 18:07 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: Christoph Hellwig, Martin K . Petersen, linux-scsi,
kernel-janitors, linux-kernel
Lukas,
> Commit ce70fd9a551a ("scsi: core: Remove the cmd field from struct
> scsi_request") refactored sg_io(), so that it does not allocate
> directly and hence does not return -ENOMEM in its error case. That
> makes a remaining assignment of -ENOMEM to the return variable
> needless.
Applied to 5.18/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: scsi_ioctl:drop needless assignment in sg_io()
2022-03-15 6:15 [PATCH] scsi: scsi_ioctl:drop needless assignment in sg_io() Lukas Bulwahn
2022-03-15 6:29 ` Christoph Hellwig
2022-03-15 18:07 ` Martin K. Petersen
@ 2022-03-19 3:56 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2022-03-19 3:56 UTC (permalink / raw)
To: Christoph Hellwig, linux-scsi, Lukas Bulwahn
Cc: Martin K . Petersen, linux-kernel, kernel-janitors
On Tue, 15 Mar 2022 07:15:20 +0100, Lukas Bulwahn wrote:
> Commit ce70fd9a551a ("scsi: core: Remove the cmd field from struct
> scsi_request") refactored sg_io(), so that it does not allocate directly
> and hence does not return -ENOMEM in its error case. That makes a
> remaining assignment of -ENOMEM to the return variable needless.
>
> Drop this needless assignment in sg_io().
>
> [...]
Applied to 5.18/scsi-queue, thanks!
[1/1] scsi: scsi_ioctl:drop needless assignment in sg_io()
https://git.kernel.org/mkp/scsi/c/66daf3e6b993
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-19 3:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-15 6:15 [PATCH] scsi: scsi_ioctl:drop needless assignment in sg_io() Lukas Bulwahn
2022-03-15 6:29 ` Christoph Hellwig
2022-03-15 18:07 ` Martin K. Petersen
2022-03-19 3:56 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).