* [PATCH] thermal/drivers/qcom/lmh: Fix irq handler return value
@ 2022-03-16 18:03 Bjorn Andersson
2022-03-16 20:24 ` Dmitry Baryshkov
0 siblings, 1 reply; 2+ messages in thread
From: Bjorn Andersson @ 2022-03-16 18:03 UTC (permalink / raw)
To: Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano,
Zhang Rui
Cc: linux-pm, linux-arm-msm, linux-kernel
After enough invocations the LMh irq is eventually reported as bad, because the
handler doesn't return IRQ_HANDLED, fix this.
Fixes: 53bca371cdf7 ("thermal/drivers/qcom: Add support for LMh driver")
Reported-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
drivers/thermal/qcom/lmh.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/qcom/lmh.c b/drivers/thermal/qcom/lmh.c
index c7f91cbdccc7..af9f0872614f 100644
--- a/drivers/thermal/qcom/lmh.c
+++ b/drivers/thermal/qcom/lmh.c
@@ -45,7 +45,7 @@ static irqreturn_t lmh_handle_irq(int hw_irq, void *data)
if (irq)
generic_handle_irq(irq);
- return 0;
+ return IRQ_HANDLED;
}
static void lmh_enable_interrupt(struct irq_data *d)
--
2.33.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] thermal/drivers/qcom/lmh: Fix irq handler return value
2022-03-16 18:03 [PATCH] thermal/drivers/qcom/lmh: Fix irq handler return value Bjorn Andersson
@ 2022-03-16 20:24 ` Dmitry Baryshkov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Baryshkov @ 2022-03-16 20:24 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano,
Zhang Rui, linux-pm, linux-arm-msm, linux-kernel
On Wed, 16 Mar 2022 at 21:01, Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> After enough invocations the LMh irq is eventually reported as bad, because the
> handler doesn't return IRQ_HANDLED, fix this.
>
> Fixes: 53bca371cdf7 ("thermal/drivers/qcom: Add support for LMh driver")
> Reported-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/thermal/qcom/lmh.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/qcom/lmh.c b/drivers/thermal/qcom/lmh.c
> index c7f91cbdccc7..af9f0872614f 100644
> --- a/drivers/thermal/qcom/lmh.c
> +++ b/drivers/thermal/qcom/lmh.c
> @@ -45,7 +45,7 @@ static irqreturn_t lmh_handle_irq(int hw_irq, void *data)
> if (irq)
> generic_handle_irq(irq);
>
> - return 0;
> + return IRQ_HANDLED;
> }
>
> static void lmh_enable_interrupt(struct irq_data *d)
> --
> 2.33.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-16 20:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-16 18:03 [PATCH] thermal/drivers/qcom/lmh: Fix irq handler return value Bjorn Andersson
2022-03-16 20:24 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).