* [PATCH] vlan: use correct format characters
@ 2022-03-16 21:31 Bill Wendling
2022-03-17 23:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Bill Wendling @ 2022-03-16 21:31 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski, Nathan Chancellor,
Nick Desaulniers, Bill Wendling, netdev, linux-kernel, llvm
When compiling with -Wformat, clang emits the following warning:
net/8021q/vlanproc.c:284:22: warning: format specifies type 'unsigned
short' but the argument has type 'int' [-Wformat]
mp->priority, ((mp->vlan_qos >> 13) & 0x7));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
The types of these arguments are unconditionally defined, so this patch
updates the format character to the correct ones for ints and unsigned
ints.
Link: ClangBuiltLinux/linux#378
Signed-off-by: Bill Wendling <morbo@google.com>
---
net/8021q/vlanproc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/8021q/vlanproc.c b/net/8021q/vlanproc.c
index 08bf6c839e25..7825c129742a 100644
--- a/net/8021q/vlanproc.c
+++ b/net/8021q/vlanproc.c
@@ -280,7 +280,7 @@ static int vlandev_seq_show(struct seq_file *seq, void *offset)
const struct vlan_priority_tci_mapping *mp
= vlan->egress_priority_map[i];
while (mp) {
- seq_printf(seq, "%u:%hu ",
+ seq_printf(seq, "%u:%d ",
mp->priority, ((mp->vlan_qos >> 13) & 0x7));
mp = mp->next;
}
--
2.35.1.723.g4982287a31-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] vlan: use correct format characters
2022-03-16 21:31 [PATCH] vlan: use correct format characters Bill Wendling
@ 2022-03-17 23:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-03-17 23:50 UTC (permalink / raw)
To: Bill Wendling
Cc: davem, kuba, nathan, ndesaulniers, netdev, linux-kernel, llvm
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 16 Mar 2022 14:31:25 -0700 you wrote:
> When compiling with -Wformat, clang emits the following warning:
>
> net/8021q/vlanproc.c:284:22: warning: format specifies type 'unsigned
> short' but the argument has type 'int' [-Wformat]
> mp->priority, ((mp->vlan_qos >> 13) & 0x7));
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> [...]
Here is the summary with links:
- vlan: use correct format characters
https://git.kernel.org/netdev/net-next/c/8624a95ecdea
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-17 23:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-16 21:31 [PATCH] vlan: use correct format characters Bill Wendling
2022-03-17 23:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).