From: Jason Gunthorpe <jgg@ziepe.ca>
To: John Hubbard <jhubbard@nvidia.com>
Cc: "Mika Penttilä" <mpenttil@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
apopple@nvidia.com, rcampbell@nvidia.com, vbabka@suse.cz
Subject: Re: [PATCH v2] mm/hmm/test: simplify hmm test code: use miscdevice instead of char dev
Date: Fri, 18 Mar 2022 09:40:11 -0300 [thread overview]
Message-ID: <20220318124011.GE64706@ziepe.ca> (raw)
In-Reply-To: <b3d5e596-adce-20b5-73cc-89c07917082f@nvidia.com>
On Thu, Mar 17, 2022 at 07:58:25PM -0700, John Hubbard wrote:
> In other words, given that the usage here is correct, is there some
> reason that miscdevice is still a poor design fit? Is cdev_device_add()
> a better choice here, for design reasons?
cdev's have become so easy to use I don't see the few loc reduction to
add miscdev that valuable. IMHO
> Also, is there any change that could or should be made to miscdevice,
> that you have in mind?
No, it is just a legacy interface that was simplifies drivers that
create a single char dev in static data that is widely misused.
IOW I wouldn't add new miscdevs.
Jason
prev parent reply other threads:[~2022-03-18 12:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 3:30 [PATCH v2] mm/hmm/test: simplify hmm test code: use miscdevice instead of char dev mpenttil
2022-03-11 6:15 ` John Hubbard
2022-03-11 6:18 ` Mika Penttilä
2022-03-14 18:24 ` Jason Gunthorpe
2022-03-15 3:22 ` Mika Penttilä
2022-03-15 18:39 ` Jason Gunthorpe
2022-03-17 5:47 ` Mika Penttilä
2022-03-17 6:58 ` Mika Penttilä
2022-03-17 14:15 ` Jason Gunthorpe
2022-03-18 2:34 ` Mika Penttilä
2022-03-18 2:58 ` John Hubbard
2022-03-18 12:40 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220318124011.GE64706@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=apopple@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpenttil@redhat.com \
--cc=rcampbell@nvidia.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).