linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Mika Penttilä" <mpenttil@redhat.com>
To: John Hubbard <jhubbard@nvidia.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: apopple@nvidia.com, rcampbell@nvidia.com, jgg@ziepe.ca, vbabka@suse.cz
Subject: Re: [PATCH v2] mm/hmm/test: simplify hmm test code: use miscdevice instead of char dev
Date: Fri, 11 Mar 2022 08:18:51 +0200	[thread overview]
Message-ID: <8b9e7ef4-10b9-1061-d12f-76fd62e1ae2d@redhat.com> (raw)
In-Reply-To: <179e3540-b9bf-5fd2-cfa4-f7274b6c33d1@nvidia.com>



On 11.3.2022 8.15, John Hubbard wrote:
> On 3/10/22 19:30, mpenttil@redhat.com wrote:
>> From: Mika Penttilä <mpenttil@redhat.com>
>>
>> HMM selftests use an in-kernel pseudo device to emulate device private
>> memory. The pseudo device registers a major device range for two pseudo
>> device instances. User space has a script that reads /proc/devices in
>> order to find the assigned major number, and sends that to mknod(1),
>> once for each node.
>>
>> This duplicates a fair amount of boilerplate that misc device can do
>> instead.
>>
>> Change this to use misc device, which makes the device node names appear
>> for us. This also enables udev-like processing if desired.
>>
>> Delete the /proc/devices parsing from the user-space test script, now
>> that it is unnecessary.
>>
>> v2:
>>          - Cleanups per review comments from John Hubbard
>>          - Added Tested-by and Ccs
> 
> The three lines above, starting with "v2:", belong after the "---". That
> way, they are not included in the commit log. That's the convention.
> 
> I think Andrew can fix it up for you, no need to spin a new patch for
> that.
> 
> Anyway, this looks good now, so please feel free to add:
> 
> Reviewed-by: John Hubbard <jhubbard@nvidia.com>


Thanks John!

> 
> 
> thanks,


  reply	other threads:[~2022-03-11  6:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-11  3:30 [PATCH v2] mm/hmm/test: simplify hmm test code: use miscdevice instead of char dev mpenttil
2022-03-11  6:15 ` John Hubbard
2022-03-11  6:18   ` Mika Penttilä [this message]
2022-03-14 18:24 ` Jason Gunthorpe
2022-03-15  3:22   ` Mika Penttilä
2022-03-15 18:39     ` Jason Gunthorpe
2022-03-17  5:47       ` Mika Penttilä
2022-03-17  6:58         ` Mika Penttilä
2022-03-17 14:15           ` Jason Gunthorpe
2022-03-18  2:34             ` Mika Penttilä
2022-03-18  2:58               ` John Hubbard
2022-03-18 12:40                 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b9e7ef4-10b9-1061-d12f-76fd62e1ae2d@redhat.com \
    --to=mpenttil@redhat.com \
    --cc=apopple@nvidia.com \
    --cc=jgg@ziepe.ca \
    --cc=jhubbard@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rcampbell@nvidia.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).