From: Jonathan Cameron <jic23@kernel.org>
To: Cixi Geng <gengcixi@gmail.com>
Cc: lars@metafoo.de, robh+dt@kernel.org, orsonzhai@gmail.com,
baolin.wang7@gmail.com, zhang.lyra@gmail.com,
lgirdwood@gmail.com, broonie@kernel.org, yuming.zhu1@unisoc.com,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/7] dt-bindings:iio:adc: add sprd,ump9620-adc dtbindings
Date: Sun, 20 Mar 2022 13:30:14 +0000 [thread overview]
Message-ID: <20220320133014.7f5cb5b9@jic23-huawei> (raw)
In-Reply-To: <20220311164628.378849-2-gengcixi@gmail.com>
On Sat, 12 Mar 2022 00:46:22 +0800
Cixi Geng <gengcixi@gmail.com> wrote:
> From: Cixi Geng <cixi.geng1@unisoc.com>
In title, use dt-binding instead of dtbindings at the end.
>
> sprd,ump9620-adc is one variant of sc27xx series, add ump9620 in
> dtbindings.
dt-bindings.
>
> Signed-off-by: Chunyan Zhang <zhang.lyra@gmail.com>
> Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>
If the patch was authored by Chunyan Zhang, it should be From: Chunyan Zhang,
if it is more complex than you simply passing the patch on then we should
see a co-developed to indicate that.
Patch looks good to me
Jonathan
> ---
> .../bindings/iio/adc/sprd,sc2720-adc.yaml | 30 +++++++++++++++++--
> 1 file changed, 27 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml b/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml
> index caa3ee0b4b8c..331b08fb1761 100644
> --- a/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml
> @@ -20,6 +20,7 @@ properties:
> - sprd,sc2723-adc
> - sprd,sc2730-adc
> - sprd,sc2731-adc
> + - sprd,ump9620-adc
>
> reg:
> maxItems: 1
> @@ -37,9 +38,32 @@ properties:
> maxItems: 2
>
> nvmem-cell-names:
> - items:
> - - const: big_scale_calib
> - - const: small_scale_calib
> + description: Names for each nvmem-cells specified.
> +
> +if:
> + not:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - sprd,ump9620-adc
> +then:
> + properties:
> + nvmem-cell-names:
> + items:
> + - const: big_scale_calib
> + - const: small_scale_calib
> +
> +else:
> + properties:
> + nvmem-cell-names:
> + items:
> + - const: big_scale_calib1
> + - const: big_scale_calib2
> + - const: small_scale_calib1
> + - const: small_scale_calib2
> + - const: vbat_det_cal1
> + - const: vbat_det_cal2
>
> required:
> - compatible
next prev parent reply other threads:[~2022-03-20 13:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 16:46 [PATCH V2 0/7] iio: adc: sc27xx: adjust structure and add PMIC's support Cixi Geng
2022-03-11 16:46 ` [PATCH V2 1/7] dt-bindings:iio:adc: add sprd,ump9620-adc dtbindings Cixi Geng
2022-03-20 13:30 ` Jonathan Cameron [this message]
2022-03-24 6:16 ` Cixi Geng
2022-03-20 14:50 ` Krzysztof Kozlowski
2022-03-24 6:22 ` Cixi Geng
2022-03-24 11:14 ` Krzysztof Kozlowski
2022-03-11 16:46 ` [PATCH V2 2/7] iio: adc: sc27xx: fix read big scale voltage not right Cixi Geng
2022-03-20 13:32 ` Jonathan Cameron
2022-03-24 7:36 ` Cixi Geng
2022-03-27 16:23 ` Jonathan Cameron
2022-03-11 16:46 ` [PATCH V2 3/7] iio: adc: sc27xx: structure adjuststment and optimization Cixi Geng
2022-03-23 13:55 ` Baolin Wang
2022-03-29 4:31 ` Cixi Geng
2022-03-11 16:46 ` [PATCH V2 4/7] iio: adc: sc27xx: add support for PMIC sc2720 and sc2721 Cixi Geng
2022-03-20 14:30 ` Jonathan Cameron
2022-03-23 14:06 ` Baolin Wang
2022-03-11 16:46 ` [PATCH V2 5/7] iio: adc: sc27xx: add support for PMIC sc2730 Cixi Geng
2022-03-23 14:09 ` Baolin Wang
2022-03-11 16:46 ` [PATCH V2 6/7] iio: adc: sc27xx: add support for PMIC ump9620 Cixi Geng
2022-03-20 14:41 ` Jonathan Cameron
2022-04-02 10:55 ` Cixi Geng
2022-04-02 17:09 ` Jonathan Cameron
2022-03-11 16:46 ` [PATCH V2 7/7] iio: adc: sc27xx: add Ump9620 ADC suspend and resume pm support Cixi Geng
2022-03-20 14:57 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220320133014.7f5cb5b9@jic23-huawei \
--to=jic23@kernel.org \
--cc=baolin.wang7@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gengcixi@gmail.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
--cc=yuming.zhu1@unisoc.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).