Re: [PATCH V2 1/7] dt-bindings:iio:adc: add sprd,ump9620-adc dtbindings

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Cixi Geng <gengcixi@gmail.com>
Cc: jic23@kernel.org, "Lars-Peter Clausen" <lars@metafoo.de>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Orson Zhai" <orsonzhai@gmail.com>,
	"baolin.wang7@gmail.com" <baolin.wang7@gmail.com>,
	"Chunyan Zhang" <zhang.lyra@gmail.com>,
	lgirdwood@gmail.com, "Mark Brown" <broonie@kernel.org>,
	"朱玉明 (Yuming Zhu/11457)" <yuming.zhu1@unisoc.com>,
	linux-iio@vger.kernel.org,
	"Devicetree List" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 1/7] dt-bindings:iio:adc: add sprd,ump9620-adc dtbindings
Date: Thu, 24 Mar 2022 12:14:03 +0100	[thread overview]
Message-ID: <327e5b31-5b9a-240f-26c1-98b8a29e2023@kernel.org> (raw)
In-Reply-To: <CAF12kFuKnm2qenvpmKhCVD4T+d=0SyruzdpJ5FX1RS8gvqbyNA@mail.gmail.com>

On 24/03/2022 07:22, Cixi Geng wrote:
> Krzysztof Kozlowski <krzk@kernel.org> 于2022年3月20日周日 22:50写道：
>>
>> On 11/03/2022 17:46, Cixi Geng wrote:
>>> From: Cixi Geng <cixi.geng1@unisoc.com>
>>>
>>> sprd,ump9620-adc is one variant of sc27xx series, add ump9620 in
>>> dtbindings.
>>>
>>> Signed-off-by: Chunyan Zhang <zhang.lyra@gmail.com>
>>> Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>
>>> ---
>>>  .../bindings/iio/adc/sprd,sc2720-adc.yaml     | 30 +++++++++++++++++--
>>>  1 file changed, 27 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml b/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml
>>> index caa3ee0b4b8c..331b08fb1761 100644
>>> --- a/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml
>>> +++ b/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml
>>> @@ -20,6 +20,7 @@ properties:
>>>        - sprd,sc2723-adc
>>>        - sprd,sc2730-adc
>>>        - sprd,sc2731-adc
>>> +      - sprd,ump9620-adc
>>>
>>>    reg:
>>>      maxItems: 1
>>> @@ -37,9 +38,32 @@ properties:
>>>      maxItems: 2
>>>
>>>    nvmem-cell-names:
>>> -    items:
>>> -      - const: big_scale_calib
>>> -      - const: small_scale_calib
>>
>> Please test your changes with dt_binding_check and dtbs_check. Your
>> change looks not complete - you have still nvmem-cells = 2.
>>
> Hi Krzysztof
> I test all is PASS on my local.  could you tell how did you test?
> my_logs:
> cixi.geng1@tj10039pcu:~/upsteatming/linux$ make DT_CHECKER_FLAGS=-m
> dt_binding_check &>dt_check.log
> cixi.geng1@tj10039pcu:~/upsteatming/linux$ cat dt_check.log |grep sprd,sc2720
>   DTEX    Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.example.dts
>   DTC     Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.example.dt.yaml
>   CHECK   Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.example.dt.yaml
> cixi.geng1@tj10039pcu:~/upsteatming/linux$ tuxmake -C ${kernel_src} -b
> ${topdir}/obj/gcc -o ${topdir}/dist/gcc -a $ARCH -t gcc  -K
> CONFIG_ARCH_${PLAT}=y -K CONFIG_MFD_SC27XX_PMIC=y -K
> CONFIG_SC27XX_ADC=y
> 

The method is correct, just please test sprd,ump9620-adc (either in
example in the binding or your DTS with `make dtbs_check
DT_SCHEMA_FILES=sprd,sc2720-adc.yaml).

Best regards,
Krzysztof