From: Vladimir Oltean <olteanv@gmail.com>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH 1/4] drivers: net: dsa: qca8k: drop MTU tracking from qca8k_priv
Date: Tue, 22 Mar 2022 13:58:12 +0200 [thread overview]
Message-ID: <20220322115812.mwue2iu2xxrmknxg@skbuf> (raw)
In-Reply-To: <20220322014506.27872-2-ansuelsmth@gmail.com>
On Tue, Mar 22, 2022 at 02:45:03AM +0100, Ansuel Smith wrote:
> Drop the MTU array from qca8k_priv and use slave net dev to get the max
> MTU across all user port. CPU port can be skipped as DSA already make
> sure CPU port are set to the max MTU across all ports.
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
I hardly find this to be an improvement and I would rather not see such
unjustified complexity in a device driver. What are the concrete
benefits, size wise?
> drivers/net/dsa/qca8k.c | 38 +++++++++++++++++++++++---------------
> drivers/net/dsa/qca8k.h | 1 -
> 2 files changed, 23 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
> index d3ed0a7f8077..4366d87b4bbd 100644
> --- a/drivers/net/dsa/qca8k.c
> +++ b/drivers/net/dsa/qca8k.c
> @@ -2367,13 +2367,31 @@ static int
> qca8k_port_change_mtu(struct dsa_switch *ds, int port, int new_mtu)
> {
> struct qca8k_priv *priv = ds->priv;
> - int i, mtu = 0;
> + struct dsa_port *dp;
> + int mtu = new_mtu;
>
> - priv->port_mtu[port] = new_mtu;
> + /* We have only have a general MTU setting. So check
> + * every port and set the max across all port.
> + */
> + list_for_each_entry(dp, &ds->dst->ports, list) {
> + /* We can ignore cpu port, DSA will itself chose
> + * the max MTU across all port
> + */
> + if (!dsa_port_is_user(dp))
> + continue;
>
> - for (i = 0; i < QCA8K_NUM_PORTS; i++)
> - if (priv->port_mtu[i] > mtu)
> - mtu = priv->port_mtu[i];
> + if (dp->index == port)
> + continue;
> +
> + /* Address init phase where not every port have
> + * a slave device
> + */
> + if (!dp->slave)
> + continue;
> +
> + if (mtu < dp->slave->mtu)
> + mtu = dp->slave->mtu;
> + }
>
> /* Include L2 header / FCS length */
> return qca8k_write(priv, QCA8K_MAX_FRAME_SIZE, mtu + ETH_HLEN + ETH_FCS_LEN);
> @@ -3033,16 +3051,6 @@ qca8k_setup(struct dsa_switch *ds)
> QCA8K_PORT_HOL_CTRL1_WRED_EN,
> mask);
> }
> -
> - /* Set initial MTU for every port.
> - * We have only have a general MTU setting. So track
> - * every port and set the max across all port.
> - * Set per port MTU to 1500 as the MTU change function
> - * will add the overhead and if its set to 1518 then it
> - * will apply the overhead again and we will end up with
> - * MTU of 1536 instead of 1518
> - */
> - priv->port_mtu[i] = ETH_DATA_LEN;
> }
>
> /* Special GLOBAL_FC_THRESH value are needed for ar8327 switch */
> diff --git a/drivers/net/dsa/qca8k.h b/drivers/net/dsa/qca8k.h
> index f375627174c8..562d75997e55 100644
> --- a/drivers/net/dsa/qca8k.h
> +++ b/drivers/net/dsa/qca8k.h
> @@ -398,7 +398,6 @@ struct qca8k_priv {
> struct device *dev;
> struct dsa_switch_ops ops;
> struct gpio_desc *reset_gpio;
> - unsigned int port_mtu[QCA8K_NUM_PORTS];
> struct net_device *mgmt_master; /* Track if mdio/mib Ethernet is available */
> struct qca8k_mgmt_eth_data mgmt_eth_data;
> struct qca8k_mib_eth_data mib_eth_data;
> --
> 2.34.1
>
next prev parent reply other threads:[~2022-03-22 11:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 1:45 [net-next PATCH 0/4] Reduce qca8k_priv space usage Ansuel Smith
2022-03-22 1:45 ` [net-next PATCH 1/4] drivers: net: dsa: qca8k: drop MTU tracking from qca8k_priv Ansuel Smith
2022-03-22 11:58 ` Vladimir Oltean [this message]
2022-03-22 13:38 ` Ansuel Smith
2022-03-22 13:55 ` Vladimir Oltean
2022-03-22 14:03 ` Ansuel Smith
2022-03-24 10:45 ` Vladimir Oltean
2022-03-24 20:44 ` Ansuel Smith
2022-03-24 21:05 ` Vladimir Oltean
2022-03-24 23:10 ` Ansuel Smith
2022-03-24 23:14 ` Vladimir Oltean
2022-03-24 23:24 ` Ansuel Smith
2022-03-22 1:45 ` [net-next PATCH 2/4] drivers: net: dsa: qca8k: drop port_sts " Ansuel Smith
2022-03-22 1:45 ` [net-next PATCH 3/4] drivers: net: dsa: qca8k: rework and simplify mdiobus logic Ansuel Smith
2022-03-22 1:45 ` [net-next PATCH 4/4] drivers: net: dsa: qca8k: drop dsa_switch_ops from qca8k_priv Ansuel Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220322115812.mwue2iu2xxrmknxg@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).