From: Jung Daehwan <dh10.jung@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"open list:USB XHCI DRIVER" <linux-usb@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Howard Yen <howardyen@google.com>,
Jack Pham <jackp@codeaurora.org>, Puma Hsu <pumahsu@google.com>,
"J . Avila" <elavila@google.com>,
sc.suh@samsung.com
Subject: Re: [PATCH v3 1/4] usb: host: export symbols for xhci hooks usage
Date: Wed, 23 Mar 2022 10:22:42 +0900 [thread overview]
Message-ID: <20220323012242.GA19041@ubuntu> (raw)
In-Reply-To: <3c345ba1-8339-e8c2-8d14-b75d1264bb4d@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1993 bytes --]
On Tue, Mar 22, 2022 at 06:12:58PM +0100, Krzysztof Kozlowski wrote:
> On 21/03/2022 09:59, Daehwan Jung wrote:
> > Export symbols for xhci hooks usage:
> > xhci_get_slot_ctx
> > xhci_get_endpoint_address
> > - Allow xhci hook to get ep_ctx from the xhci_container_ctx for
> > getting the ep_ctx information to know which ep is offloading and
> > comparing the context in remote subsystem memory if needed.
> >
> > xhci_ring_alloc
> > - Allow xhci hook to allocate vendor specific ring.
> >
> > xhci_trb_virt_to_dma
> > - Used to retrieve the DMA address of vendor specific ring.
> >
> > xhci_segment_free
> > xhci_link_segments
> > - Allow xhci hook to handle vendor specific segment.
> >
> > xhci_initialize_ring_info
> > - Allow xhci hook to initialize vendor specific ring.
> >
> > xhci_check_trb_in_td_math
> > - Allow xhci hook to Check TRB math for validation.
> >
> > xhci_address_device
> > - Allow override to give configuration info to Co-processor.
> >
> > xhci_bus_suspend
> > xhci_bus_resume
> > - Allow override of suspend and resume for power scenario.
> >
> > xhci_remove_stream_mapping
> > - Allow xhci hook to remove stream mapping.
> >
>
> NAK, because you ignored my comments from previous submission. It seems
> you prefer to silently skip answering to them, not CC me and then hope I
> will not remember what I asked for.
>
> I am sorry, but that is not how it works. This is not how Linux kernel
> is developed. Please answer my questions. If they are unclear, ask for
> explanation. Ignoring all my questions/comments and resending without CC
> is a NAK.
>
>
> Best regards,
> Krzysztof
>
Hi Krzysztof
I didn't ignore your comments but focused on your comment to
be in-tree user on previous submission. I've modified my driver to be compiled
as you asked and submitted it.
I'm sorry I missed other comments. I will check them.
Best Regards,
Jung Daehwan
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2022-03-23 1:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220321090202epcas2p1bfa78db059c1f6f6acbbb015e4bf991c@epcas2p1.samsung.com>
2022-03-21 8:59 ` [PATCH v3 0/4] support USB offload feature Daehwan Jung
[not found] ` <CGME20220321090204epcas2p31e39a4b8b6fc803ceecac5d19e6e39e9@epcas2p3.samsung.com>
2022-03-21 8:59 ` [PATCH v3 1/4] usb: host: export symbols for xhci hooks usage Daehwan Jung
2022-03-21 15:35 ` kernel test robot
2022-03-22 17:12 ` Krzysztof Kozlowski
2022-03-23 1:22 ` Jung Daehwan [this message]
[not found] ` <CGME20220321090204epcas2p3b2be5c6b131240e408d12d40c517395c@epcas2p3.samsung.com>
2022-03-21 8:59 ` [PATCH v3 2/4] usb: host: add xhci hooks for USB offload Daehwan Jung
2022-03-21 17:00 ` Mathias Nyman
2022-03-22 2:14 ` Jung Daehwan
[not found] ` <CGME20220321090205epcas2p4f3698a0aa49d251c0a8f008e85d968ba@epcas2p4.samsung.com>
2022-03-21 8:59 ` [PATCH v3 3/4] usb: host: add some to xhci overrides " Daehwan Jung
[not found] ` <CGME20220321090205epcas2p15ac16f281554b663062e0e31666defab@epcas2p1.samsung.com>
2022-03-21 8:59 ` [PATCH v3 4/4] usb: host: add xhci-exynos driver Daehwan Jung
2022-03-21 15:45 ` Bjørn Mork
2022-03-22 2:30 ` Jung Daehwan
2022-03-21 16:26 ` kernel test robot
2022-03-21 16:37 ` kernel test robot
2022-03-22 17:10 ` Krzysztof Kozlowski
2022-03-23 2:34 ` Jung Daehwan
2022-03-23 8:26 ` Krzysztof Kozlowski
2022-03-29 2:35 ` Jung Daehwan
2022-03-22 17:16 ` Krzysztof Kozlowski
2022-03-23 5:17 ` Jung Daehwan
2022-03-23 8:34 ` Krzysztof Kozlowski
2022-03-21 9:14 ` [PATCH v3 0/4] support USB offload feature Greg Kroah-Hartman
2022-03-21 9:24 ` Jung Daehwan
2022-03-21 9:32 ` Greg Kroah-Hartman
2022-03-21 10:06 ` Jung Daehwan
2022-03-21 10:16 ` Greg Kroah-Hartman
2022-03-22 2:17 ` Jung Daehwan
2022-03-22 17:05 ` Krzysztof Kozlowski
2022-03-23 1:31 ` Jung Daehwan
2022-03-23 8:25 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220323012242.GA19041@ubuntu \
--to=dh10.jung@samsung.com \
--cc=elavila@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=howardyen@google.com \
--cc=jackp@codeaurora.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=pumahsu@google.com \
--cc=sc.suh@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).