* [PATCH v2 0/3] mtd: rawnand: omap_elm: convert DT binding to yaml
@ 2022-03-25 12:37 Roger Quadros
2022-03-25 12:37 ` [PATCH v2 1/3] dt-bindings: mtd: ti,elm: Convert " Roger Quadros
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Roger Quadros @ 2022-03-25 12:37 UTC (permalink / raw)
To: miquel.raynal, robh+dt
Cc: richard, krzk, vigneshr, kishon, nm, linux-mtd, devicetree,
linux-kernel, Roger Quadros
Hi,
This series converts omap_elm DT bindings to yaml and adds
support for ELM on AM64 SoC.
Changelog:
v2
- explain hwmod usage deprecated in commit log
- fix example node name to 'ecc'
- remove 'items' for single compatible specifier
cheers,
-roger
Roger Quadros (3):
dt-bindings: mtd: ti,elm: Convert to yaml
dt-bindings: mtd: ti,elm: Add support for AM64 ELM
mtd: rawnand: omap_elm: Add compatible for AM64 ELM
Documentation/devicetree/bindings/mtd/elm.txt | 16 ----
.../devicetree/bindings/mtd/ti,elm.yaml | 73 +++++++++++++++++++
drivers/mtd/nand/raw/omap_elm.c | 1 +
3 files changed, 74 insertions(+), 16 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/mtd/elm.txt
create mode 100644 Documentation/devicetree/bindings/mtd/ti,elm.yaml
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 1/3] dt-bindings: mtd: ti,elm: Convert to yaml
2022-03-25 12:37 [PATCH v2 0/3] mtd: rawnand: omap_elm: convert DT binding to yaml Roger Quadros
@ 2022-03-25 12:37 ` Roger Quadros
2022-03-25 16:08 ` Rob Herring
` (2 more replies)
2022-03-25 12:37 ` [PATCH v2 2/3] dt-bindings: mtd: ti,elm: Add support for AM64 ELM Roger Quadros
2022-03-25 12:37 ` [PATCH v2 3/3] mtd: rawnand: omap_elm: Add compatible " Roger Quadros
2 siblings, 3 replies; 8+ messages in thread
From: Roger Quadros @ 2022-03-25 12:37 UTC (permalink / raw)
To: miquel.raynal, robh+dt
Cc: richard, krzk, vigneshr, kishon, nm, linux-mtd, devicetree,
linux-kernel, Roger Quadros
Convert elm.txt to ti,elm.yaml.
hwmod framework use is deprecated for new platforms
so mark it so.
Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
Documentation/devicetree/bindings/mtd/elm.txt | 16 -------
.../devicetree/bindings/mtd/ti,elm.yaml | 47 +++++++++++++++++++
2 files changed, 47 insertions(+), 16 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/mtd/elm.txt
create mode 100644 Documentation/devicetree/bindings/mtd/ti,elm.yaml
diff --git a/Documentation/devicetree/bindings/mtd/elm.txt b/Documentation/devicetree/bindings/mtd/elm.txt
deleted file mode 100644
index 59ddc61c1076..000000000000
--- a/Documentation/devicetree/bindings/mtd/elm.txt
+++ /dev/null
@@ -1,16 +0,0 @@
-Error location module
-
-Required properties:
-- compatible: Must be "ti,am3352-elm"
-- reg: physical base address and size of the registers map.
-- interrupts: Interrupt number for the elm.
-
-Optional properties:
-- ti,hwmods: Name of the hwmod associated to the elm
-
-Example:
-elm: elm@0 {
- compatible = "ti,am3352-elm";
- reg = <0x48080000 0x2000>;
- interrupts = <4>;
-};
diff --git a/Documentation/devicetree/bindings/mtd/ti,elm.yaml b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
new file mode 100644
index 000000000000..e36452b742c0
--- /dev/null
+++ b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
@@ -0,0 +1,47 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mtd/ti,elm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments Error Location Module (ELM).
+
+maintainers:
+ - Roger Quadros <rogerq@kernel.org>
+
+description:
+ ELM module is used together with GPMC and NAND Flash to detect
+ errors and the location of the error based on BCH algorithms
+ so they can be corrected if possible.
+
+properties:
+ compatible:
+ const: ti,am3352-elm
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ ti,hwmods:
+ description:
+ Name of the HWMOD associated with ELM. This is for legacy
+ platforms only.
+ $ref: /schemas/types.yaml#/definitions/string
+ deprecated: true
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+additionalProperties: false
+
+examples:
+ - |
+ elm: ecc@0 {
+ compatible = "ti,am3352-elm";
+ reg = <0x0 0x2000>;
+ interrupts = <4>;
+ };
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 2/3] dt-bindings: mtd: ti,elm: Add support for AM64 ELM
2022-03-25 12:37 [PATCH v2 0/3] mtd: rawnand: omap_elm: convert DT binding to yaml Roger Quadros
2022-03-25 12:37 ` [PATCH v2 1/3] dt-bindings: mtd: ti,elm: Convert " Roger Quadros
@ 2022-03-25 12:37 ` Roger Quadros
2022-03-25 16:22 ` Krzysztof Kozlowski
2022-03-25 12:37 ` [PATCH v2 3/3] mtd: rawnand: omap_elm: Add compatible " Roger Quadros
2 siblings, 1 reply; 8+ messages in thread
From: Roger Quadros @ 2022-03-25 12:37 UTC (permalink / raw)
To: miquel.raynal, robh+dt
Cc: richard, krzk, vigneshr, kishon, nm, linux-mtd, devicetree,
linux-kernel, Roger Quadros
TI's AM64 SoC has the Error Locator Module. Add compatible and
related properties to support ELM on AM64 SoC.
Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
.../devicetree/bindings/mtd/ti,elm.yaml | 28 ++++++++++++++++++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mtd/ti,elm.yaml b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
index e36452b742c0..967c87f32c71 100644
--- a/Documentation/devicetree/bindings/mtd/ti,elm.yaml
+++ b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
@@ -16,7 +16,10 @@ description:
properties:
compatible:
- const: ti,am3352-elm
+ items:
+ - enum:
+ - ti,am3352-elm
+ - ti,am64-elm
reg:
maxItems: 1
@@ -24,6 +27,17 @@ properties:
interrupts:
maxItems: 1
+ clocks:
+ maxItems: 1
+ description: Functional clock.
+
+ clock-names:
+ items:
+ - const: fck
+
+ power-domains:
+ maxItems: 1
+
ti,hwmods:
description:
Name of the HWMOD associated with ELM. This is for legacy
@@ -36,6 +50,18 @@ required:
- reg
- interrupts
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: ti,am64-elm
+ then:
+ required:
+ - clocks
+ - clock-names
+ - power-domains
+
additionalProperties: false
examples:
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 3/3] mtd: rawnand: omap_elm: Add compatible for AM64 ELM
2022-03-25 12:37 [PATCH v2 0/3] mtd: rawnand: omap_elm: convert DT binding to yaml Roger Quadros
2022-03-25 12:37 ` [PATCH v2 1/3] dt-bindings: mtd: ti,elm: Convert " Roger Quadros
2022-03-25 12:37 ` [PATCH v2 2/3] dt-bindings: mtd: ti,elm: Add support for AM64 ELM Roger Quadros
@ 2022-03-25 12:37 ` Roger Quadros
2 siblings, 0 replies; 8+ messages in thread
From: Roger Quadros @ 2022-03-25 12:37 UTC (permalink / raw)
To: miquel.raynal, robh+dt
Cc: richard, krzk, vigneshr, kishon, nm, linux-mtd, devicetree,
linux-kernel, Roger Quadros
The AM64 SoC has the Error Locator Module. Add compatible id for it.
Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
drivers/mtd/nand/raw/omap_elm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/nand/raw/omap_elm.c b/drivers/mtd/nand/raw/omap_elm.c
index db105d9b560c..aa7f49c3f372 100644
--- a/drivers/mtd/nand/raw/omap_elm.c
+++ b/drivers/mtd/nand/raw/omap_elm.c
@@ -550,6 +550,7 @@ static SIMPLE_DEV_PM_OPS(elm_pm_ops, elm_suspend, elm_resume);
#ifdef CONFIG_OF
static const struct of_device_id elm_of_match[] = {
{ .compatible = "ti,am3352-elm" },
+ { .compatible = "ti,am64-elm" },
{},
};
MODULE_DEVICE_TABLE(of, elm_of_match);
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: mtd: ti,elm: Convert to yaml
2022-03-25 12:37 ` [PATCH v2 1/3] dt-bindings: mtd: ti,elm: Convert " Roger Quadros
@ 2022-03-25 16:08 ` Rob Herring
2022-03-25 16:24 ` Krzysztof Kozlowski
2022-03-25 19:40 ` Rob Herring
2 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-03-25 16:08 UTC (permalink / raw)
To: Roger Quadros
Cc: nm, vigneshr, miquel.raynal, kishon, krzk, linux-mtd,
linux-kernel, robh+dt, devicetree, richard
On Fri, 25 Mar 2022 14:37:05 +0200, Roger Quadros wrote:
> Convert elm.txt to ti,elm.yaml.
>
> hwmod framework use is deprecated for new platforms
> so mark it so.
>
> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> ---
> Documentation/devicetree/bindings/mtd/elm.txt | 16 -------
> .../devicetree/bindings/mtd/ti,elm.yaml | 47 +++++++++++++++++++
> 2 files changed, 47 insertions(+), 16 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mtd/elm.txt
> create mode 100644 Documentation/devicetree/bindings/mtd/ti,elm.yaml
>
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/1609419
elm@0: 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/am437x-cm-t43.dt.yaml
arch/arm/boot/dts/am437x-gp-evm.dt.yaml
arch/arm/boot/dts/am437x-idk-evm.dt.yaml
arch/arm/boot/dts/am437x-sbc-t43.dt.yaml
arch/arm/boot/dts/am437x-sk-evm.dt.yaml
arch/arm/boot/dts/am43x-epos-evm.dt.yaml
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: mtd: ti,elm: Add support for AM64 ELM
2022-03-25 12:37 ` [PATCH v2 2/3] dt-bindings: mtd: ti,elm: Add support for AM64 ELM Roger Quadros
@ 2022-03-25 16:22 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-25 16:22 UTC (permalink / raw)
To: Roger Quadros, miquel.raynal, robh+dt
Cc: richard, vigneshr, kishon, nm, linux-mtd, devicetree, linux-kernel
On 25/03/2022 13:37, Roger Quadros wrote:
> TI's AM64 SoC has the Error Locator Module. Add compatible and
> related properties to support ELM on AM64 SoC.
>
> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> ---
> .../devicetree/bindings/mtd/ti,elm.yaml | 28 ++++++++++++++++++-
> 1 file changed, 27 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/ti,elm.yaml b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
> index e36452b742c0..967c87f32c71 100644
> --- a/Documentation/devicetree/bindings/mtd/ti,elm.yaml
> +++ b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
> @@ -16,7 +16,10 @@ description:
>
> properties:
> compatible:
> - const: ti,am3352-elm
> + items:
Why do the items appeared again?
Make it an enum in first patch, without items, with one entry. Now in
patch #2 you add one more compatible.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: mtd: ti,elm: Convert to yaml
2022-03-25 12:37 ` [PATCH v2 1/3] dt-bindings: mtd: ti,elm: Convert " Roger Quadros
2022-03-25 16:08 ` Rob Herring
@ 2022-03-25 16:24 ` Krzysztof Kozlowski
2022-03-25 19:40 ` Rob Herring
2 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-25 16:24 UTC (permalink / raw)
To: Roger Quadros, miquel.raynal, robh+dt
Cc: richard, vigneshr, kishon, nm, linux-mtd, devicetree, linux-kernel
On 25/03/2022 13:37, Roger Quadros wrote:
> Convert elm.txt to ti,elm.yaml.
>
> hwmod framework use is deprecated for new platforms
> so mark it so.
>
> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> ---
> Documentation/devicetree/bindings/mtd/elm.txt | 16 -------
> .../devicetree/bindings/mtd/ti,elm.yaml | 47 +++++++++++++++++++
> 2 files changed, 47 insertions(+), 16 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mtd/elm.txt
> create mode 100644 Documentation/devicetree/bindings/mtd/ti,elm.yaml
>
> diff --git a/Documentation/devicetree/bindings/mtd/elm.txt b/Documentation/devicetree/bindings/mtd/elm.txt
> deleted file mode 100644
> index 59ddc61c1076..000000000000
> --- a/Documentation/devicetree/bindings/mtd/elm.txt
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -Error location module
> -
> -Required properties:
> -- compatible: Must be "ti,am3352-elm"
> -- reg: physical base address and size of the registers map.
> -- interrupts: Interrupt number for the elm.
> -
> -Optional properties:
> -- ti,hwmods: Name of the hwmod associated to the elm
> -
> -Example:
> -elm: elm@0 {
> - compatible = "ti,am3352-elm";
> - reg = <0x48080000 0x2000>;
> - interrupts = <4>;
> -};
> diff --git a/Documentation/devicetree/bindings/mtd/ti,elm.yaml b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
> new file mode 100644
> index 000000000000..e36452b742c0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mtd/ti,elm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments Error Location Module (ELM).
> +
> +maintainers:
> + - Roger Quadros <rogerq@kernel.org>
> +
> +description:
> + ELM module is used together with GPMC and NAND Flash to detect
> + errors and the location of the error based on BCH algorithms
> + so they can be corrected if possible.
> +
> +properties:
> + compatible:
> + const: ti,am3352-elm
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
make dtbs complains, but it will be fixed in patch #2, so looks good:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: mtd: ti,elm: Convert to yaml
2022-03-25 12:37 ` [PATCH v2 1/3] dt-bindings: mtd: ti,elm: Convert " Roger Quadros
2022-03-25 16:08 ` Rob Herring
2022-03-25 16:24 ` Krzysztof Kozlowski
@ 2022-03-25 19:40 ` Rob Herring
2 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-03-25 19:40 UTC (permalink / raw)
To: Roger Quadros
Cc: linux-mtd, vigneshr, devicetree, linux-kernel, krzk, robh+dt, nm,
richard, kishon, miquel.raynal
On Fri, 25 Mar 2022 14:37:05 +0200, Roger Quadros wrote:
> Convert elm.txt to ti,elm.yaml.
>
> hwmod framework use is deprecated for new platforms
> so mark it so.
>
> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> ---
> Documentation/devicetree/bindings/mtd/elm.txt | 16 -------
> .../devicetree/bindings/mtd/ti,elm.yaml | 47 +++++++++++++++++++
> 2 files changed, 47 insertions(+), 16 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mtd/elm.txt
> create mode 100644 Documentation/devicetree/bindings/mtd/ti,elm.yaml
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-03-25 19:54 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-25 12:37 [PATCH v2 0/3] mtd: rawnand: omap_elm: convert DT binding to yaml Roger Quadros
2022-03-25 12:37 ` [PATCH v2 1/3] dt-bindings: mtd: ti,elm: Convert " Roger Quadros
2022-03-25 16:08 ` Rob Herring
2022-03-25 16:24 ` Krzysztof Kozlowski
2022-03-25 19:40 ` Rob Herring
2022-03-25 12:37 ` [PATCH v2 2/3] dt-bindings: mtd: ti,elm: Add support for AM64 ELM Roger Quadros
2022-03-25 16:22 ` Krzysztof Kozlowski
2022-03-25 12:37 ` [PATCH v2 3/3] mtd: rawnand: omap_elm: Add compatible " Roger Quadros
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).