From: Christoph Hellwig <hch@lst.de>
To: Michal Hocko <mhocko@suse.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>, Baoquan He <bhe@redhat.com>,
John Donnelly <john.p.donnelly@oracle.com>,
David Hildenbrand <david@redhat.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dma/pool: do not complain if DMA pool is not allocated
Date: Fri, 25 Mar 2022 17:48:56 +0100 [thread overview]
Message-ID: <20220325164856.GA16800@lst.de> (raw)
In-Reply-To: <Yj28gjonUa9+0yae@dhcp22.suse.cz>
On Fri, Mar 25, 2022 at 01:58:42PM +0100, Michal Hocko wrote:
> Dang, I have just realized that I have misread the boot log and it has
> turned out that a674e48c5443 is covering my situation because the
> allocation failure message says:
>
> Node 0 DMA free:0kB boost:0kB min:0kB low:0kB high:0kB reserved_highatomic:0KB active_anon:0kB inactive_anon:0kB active_file:0kB inactive_file:0kB unevictable:0kB writepending:0kB present:636kB managed:0kB mlocked:0kB bounce:0kB free_pcp:0kB local_pcp:0kB free_cma:0kB
As in your report is from a kernel that does not have a674e48c5443
yet?
>
> I thought there are only few pages in the managed by the DMA zone. This
> is still theoretically possible so I think __GFP_NOWARN makes sense here
> but it would require to change the patch description.
>
> Is this really worth it?
In general I think for kernels where we need the pool and can't allocate
it, a warning is very useful. We just shouldn't spew it when there is
no need for the pool to start with.
next prev parent reply other threads:[~2022-03-25 16:49 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 12:25 [PATCH] dma/pool: do not complain if DMA pool is not allocated Michal Hocko
2022-03-25 12:58 ` Michal Hocko
2022-03-25 16:48 ` Christoph Hellwig [this message]
2022-03-25 16:54 ` Michal Hocko
2022-08-03 9:52 ` Michal Hocko
2022-08-03 14:59 ` Baoquan He
2022-08-03 15:05 ` Michal Hocko
2022-08-03 15:32 ` Baoquan He
2022-08-03 15:44 ` Michal Hocko
2022-08-04 11:01 ` Baoquan He
2022-08-04 12:01 ` Michal Hocko
2022-08-05 12:34 ` Baoquan He
2022-08-05 17:37 ` Michal Hocko
2022-08-09 15:37 ` Michal Hocko
2022-08-10 1:32 ` Andrew Morton
2022-08-10 6:40 ` Michal Hocko
2022-08-10 2:19 ` Baoquan He
2022-08-11 7:38 ` Christoph Hellwig
2022-08-11 8:25 ` Michal Hocko
2022-08-11 7:34 ` Christoph Hellwig
2022-08-11 7:49 ` Christoph Hellwig
2022-08-11 8:42 ` Michal Hocko
2022-08-11 7:43 ` Christoph Hellwig
2022-08-11 7:29 ` Christoph Hellwig
2022-08-11 7:28 ` Christoph Hellwig
2022-08-11 8:20 ` Michal Hocko
2022-08-11 8:21 ` Christoph Hellwig
2022-08-11 8:33 ` Michal Hocko
2022-08-11 7:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220325164856.GA16800@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=david@redhat.com \
--cc=john.p.donnelly@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).