From: Christoph Hellwig <hch@lst.de>
To: Michal Hocko <mhocko@suse.com>
Cc: Baoquan He <bhe@redhat.com>, Christoph Hellwig <hch@lst.de>,
Andrew Morton <akpm@linux-foundation.org>,
John Donnelly <john.p.donnelly@oracle.com>,
David Hildenbrand <david@redhat.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dma/pool: do not complain if DMA pool is not allocated
Date: Thu, 11 Aug 2022 09:34:54 +0200 [thread overview]
Message-ID: <20220811073454.GD13886@lst.de> (raw)
In-Reply-To: <Yu1VTAxd9/jP/iEk@dhcp22.suse.cz>
On Fri, Aug 05, 2022 at 07:37:16PM +0200, Michal Hocko wrote:
> GFP_DMA is a misnomer. It doesn't really say that the allocation should
> be done for actual DMA. GFP_DMA really says allocate from ZONE_DMA.
Yes. But in practice that either is to do DMA of some form, including
the s390 variant not using the dma api, or completely stupid cargo
cult code.
> It
> is my understanding that all actual DMA users should use a dedicated dma
> allocation APIs which should do the right thing wrt. address constrains.
Yes. And we were at a point where we got to that, but it seems somewhat
recently a lot of people added completely stupid GFP_DMA kmallocs in the
all over the crypto drivers. Sigh...
next prev parent reply other threads:[~2022-08-11 7:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 12:25 [PATCH] dma/pool: do not complain if DMA pool is not allocated Michal Hocko
2022-03-25 12:58 ` Michal Hocko
2022-03-25 16:48 ` Christoph Hellwig
2022-03-25 16:54 ` Michal Hocko
2022-08-03 9:52 ` Michal Hocko
2022-08-03 14:59 ` Baoquan He
2022-08-03 15:05 ` Michal Hocko
2022-08-03 15:32 ` Baoquan He
2022-08-03 15:44 ` Michal Hocko
2022-08-04 11:01 ` Baoquan He
2022-08-04 12:01 ` Michal Hocko
2022-08-05 12:34 ` Baoquan He
2022-08-05 17:37 ` Michal Hocko
2022-08-09 15:37 ` Michal Hocko
2022-08-10 1:32 ` Andrew Morton
2022-08-10 6:40 ` Michal Hocko
2022-08-10 2:19 ` Baoquan He
2022-08-11 7:38 ` Christoph Hellwig
2022-08-11 8:25 ` Michal Hocko
2022-08-11 7:34 ` Christoph Hellwig [this message]
2022-08-11 7:49 ` Christoph Hellwig
2022-08-11 8:42 ` Michal Hocko
2022-08-11 7:43 ` Christoph Hellwig
2022-08-11 7:29 ` Christoph Hellwig
2022-08-11 7:28 ` Christoph Hellwig
2022-08-11 8:20 ` Michal Hocko
2022-08-11 8:21 ` Christoph Hellwig
2022-08-11 8:33 ` Michal Hocko
2022-08-11 7:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220811073454.GD13886@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=david@redhat.com \
--cc=john.p.donnelly@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).