* [PATCH v2] ceph: remove unused CEPH_MDS_LEASE_RELEASE related code
@ 2022-03-28 13:10 xiubli
2022-03-28 21:41 ` Jeff Layton
0 siblings, 1 reply; 2+ messages in thread
From: xiubli @ 2022-03-28 13:10 UTC (permalink / raw)
To: jlayton; +Cc: idryomov, vshankar, ceph-devel, linux-kernel, Xiubo Li
From: Xiubo Li <xiubli@redhat.com>
ceph_mdsc_lease_release was removed by commit 8aa152c77890 (ceph:
remove ceph_mdsc_lease_release). ceph_mdsc_lease_send_msg will never
call this function with CEPH_MDS_LEASE_RELEASE.
Signed-off-by: Xiubo Li <xiubli@redhat.com>
---
fs/ceph/mds_client.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
index 459c6f23915f..a89ee866ebbb 100644
--- a/fs/ceph/mds_client.c
+++ b/fs/ceph/mds_client.c
@@ -4424,12 +4424,6 @@ void ceph_mdsc_lease_send_msg(struct ceph_mds_session *session,
memcpy((void *)(lease + 1) + 4,
dentry->d_name.name, dentry->d_name.len);
spin_unlock(&dentry->d_lock);
- /*
- * if this is a preemptive lease RELEASE, no need to
- * flush request stream, since the actual request will
- * soon follow.
- */
- msg->more_to_follow = (action == CEPH_MDS_LEASE_RELEASE);
ceph_con_send(&session->s_con, msg);
}
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ceph: remove unused CEPH_MDS_LEASE_RELEASE related code
2022-03-28 13:10 [PATCH v2] ceph: remove unused CEPH_MDS_LEASE_RELEASE related code xiubli
@ 2022-03-28 21:41 ` Jeff Layton
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Layton @ 2022-03-28 21:41 UTC (permalink / raw)
To: xiubli; +Cc: idryomov, vshankar, ceph-devel, linux-kernel
On Mon, 2022-03-28 at 21:10 +0800, xiubli@redhat.com wrote:
> From: Xiubo Li <xiubli@redhat.com>
>
> ceph_mdsc_lease_release was removed by commit 8aa152c77890 (ceph:
> remove ceph_mdsc_lease_release). ceph_mdsc_lease_send_msg will never
> call this function with CEPH_MDS_LEASE_RELEASE.
>
> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> ---
> fs/ceph/mds_client.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
> index 459c6f23915f..a89ee866ebbb 100644
> --- a/fs/ceph/mds_client.c
> +++ b/fs/ceph/mds_client.c
> @@ -4424,12 +4424,6 @@ void ceph_mdsc_lease_send_msg(struct ceph_mds_session *session,
> memcpy((void *)(lease + 1) + 4,
> dentry->d_name.name, dentry->d_name.len);
> spin_unlock(&dentry->d_lock);
> - /*
> - * if this is a preemptive lease RELEASE, no need to
> - * flush request stream, since the actual request will
> - * soon follow.
> - */
> - msg->more_to_follow = (action == CEPH_MDS_LEASE_RELEASE);
>
> ceph_con_send(&session->s_con, msg);
> }
Reviewed-by: Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-28 22:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-28 13:10 [PATCH v2] ceph: remove unused CEPH_MDS_LEASE_RELEASE related code xiubli
2022-03-28 21:41 ` Jeff Layton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).