linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [Patch v1] iommu: arm-smmu: Use arm-smmu-nvidia impl for Tegra234
@ 2022-03-29  4:44 Ashish Mhetre
  2022-03-30 10:37 ` Thierry Reding
  0 siblings, 1 reply; 2+ messages in thread
From: Ashish Mhetre @ 2022-03-29  4:44 UTC (permalink / raw)
  To: thierry.reding, jonathanh, vdumpa, will, robin.murphy, joro,
	linux-arm-kernel, iommu, linux-kernel, linux-tegra
  Cc: Snikam, mperttunen, Ashish Mhetre

Tegra234 has 2 pairs of ARM MMU-500 instances. Each pair is used
together and should be programmed identically.
Add compatible string of Tegra234 iommu nodes in arm_smmu_impl_init()
so that arm-smmu-nvidia implementation will be used for programming
these SMMU instances.

Signed-off-by: Ashish Mhetre <amhetre@nvidia.com>
---
 drivers/iommu/arm/arm-smmu/arm-smmu-impl.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-impl.c b/drivers/iommu/arm/arm-smmu/arm-smmu-impl.c
index 2c25cce38060..658f3cc83278 100644
--- a/drivers/iommu/arm/arm-smmu/arm-smmu-impl.c
+++ b/drivers/iommu/arm/arm-smmu/arm-smmu-impl.c
@@ -211,7 +211,8 @@ struct arm_smmu_device *arm_smmu_impl_init(struct arm_smmu_device *smmu)
 	if (of_property_read_bool(np, "calxeda,smmu-secure-config-access"))
 		smmu->impl = &calxeda_impl;
 
-	if (of_device_is_compatible(np, "nvidia,tegra194-smmu") ||
+	if (of_device_is_compatible(np, "nvidia,tegra234-smmu") ||
+	    of_device_is_compatible(np, "nvidia,tegra194-smmu") ||
 	    of_device_is_compatible(np, "nvidia,tegra186-smmu"))
 		return nvidia_smmu_impl_init(smmu);
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Patch v1] iommu: arm-smmu: Use arm-smmu-nvidia impl for Tegra234
  2022-03-29  4:44 [Patch v1] iommu: arm-smmu: Use arm-smmu-nvidia impl for Tegra234 Ashish Mhetre
@ 2022-03-30 10:37 ` Thierry Reding
  0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2022-03-30 10:37 UTC (permalink / raw)
  To: Joerg Roedel
  Cc: Ashish Mhetre, jonathanh, vdumpa, will, robin.murphy,
	linux-arm-kernel, iommu, linux-kernel, linux-tegra, Snikam,
	mperttunen

[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]

On Tue, Mar 29, 2022 at 10:14:36AM +0530, Ashish Mhetre wrote:
> Tegra234 has 2 pairs of ARM MMU-500 instances. Each pair is used
> together and should be programmed identically.
> Add compatible string of Tegra234 iommu nodes in arm_smmu_impl_init()
> so that arm-smmu-nvidia implementation will be used for programming
> these SMMU instances.
> 
> Signed-off-by: Ashish Mhetre <amhetre@nvidia.com>
> ---
>  drivers/iommu/arm/arm-smmu/arm-smmu-impl.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

I already sent out this patch a couple of months ago, though I realize
that it still hasn't been applied:

	http://patchwork.ozlabs.org/project/linux-tegra/list/?series=276030

Joerg, any chance we can still get that series into v5.18? I've already
applied patch 4 given that Rob had acked the DT bindings changes. I know
it's a bit late, but this has been on the list for a couple of months
and has Rob's Reviewed-by on the bindings and Will's Acked-by on the ARM
SMMU driver patches.

If it's too late for v5.18, is there anything else you're waiting for so
that this can go into v5.19?

Thanks,
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-30 10:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-29  4:44 [Patch v1] iommu: arm-smmu: Use arm-smmu-nvidia impl for Tegra234 Ashish Mhetre
2022-03-30 10:37 ` Thierry Reding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).