From: Viresh Kumar <viresh.kumar@linaro.org>
To: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Cc: vireshk@kernel.org, nm@ti.com, sboyd@kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] opp: use list iterator only inside the loop
Date: Thu, 31 Mar 2022 08:19:07 +0530 [thread overview]
Message-ID: <20220331024906.i7ucvoxrkkfpb6w5@vireshk-i7> (raw)
In-Reply-To: <20220331023608.30497-1-xiam0nd.tong@gmail.com>
On 31-03-22, 10:36, Xiaomeng Tong wrote:
> The list iterator 'new_dev' will point to a bogus position containing
> HEAD if any one of these conditions is possible: the list is empty or
> no element is found, thus can potentially lead to an invalid memory
> access in 'dev = new_dev->dev;'.
There is no such bug as I explained earlier, why you added this again
despite being discussed ?
> As discussed before,
I just told you not to use such language as this will go in logs, but
you still chose to add it :(
> we should avoid to use a list iterator variable
> outside the loop which is considered harmful[1].
>
> In this case, use a new variable 'iter' as the list iterator, while
> use the old variable 'new_dev' as a dedicated pointer to point to the
> found entry. And BUG_ON(!new_dev);.
Please look at this on how to write the log, which fixes a very
similar problem.
https://lore.kernel.org/all/20220324071815.61405-1-jakobkoschel@gmail.com/
>
> [1]: https://lkml.org/lkml/2022/2/17/1032
>
> Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
> ---
>
> changes since v1:
> - use BUG_ON(!new_dev); instead of return; (Viresh Kumar)
>
> v1: https://lore.kernel.org/lkml/20220331015818.28045-1-xiam0nd.tong@gmail.com/
>
> ---
> drivers/opp/debugfs.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/opp/debugfs.c b/drivers/opp/debugfs.c
> index 596c185b5dda..81b2bc4b5f43 100644
> --- a/drivers/opp/debugfs.c
> +++ b/drivers/opp/debugfs.c
> @@ -187,14 +187,18 @@ void opp_debug_register(struct opp_device *opp_dev, struct opp_table *opp_table)
> static void opp_migrate_dentry(struct opp_device *opp_dev,
> struct opp_table *opp_table)
> {
> - struct opp_device *new_dev;
> + struct opp_device *new_dev = NULL, *iter;
> const struct device *dev;
> struct dentry *dentry;
>
> /* Look for next opp-dev */
> - list_for_each_entry(new_dev, &opp_table->dev_list, node)
> - if (new_dev != opp_dev)
> + list_for_each_entry(iter, &opp_table->dev_list, node)
> + if (iter != opp_dev) {
> + new_dev = iter;
> break;
> + }
> +
> + BUG_ON(!new_dev);
>
> /* new_dev is guaranteed to be valid here */
> dev = new_dev->dev;
> --
> 2.17.1
--
viresh
next prev parent reply other threads:[~2022-03-31 2:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 2:36 [PATCH v2] opp: use list iterator only inside the loop Xiaomeng Tong
2022-03-31 2:49 ` Viresh Kumar [this message]
2022-03-31 8:30 Xiaomeng Tong
2022-03-31 8:44 ` Viresh Kumar
2022-03-31 8:51 ` Xiaomeng Tong
2022-04-11 3:02 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220331024906.i7ucvoxrkkfpb6w5@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=sboyd@kernel.org \
--cc=vireshk@kernel.org \
--cc=xiam0nd.tong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).