From: Viresh Kumar <viresh.kumar@linaro.org>
To: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Cc: vireshk@kernel.org, nm@ti.com, sboyd@kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] opp: use list iterator only inside the loop
Date: Mon, 11 Apr 2022 08:32:05 +0530 [thread overview]
Message-ID: <20220411030205.gbql43daeky63ebr@vireshk-i7> (raw)
In-Reply-To: <20220331083018.31995-1-xiam0nd.tong@gmail.com>
On 31-03-22, 16:30, Xiaomeng Tong wrote:
> To move the list iterator variable into the list_for_each_entry_*()
> macro in the future it should be avoided to use the list iterator
> variable after the loop body.
>
> To *never* use the list iterator variable after the loop it was
> concluded to use a separate dedicated pointer variable [1].
>
> In this case, use a new variable 'iter' as the list iterator, while
> use the old variable 'new_dev' as a dedicated pointer to point to the
> found entry. And BUG_ON(!new_dev);.
>
> [1]: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
>
> Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
> ---
Applied. Thanks.
--
viresh
next prev parent reply other threads:[~2022-04-11 3:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 8:30 [PATCH v2] opp: use list iterator only inside the loop Xiaomeng Tong
2022-03-31 8:44 ` Viresh Kumar
2022-03-31 8:51 ` Xiaomeng Tong
2022-04-11 3:02 ` Viresh Kumar [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-03-31 2:36 Xiaomeng Tong
2022-03-31 2:49 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220411030205.gbql43daeky63ebr@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=sboyd@kernel.org \
--cc=vireshk@kernel.org \
--cc=xiam0nd.tong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).