linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] drivers: hwmon: jc42: add HWMON_C_TZ_REGISTER
@ 2022-03-18 23:30 Eduardo Valentin
  2022-03-20  1:01 ` Guenter Roeck
  2022-04-03 21:35 ` Guenter Roeck
  0 siblings, 2 replies; 4+ messages in thread
From: Eduardo Valentin @ 2022-03-18 23:30 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: Eduardo Valentin, Jean Delvare, linux-hwmon, linux-kernel,
	Eduardo Valentin

Add a thermal zone interface to the devices added
under jc42 driver. This way, thermal zones described
in device tree can make use of the of nodes of these
devices.

Cc: Guenter Roeck <linux@roeck-us.net> (maintainer:JC42.4 TEMPERATURE SENSOR DRIVER)
Cc: Jean Delvare <jdelvare@suse.com> (maintainer:HARDWARE MONITORING)
Cc: linux-hwmon@vger.kernel.org (open list:JC42.4 TEMPERATURE SENSOR DRIVER)
Cc: linux-kernel@vger.kernel.org (open list)

Signed-off-by: Eduardo Valentin <eduval@amazon.com>
Signed-off-by: Eduardo Valentin <evalenti@kernel.org>
---
 drivers/hwmon/jc42.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/hwmon/jc42.c b/drivers/hwmon/jc42.c
index cb347a6bd8d9..f40df2f29d41 100644
--- a/drivers/hwmon/jc42.c
+++ b/drivers/hwmon/jc42.c
@@ -443,6 +443,8 @@ static int jc42_detect(struct i2c_client *client, struct i2c_board_info *info)
 }
 
 static const struct hwmon_channel_info *jc42_info[] = {
+	HWMON_CHANNEL_INFO(chip,
+			   HWMON_C_REGISTER_TZ | HWMON_C_UPDATE_INTERVAL),
 	HWMON_CHANNEL_INFO(temp,
 			   HWMON_T_INPUT | HWMON_T_MIN | HWMON_T_MAX |
 			   HWMON_T_CRIT | HWMON_T_MAX_HYST |
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] drivers: hwmon: jc42: add HWMON_C_TZ_REGISTER
  2022-03-18 23:30 [PATCH 1/1] drivers: hwmon: jc42: add HWMON_C_TZ_REGISTER Eduardo Valentin
@ 2022-03-20  1:01 ` Guenter Roeck
  2022-03-21 23:44   ` Eduardo Valentin
  2022-04-03 21:35 ` Guenter Roeck
  1 sibling, 1 reply; 4+ messages in thread
From: Guenter Roeck @ 2022-03-20  1:01 UTC (permalink / raw)
  To: Eduardo Valentin
  Cc: Jean Delvare, linux-hwmon, linux-kernel, Eduardo Valentin

On 3/18/22 16:30, Eduardo Valentin wrote:
> Add a thermal zone interface to the devices added
> under jc42 driver. This way, thermal zones described
> in device tree can make use of the of nodes of these
> devices.
> 

Makes sense. I'll apply the patch, but it is a functional change
and a bit too risky to include in the upcoming commit window.
I'll apply it after the commit window closes.

Thanks,
Guenter

> Cc: Guenter Roeck <linux@roeck-us.net> (maintainer:JC42.4 TEMPERATURE SENSOR DRIVER)
> Cc: Jean Delvare <jdelvare@suse.com> (maintainer:HARDWARE MONITORING)
> Cc: linux-hwmon@vger.kernel.org (open list:JC42.4 TEMPERATURE SENSOR DRIVER)
> Cc: linux-kernel@vger.kernel.org (open list)
> 
> Signed-off-by: Eduardo Valentin <eduval@amazon.com>
> Signed-off-by: Eduardo Valentin <evalenti@kernel.org>
> ---
>   drivers/hwmon/jc42.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/hwmon/jc42.c b/drivers/hwmon/jc42.c
> index cb347a6bd8d9..f40df2f29d41 100644
> --- a/drivers/hwmon/jc42.c
> +++ b/drivers/hwmon/jc42.c
> @@ -443,6 +443,8 @@ static int jc42_detect(struct i2c_client *client, struct i2c_board_info *info)
>   }
>   
>   static const struct hwmon_channel_info *jc42_info[] = {
> +	HWMON_CHANNEL_INFO(chip,
> +			   HWMON_C_REGISTER_TZ | HWMON_C_UPDATE_INTERVAL),
>   	HWMON_CHANNEL_INFO(temp,
>   			   HWMON_T_INPUT | HWMON_T_MIN | HWMON_T_MAX |
>   			   HWMON_T_CRIT | HWMON_T_MAX_HYST |


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] drivers: hwmon: jc42: add HWMON_C_TZ_REGISTER
  2022-03-20  1:01 ` Guenter Roeck
@ 2022-03-21 23:44   ` Eduardo Valentin
  0 siblings, 0 replies; 4+ messages in thread
From: Eduardo Valentin @ 2022-03-21 23:44 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: Eduardo Valentin, Jean Delvare, linux-hwmon, linux-kernel,
	Eduardo Valentin

On Sat, Mar 19, 2022 at 06:01:27PM -0700, Guenter Roeck wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
> 
> 
> 
> On 3/18/22 16:30, Eduardo Valentin wrote:
> > Add a thermal zone interface to the devices added
> > under jc42 driver. This way, thermal zones described
> > in device tree can make use of the of nodes of these
> > devices.
> > 
> 
> Makes sense. I'll apply the patch, but it is a functional change
> and a bit too risky to include in the upcoming commit window.
> I'll apply it after the commit window closes.

Thank you Guenter. Yeah, this can go on the next window.

> 
> Thanks,
> Guenter
> 
> > Cc: Guenter Roeck <linux@roeck-us.net> (maintainer:JC42.4 TEMPERATURE SENSOR DRIVER)
> > Cc: Jean Delvare <jdelvare@suse.com> (maintainer:HARDWARE MONITORING)
> > Cc: linux-hwmon@vger.kernel.org (open list:JC42.4 TEMPERATURE SENSOR DRIVER)
> > Cc: linux-kernel@vger.kernel.org (open list)
> > 
> > Signed-off-by: Eduardo Valentin <eduval@amazon.com>
> > Signed-off-by: Eduardo Valentin <evalenti@kernel.org>
> > ---
> >   drivers/hwmon/jc42.c | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/hwmon/jc42.c b/drivers/hwmon/jc42.c
> > index cb347a6bd8d9..f40df2f29d41 100644
> > --- a/drivers/hwmon/jc42.c
> > +++ b/drivers/hwmon/jc42.c
> > @@ -443,6 +443,8 @@ static int jc42_detect(struct i2c_client *client, struct i2c_board_info *info)
> >   }
> > 
> >   static const struct hwmon_channel_info *jc42_info[] = {
> > +     HWMON_CHANNEL_INFO(chip,
> > +                        HWMON_C_REGISTER_TZ | HWMON_C_UPDATE_INTERVAL),
> >       HWMON_CHANNEL_INFO(temp,
> >                          HWMON_T_INPUT | HWMON_T_MIN | HWMON_T_MAX |
> >                          HWMON_T_CRIT | HWMON_T_MAX_HYST |
> 

-- 
All the best,
Eduardo Valentin

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] drivers: hwmon: jc42: add HWMON_C_TZ_REGISTER
  2022-03-18 23:30 [PATCH 1/1] drivers: hwmon: jc42: add HWMON_C_TZ_REGISTER Eduardo Valentin
  2022-03-20  1:01 ` Guenter Roeck
@ 2022-04-03 21:35 ` Guenter Roeck
  1 sibling, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2022-04-03 21:35 UTC (permalink / raw)
  To: Eduardo Valentin
  Cc: Jean Delvare, linux-hwmon, linux-kernel, Eduardo Valentin

On Fri, Mar 18, 2022 at 04:30:11PM -0700, Eduardo Valentin wrote:
> Add a thermal zone interface to the devices added
> under jc42 driver. This way, thermal zones described
> in device tree can make use of the of nodes of these
> devices.

Applied to hwmon-next.

Thanks,
Guenter

> 
> Cc: Guenter Roeck <linux@roeck-us.net> (maintainer:JC42.4 TEMPERATURE SENSOR DRIVER)
> Cc: Jean Delvare <jdelvare@suse.com> (maintainer:HARDWARE MONITORING)
> Cc: linux-hwmon@vger.kernel.org (open list:JC42.4 TEMPERATURE SENSOR DRIVER)
> Cc: linux-kernel@vger.kernel.org (open list)
> 
> Signed-off-by: Eduardo Valentin <eduval@amazon.com>
> Signed-off-by: Eduardo Valentin <evalenti@kernel.org>
> ---
>  drivers/hwmon/jc42.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/hwmon/jc42.c b/drivers/hwmon/jc42.c
> index cb347a6bd8d9..f40df2f29d41 100644
> --- a/drivers/hwmon/jc42.c
> +++ b/drivers/hwmon/jc42.c
> @@ -443,6 +443,8 @@ static int jc42_detect(struct i2c_client *client, struct i2c_board_info *info)
>  }
>  
>  static const struct hwmon_channel_info *jc42_info[] = {
> +	HWMON_CHANNEL_INFO(chip,
> +			   HWMON_C_REGISTER_TZ | HWMON_C_UPDATE_INTERVAL),
>  	HWMON_CHANNEL_INFO(temp,
>  			   HWMON_T_INPUT | HWMON_T_MIN | HWMON_T_MAX |
>  			   HWMON_T_CRIT | HWMON_T_MAX_HYST |

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-04-03 21:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-18 23:30 [PATCH 1/1] drivers: hwmon: jc42: add HWMON_C_TZ_REGISTER Eduardo Valentin
2022-03-20  1:01 ` Guenter Roeck
2022-03-21 23:44   ` Eduardo Valentin
2022-04-03 21:35 ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).