linux-next: build warnings after merge of the drm-misc tree

linux-next: build warnings after merge of the drm-misc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 823 bytes --]

Hi all,

After merging the drm-misc tree, today's linux-next build (KCONFIG_NAME)
produced these warnings:

drivers/gpu/drm/drm_edid.c:1589: warning: Function parameter or member '_edid' not described in 'drm_edid_header_is_valid'
drivers/gpu/drm/drm_edid.c:1589: warning: Excess function parameter 'raw_edid' description in 'drm_edid_header_is_valid'
drivers/gpu/drm/drm_edid.c:1737: warning: Function parameter or member '_block' not described in 'drm_edid_block_valid'
drivers/gpu/drm/drm_edid.c:1737: warning: Excess function parameter 'raw_edid' description in 'drm_edid_block_valid'

Introduced by commits

  6d987ddd6843 ("drm/edid: make drm_edid_header_is_valid() accept void pointer")
  1f221284ab63 ("drm/edid: split drm_edid_block_valid() to check and act parts")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of the drm-misc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

Hi all,

On Wed, 6 Apr 2022 15:44:31 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the drm-misc tree, today's linux-next build (KCONFIG_NAME)

This was an "htmldocs" build.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of the drm-misc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1071 bytes --]

Hi all,

On Wed, 6 Apr 2022 15:44:31 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the drm-misc tree, today's linux-next build (KCONFIG_NAME)
                                                             ^^^^^^^^^^^^
htmldocs

> produced these warnings:
> 
> drivers/gpu/drm/drm_edid.c:1589: warning: Function parameter or member '_edid' not described in 'drm_edid_header_is_valid'
> drivers/gpu/drm/drm_edid.c:1589: warning: Excess function parameter 'raw_edid' description in 'drm_edid_header_is_valid'
> drivers/gpu/drm/drm_edid.c:1737: warning: Function parameter or member '_block' not described in 'drm_edid_block_valid'
> drivers/gpu/drm/drm_edid.c:1737: warning: Excess function parameter 'raw_edid' description in 'drm_edid_block_valid'
> 
> Introduced by commits
> 
>   6d987ddd6843 ("drm/edid: make drm_edid_header_is_valid() accept void pointer")
>   1f221284ab63 ("drm/edid: split drm_edid_block_valid() to check and act parts")

These warnings are now produced by the drm tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warnings after merge of the drm-misc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 679 bytes --]

Hi all,

After merging the drm-misc tree, today's linux-next build (htmldocs)
produced these warnings:

drivers/gpu/drm/drm_fb_dma_helper.c:166: warning: Excess function parameter 'drm_scanout_buffer' description in 'drm_fb_dma_get_scanout_buffer'
drivers/gpu/drm/drm_fb_dma_helper.c:166: warning: Function parameter or struct member 'sb' not described in 'drm_fb_dma_get_scanout_buffer'
drivers/gpu/drm/drm_fb_dma_helper.c:166: warning: Excess function parameter 'drm_scanout_buffer' description in 'drm_fb_dma_get_scanout_buffer'

Introduced by commit

  879b3b6511fe ("drm/fb_dma: Add generic get_scanout_buffer() for drm_panic")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of the drm-misc tree

[Jocelyn Falempe]

On 16/04/2024 09:31, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the drm-misc tree, today's linux-next build (htmldocs)
> produced these warnings:
> 
> drivers/gpu/drm/drm_fb_dma_helper.c:166: warning: Excess function parameter 'drm_scanout_buffer' description in 'drm_fb_dma_get_scanout_buffer'
> drivers/gpu/drm/drm_fb_dma_helper.c:166: warning: Function parameter or struct member 'sb' not described in 'drm_fb_dma_get_scanout_buffer'
> drivers/gpu/drm/drm_fb_dma_helper.c:166: warning: Excess function parameter 'drm_scanout_buffer' description in 'drm_fb_dma_get_scanout_buffer'
> 

Hi,

Thanks for pointing that out. The parameter name is 'sb' and not 
'drm_scanout_buffer', I will send a fix.

Best regards,

-- 

Jocelyn

> Introduced by commit
> 
>    879b3b6511fe ("drm/fb_dma: Add generic get_scanout_buffer() for drm_panic")
> 

linux-next: build warnings after merge of the drm-misc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

Hi all,

After merging the drm-misc tree, today's linux-next build (htmldocs)
produced these warnings:

include/uapi/drm/panthor_drm.h:344: warning: Function parameter or struct member 'core_features' not described in 'drm_panthor_gpu_info'
include/uapi/drm/panthor_drm.h:344: warning: Function parameter or struct member 'pad' not described in 'drm_panthor_gpu_info'

Introduced by commit

  0f25e493a246 ("drm/panthor: Add uAPI")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warnings after merge of the drm-misc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 561 bytes --]

Hi all,

After merging the drm-misc tree, today's linux-next build (htmldocs)
produced these warnings:

include/drm/drm_plane.h:60: warning: expecting prototype for struct solid_fill_property. Prototype was for struct drm_solid_fill instead
include/drm/drm_plane.h:833: warning: Function parameter or member 'pixel_source_property' not described in 'drm_plane'

Introduced by commits

  e50e5fed41c7 ("drm: Introduce pixel_source DRM plane property")
  85863a4e16e7 ("drm: Introduce solid fill DRM plane property")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warnings after merge of the drm-misc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 694 bytes --]

Hi all,

After merging the drm-misc tree, today's linux-next build (htmldocs)
produced these warnings:

drivers/gpu/drm/scheduler/sched_main.c:738: warning: Excess function parameter 'file_private' description in 'drm_sched_job_add_syncobj_dependency'
drivers/gpu/drm/scheduler/sched_main.c:738: warning: Function parameter or member 'file' not described in 'drm_sched_job_add_syncobj_dependency'
drivers/gpu/drm/scheduler/sched_main.c:738: warning: Excess function parameter 'file_private' description in 'drm_sched_job_add_syncobj_dependency'

Introduced by commit

  c087bbb6d84e ("drm/sched: Create wrapper to add a syncobj dependency to job")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warnings after merge of the drm-misc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 511 bytes --]

Hi all,

After merging the drm-misc tree, today's linux-next build (htmldocs)
produced these warnings:

Documentation/gpu/drm-kms-helpers:241: include/drm/display/drm_dp_helper.h:377: WARNING: Unexpected indentation.
Documentation/gpu/drm-kms-helpers:241: include/drm/display/drm_dp_helper.h:378: WARNING: Block quote ends without a blank line; unexpected unindent.

Introduced by commit

  69ef4a192bba ("drm: Document the power requirements for DP AUX transfers")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of the drm-misc tree

[Doug Anderson]

Hi,

On Sat, Jun 11, 2022 at 1:21 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the drm-misc tree, today's linux-next build (htmldocs)
> produced these warnings:
>
> Documentation/gpu/drm-kms-helpers:241: include/drm/display/drm_dp_helper.h:377: WARNING: Unexpected indentation.
> Documentation/gpu/drm-kms-helpers:241: include/drm/display/drm_dp_helper.h:378: WARNING: Block quote ends without a blank line; unexpected unindent.
>
> Introduced by commit
>
>   69ef4a192bba ("drm: Document the power requirements for DP AUX transfers")

Thanks for the report. Fixed by:

https://lore.kernel.org/r/20220611095445.1.I534072d346b1ebbf0db565b714de9b65cbb24651@changeid

I'll plan to land it as soon as I see a Reviewed-by.

-Doug

linux-next: build warnings after merge of the drm-misc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 988 bytes --]

Hi all,

After merging the drm-misc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/gpu/drm/amd/amdgpu/amdgpu_display.c: In function 'amdgpu_display_user_framebuffer_create':
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c:929:24: warning: unused variable 'adev' [-Wunused-variable]
  929 |  struct amdgpu_device *adev = drm_to_adev(dev);
      |                        ^~~~

Introduced by commit

  8f66090b7bb7 ("drm/amdgpu: Remove references to struct drm_device.pdev")

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c: In function 'amdgpu_device_resize_fb_bar':
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1109:6: warning: unused variable 'space_needed' [-Wunused-variable]
 1109 |  u64 space_needed = roundup_pow_of_two(adev->gmc.real_vram_size);
      |      ^~~~~~~~~~~~

Introduced by commit

  453f617a30aa ("drm/amdgpu: Resize BAR0 to the maximum available size, even if it doesn't cover VRAM")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of the drm-misc tree

[Nirmoy]

Hi Stephen,

On 1/15/21 2:23 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the drm-misc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c: In function 'amdgpu_display_user_framebuffer_create':
> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c:929:24: warning: unused variable 'adev' [-Wunused-variable]
>    929 |  struct amdgpu_device *adev = drm_to_adev(dev);
>        |                        ^~~~
>
> Introduced by commit
>
>    8f66090b7bb7 ("drm/amdgpu: Remove references to struct drm_device.pdev")


I just sent a patch for this.


>
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c: In function 'amdgpu_device_resize_fb_bar':
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1109:6: warning: unused variable 'space_needed' [-Wunused-variable]
>   1109 |  u64 space_needed = roundup_pow_of_two(adev->gmc.real_vram_size);
>        |      ^~~~~~~~~~~~
>
> Introduced by commit
>
>    453f617a30aa ("drm/amdgpu: Resize BAR0 to the maximum available size, even if it doesn't cover VRAM")


We have a fix already merged in drm-misc-next for this.


Thanks,

Nirmoy

>

linux-next: build warnings after merge of the drm-misc tree

[Stephen Rothwell]

Hi all,

After merging the drm-misc tree, today's linux-next build (arm
multi_v7_defconfig) produced these warnings:

drivers/gpu/drm/exynos/exynos_drm_drv.c:290:2: warning: initialization from incompatible pointer type
  .get_vblank_counter = drm_vblank_count,
  ^
drivers/gpu/drm/exynos/exynos_drm_drv.c:290:2: warning: (near initialization for 'exynos_drm_driver.get_vblank_counter')
drivers/gpu/drm/rcar-du/rcar_du_drv.c:262:2: warning: initialization from incompatible pointer type
  .get_vblank_counter = drm_vblank_count,
  ^
drivers/gpu/drm/rcar-du/rcar_du_drv.c:262:2: warning: (near initialization for 'rcar_du_driver.get_vblank_counter')
drivers/gpu/drm/msm/msm_drv.c:981:2: warning: initialization from incompatible pointer type
  .get_vblank_counter = drm_vblank_count,
  ^
drivers/gpu/drm/msm/msm_drv.c:981:2: warning: (near initialization for 'msm_driver.get_vblank_counter')

Introduced by commit

  b90180b057f7 ("drm/irq: More pipe/crtc consistency cleanups")

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

Re: linux-next: build warnings after merge of the drm-misc tree

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1276 bytes --]

On Fri, Aug 14, 2015 at 03:35:32PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the drm-misc tree, today's linux-next build (arm
> multi_v7_defconfig) produced these warnings:
> 
> drivers/gpu/drm/exynos/exynos_drm_drv.c:290:2: warning: initialization from incompatible pointer type
>   .get_vblank_counter = drm_vblank_count,
>   ^
> drivers/gpu/drm/exynos/exynos_drm_drv.c:290:2: warning: (near initialization for 'exynos_drm_driver.get_vblank_counter')
> drivers/gpu/drm/rcar-du/rcar_du_drv.c:262:2: warning: initialization from incompatible pointer type
>   .get_vblank_counter = drm_vblank_count,
>   ^
> drivers/gpu/drm/rcar-du/rcar_du_drv.c:262:2: warning: (near initialization for 'rcar_du_driver.get_vblank_counter')
> drivers/gpu/drm/msm/msm_drv.c:981:2: warning: initialization from incompatible pointer type
>   .get_vblank_counter = drm_vblank_count,
>   ^
> drivers/gpu/drm/msm/msm_drv.c:981:2: warning: (near initialization for 'msm_driver.get_vblank_counter')
> 
> Introduced by commit
> 
>   b90180b057f7 ("drm/irq: More pipe/crtc consistency cleanups")

Yes, that patch turned out to be incomplete. Daniel suggested to remove
it from drm-misc for now and I'll address this fully in a larger patch
for 4.4.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

linux-next: build warnings after merge of the drm-misc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 4389 bytes --]

Hi all,

After merging the drm-misc tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:

drivers/gpu/drm/bochs/bochs_fbdev.c: In function 'bochsfb_create':
drivers/gpu/drm/bochs/bochs_fbdev.c:63:17: warning: unused variable 'device' [-Wunused-variable]
  struct device *device = &dev->pdev->dev;
                 ^

Caused by commit

  394111a2b303 ("drm/boschs: Use new drm_fb_helper functions")

drivers/gpu/drm/cirrus/cirrus_fbdev.c: In function 'cirrusfb_create':
drivers/gpu/drm/cirrus/cirrus_fbdev.c:247:1: warning: label 'out_iounmap' defined but not used [-Wunused-label]
 out_iounmap:
 ^

Caused by commit
  fd6ab591ce15 ("drm/cirrus: Use new drm_fb_helper functions")

drivers/gpu/drm/ast/ast_fb.c: In function 'astfb_create':
drivers/gpu/drm/ast/ast_fb.c:196:17: warning: unused variable 'device' [-Wunused-variable]
  struct device *device = &dev->pdev->dev;
                 ^

Caused by commit

  6f4900cd28c9 ("drm/ast: Use new drm_fb_helper functions")

drivers/gpu/drm/gma500/framebuffer.c: In function 'psbfb_create':
drivers/gpu/drm/gma500/framebuffer.c:346:17: warning: unused variable 'device' [-Wunused-variable]
  struct device *device = &dev->pdev->dev;
                 ^

Caused by commit

  3b9a13e85365 ("drm/gma500: Use new drm_fb_helper functions")

drivers/gpu/drm/mgag200/mgag200_fb.c: In function 'mgag200fb_create':
drivers/gpu/drm/mgag200/mgag200_fb.c:232:1: warning: label 'out' defined but not used [-Wunused-label]
 out:
 ^
drivers/gpu/drm/mgag200/mgag200_fb.c:169:17: warning: unused variable 'device' [-Wunused-variable]
  struct device *device = &dev->pdev->dev;
                 ^

Caused by commit

  53ebb642ccba ("drm/mgag200: Use new drm_fb_helper functions")

drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c: In function 'amdgpufb_create':
drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c:206:9: warning: passing argument 1 of 'PTR_ERR' makes pointer from integer without a cast
   ret = PTR_ERR(ret);
         ^
In file included from arch/x86/include/asm/processor.h:31:0,
                 from arch/x86/include/asm/thread_info.h:49,
                 from include/linux/thread_info.h:54,
                 from arch/x86/include/asm/preempt.h:6,
                 from include/linux/preempt.h:64,
                 from include/linux/spinlock.h:50,
                 from include/linux/seqlock.h:35,
                 from include/linux/time.h:5,
                 from include/linux/stat.h:18,
                 from include/linux/module.h:10,
                 from drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c:26:
include/linux/err.h:28:33: note: expected 'const void *' but argument is of type 'int'
 static inline long __must_check PTR_ERR(__force const void *ptr)
                                 ^
drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c:182:17: warning: unused variable 'device' [-Wunused-variable]
  struct device *device = &adev->pdev->dev;
                 ^
drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c: In function 'amdgpu_fbdev_destroy':
drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c:283:18: warning: unused variable 'info' [-Wunused-variable]
  struct fb_info *info;
                  ^

Caused by commit

  9d70561ba3b1 ("drm/amdgpu: Use new drm_fb_helper functions")

drivers/gpu/drm/udl/udl_fb.c: In function 'udlfb_create':
drivers/gpu/drm/udl/udl_fb.c:479:17: warning: unused variable 'device' [-Wunused-variable]
  struct device *device = dev->dev;
                 ^

Caused by commit

  457959f2ed5f ("drm/udl: Use new drm_fb_helper functions")

drivers/gpu/drm/radeon/radeon_fb.c: In function 'radeonfb_create':
drivers/gpu/drm/radeon/radeon_fb.c:230:17: warning: unused variable 'device' [-Wunused-variable]
  struct device *device = &rdev->pdev->dev;
                 ^

Caused by commit

  4bc29bb98bae ("drm/radeon: Use new drm_fb_helper functions")

drivers/gpu/drm/nouveau/nouveau_fbcon.c: In function 'nouveau_fbcon_create':
drivers/gpu/drm/nouveau/nouveau_fbcon.c:322:18: warning: unused variable 'pdev' [-Wunused-variable]
  struct pci_dev *pdev = dev->pdev;
                  ^

Caused by commit

  237fc6452ca5 ("drm/nouveau: Use new drm_fb_helper functions")

I think "COMPILE TESTED ONLY" should at least include eliminating such
warnings ...
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]